You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Trustin Lee (JIRA)" <di...@incubator.apache.org> on 2005/06/13 05:25:50 UTC

[jira] Closed: (DIREVE-160) Make CoreContextFactory more extensible

     [ http://issues.apache.org/jira/browse/DIREVE-160?page=all ]
     
Trustin Lee closed DIREVE-160:
------------------------------

    Resolution: Fixed

I added AbstractContextFactory that provides hook methods:

* beforeStartup( ContextFactoryContext )
* afterStartup( ContextFactoryContext )
* beforeShutdown( ContextFactoryContext )
* afterShutdown( ContextFactoryContext )
* beforeSync( ContextFactoryContext )
* afterSync( ContextFactoryContext )

CoreContextFactory now extends AbstractContextFactory with empty hook methods.  You can extend AbstractContextFactory and implement these hook methods.

> Make CoreContextFactory more extensible
> ---------------------------------------
>
>          Key: DIREVE-160
>          URL: http://issues.apache.org/jira/browse/DIREVE-160
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider
>     Versions: 0.8, 0.9
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.1

>
> For now, we override existing methods to extend CoreContextFactory, but it is not actually safe way to extend it.  We could use template method pattern so that users implement only template methods to extend CoreContextFactory.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Closed: (DIREVE-160) Make CoreContextFactory more extensible

Posted by Alex Karasulu <ao...@bellsouth.net>.
Trustin Lee (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DIREVE-160?page=all ]
>  
>
Snip ...

>I added AbstractContextFactory that provides hook methods:
>
>* beforeStartup( ContextFactoryContext )
>* afterStartup( ContextFactoryContext )
>* beforeShutdown( ContextFactoryContext )
>* afterShutdown( ContextFactoryContext )
>* beforeSync( ContextFactoryContext )
>* afterSync( ContextFactoryContext )
>
>CoreContextFactory now extends AbstractContextFactory with empty hook methods.  You can extend AbstractContextFactory and implement these hook methods.
>
>  
>
Good move Trustin! I like what you did here!  While I'm at it the push 
of initialization code to the JndiProvider is a good idea too.  I will 
look closer at the code shortly.  But I'm not surprised :-). 

Snip ...

Alex