You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/07/29 00:45:23 UTC
Review Request 36898: Added equality operators for http::Pipe.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
Bugs: MESOS-3162
https://issues.apache.org/jira/browse/MESOS-3162
Repository: mesos
Description
-------
See: MESOS-3162.
This is useful for checking connection equality.
Note that this is the same as Future, where Future is a shared
object: copies are considered equal.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36898/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler
Re: Review Request 36898: Added equality operators for http::Pipe.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/#review93364
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 28, 2015, 10:45 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36898/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 10:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-3162
> https://issues.apache.org/jira/browse/MESOS-3162
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See: MESOS-3162.
>
> This is useful for checking connection equality.
>
> Note that this is the same as Future, where Future is a shared
> object: copies are considered equal.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
> 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
>
> Diff: https://reviews.apache.org/r/36898/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 36898: Added equality operators for http::Pipe.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36898/#review93367
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36898]
All tests passed.
- Mesos ReviewBot
On July 28, 2015, 10:45 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36898/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 10:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-3162
> https://issues.apache.org/jira/browse/MESOS-3162
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See: MESOS-3162.
>
> This is useful for checking connection equality.
>
> Note that this is the same as Future, where Future is a shared
> object: copies are considered equal.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
> 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
>
> Diff: https://reviews.apache.org/r/36898/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>