You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/22 15:45:39 UTC
[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #20427: Refactor parameter definition of DistSQL for feature readwrite-splitting
sunkai-cai opened a new pull request, #20427:
URL: https://github.com/apache/shardingsphere/pull/20427
Fixes #20031.
Changes proposed in this pull request:
- Add parser test cases
- Refactor parameter definition of ReadwriteSplittingDistSQL
- Update parser test cases in module `shardingsphere-integration-test`
- Update docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #20427: Refactor parameter definition of DistSQL for feature readwrite-splitting
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #20427:
URL: https://github.com/apache/shardingsphere/pull/20427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20427: Refactor parameter definition of DistSQL for feature readwrite-splitting
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20427:
URL: https://github.com/apache/shardingsphere/pull/20427#issuecomment-1223533967
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20427?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20427](https://codecov.io/gh/apache/shardingsphere/pull/20427?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9a7e89) into [master](https://codecov.io/gh/apache/shardingsphere/commit/203606c877ff5f65620788dac48ee27df25fe6b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (203606c) will **increase** coverage by `0.03%`.
> The diff coverage is `30.43%`.
```diff
@@ Coverage Diff @@
## master #20427 +/- ##
============================================
+ Coverage 60.56% 60.59% +0.03%
- Complexity 2439 2441 +2
============================================
Files 3921 3926 +5
Lines 55223 55213 -10
Branches 9368 9363 -5
============================================
+ Hits 33444 33458 +14
+ Misses 18924 18903 -21
+ Partials 2855 2852 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eption/UnsupportedEncryptInsertValueException.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZXhjZXB0aW9uL1Vuc3VwcG9ydGVkRW5jcnlwdEluc2VydFZhbHVlRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../rewriter/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvcmV3cml0ZXIvRW5jcnlwdEluc2VydFZhbHVlUGFyYW1ldGVyUmV3cml0ZXIuamF2YQ==) | `2.17% <0.00%> (ø)` | |
| [...onfig/rule/ShardingAutoTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvY29uZmlnL3J1bGUvU2hhcmRpbmdBdXRvVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...apache/shardingsphere/sharding/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9UYWJsZVJ1bGUuamF2YQ==) | `83.96% <ø> (+1.55%)` | :arrow_up: |
| [...g/rule/YamlShardingAutoTableRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcveWFtbC9jb25maWcvcnVsZS9ZYW1sU2hhcmRpbmdBdXRvVGFibGVSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...YamlShardingAutoTableRuleConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcveWFtbC9zd2FwcGVyL3J1bGUvWWFtbFNoYXJkaW5nQXV0b1RhYmxlUnVsZUNvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `94.44% <ø> (+20.08%)` | :arrow_up: |
| [...on/distsql/handler/update/MigrateTableUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL01pZ3JhdGVUYWJsZVVwZGF0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../parser/core/MigrationDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWlncmF0aW9uL2Rpc3RzcWwvcGFyc2VyL2NvcmUvTWlncmF0aW9uRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../advanced/table/TranslatableTableScanExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2FkdmFuY2VkL3RhYmxlL1RyYW5zbGF0YWJsZVRhYmxlU2NhbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ation/executor/common/row/CommonRowEnumerator.java](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2NvbW1vbi9yb3cvQ29tbW9uUm93RW51bWVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/shardingsphere/pull/20427/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org