You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2015/11/17 09:29:09 UTC
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-core/pull/170
APEX-267 #resolve
@davidyan74 please merge this change. The change is attributed to jenkins@datatorrent.com
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chandnisingh/incubator-apex-core APEX-267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit a1818cdf6a7952665796d10664aa784014030f49
Author: MalharJenkins <je...@datatorrent.com>
Date: 2015-11-16T21:43:31Z
APEX-267 #resolve
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/170#discussion_r45105392
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -186,12 +193,13 @@
* is equivalent to infinity; The operator hence will be attempted to be recovered indefinitely unless this value
* is set to anything else.
*/
- Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<Integer>(new Integer2String());
+ Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<>(new Integer2String());
--- End diff --
IMHO that is not the part of this task. If that is the case then I can close this pull request and let someone else pick up the task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/170#discussion_r45099811
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -186,12 +193,13 @@
* is equivalent to infinity; The operator hence will be attempted to be recovered indefinitely unless this value
* is set to anything else.
*/
- Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<Integer>(new Integer2String());
+ Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<>(new Integer2String());
--- End diff --
Why is this the only place that changes <...> to <>? Should we change the rest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/170#discussion_r45101149
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -186,12 +193,13 @@
* is equivalent to infinity; The operator hence will be attempted to be recovered indefinitely unless this value
* is set to anything else.
*/
- Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<Integer>(new Integer2String());
+ Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<>(new Integer2String());
--- End diff --
I removed that from some so that the line doesn't wrap. This was incorrectly removed for this line. I will change it back. Will not change everything because that is not part of fixing style violations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/170#discussion_r45104741
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -186,12 +193,13 @@
* is equivalent to infinity; The operator hence will be attempted to be recovered indefinitely unless this value
* is set to anything else.
*/
- Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<Integer>(new Integer2String());
+ Attribute<Integer> RECOVERY_ATTEMPTS = new Attribute<>(new Integer2String());
--- End diff --
IMHO, we should just change <...> to <> in all relevant places. Line wrap should not be the main factor of doing this. We should be consistent and that's one of the main reasons why the code style change is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/170#discussion_r45099508
--- Diff: api/src/main/java/com/datatorrent/api/Component.java ---
@@ -103,7 +103,8 @@ public boolean equals(Object obj)
if (this.component != other.component && (this.component == null || !this.component.equals(other.component))) {
return false;
}
- if (this.getComplement() != other.getComplement() && (this.getComplement() == null || !this.getComplement().equals(other.getComplement()))) {
+ if (this.getComplement() != other.getComplement() && (this.getComplement() == null || !this.getComplement()
+ .equals(other.getComplement()))) {
--- End diff --
I think the line break should occur at &&
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-267 #resolve
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---