You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/21 07:15:17 UTC
[GitHub] [hive] pkumarsinha opened a new pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
pkumarsinha opened a new pull request #2413:
URL: https://github.com/apache/hive/pull/2413
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r656874508
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -3048,17 +3059,12 @@ public static void validateAcidPartitionLocation(String location, Configuration
* @param tree AST
*/
public static TxnType getTxnType(Configuration conf, ASTNode tree) {
- final ASTSearcher astSearcher = new ASTSearcher();
-
+ int tp = tree.getToken().getType();
Review comment:
doesn't seem to be used anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha merged pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha merged pull request #2413:
URL: https://github.com/apache/hive/pull/2413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha merged pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha merged pull request #2413:
URL: https://github.com/apache/hive/pull/2413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r657937252
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,41 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testReadOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ String dbName = testName.getMethodName();
+ String replDbName = "replicated_" + testName.getMethodName();
+ try {
+ primary.run("CREATE DATABASE " + dbName + " WITH DBPROPERTIES ( '" +
+ SOURCE_OF_REPLICATION + "' = '1,2,3')");
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("CREATE TABLE " + dbName + ".t1 (id int)");
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ primary.run("INSERT INTO " + dbName + ".t1 VALUES(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("USE " + dbName);
+ primary.run("DESCRIBE DATABASE " + dbName);
+ primary.run("DESCRIBE "+ dbName + ".t1");
+ primary.run("SELECT * FROM " + dbName + ".t1");
+ primary.run("SHOW TABLES " + dbName);
+ primary.run("SHOW TABLE EXTENDED LIKE 't1'");
+ primary.run("SHOW TBLPROPERTIES t1");
+ primary.run("EXPLAIN SELECT * from " + dbName + ".t1");
+ primary.run("SHOW LOCKS");
+ primary.run("EXPLAIN SHOW LOCKS");
Review comment:
Could you please add test case for 'EXPLAIN LOCKS \<query\>' that is widely used?
```
EXPLAIN LOCKS UPDATE target SET b = 1 WHERE p IN (SELECT t.q1 FROM source t WHERE t.a1=5)'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2413:
URL: https://github.com/apache/hive/pull/2413#issuecomment-865160700
@deniskuzZ: This PR extends the scope of the READ-ONLY transactions. If you have time, could you please take a look?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655513679
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -74,7 +74,7 @@
/**
* TestReplicationScenariosAcidTables - test replication for ACID tables.
*/
-@org.junit.Ignore("HIVE-25267")
+//@org.junit.Ignore("HIVE-25267")
Review comment:
Does this fix the flakiness issue mentioned in HIVE-25267?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655840289
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -74,7 +74,7 @@
/**
* TestReplicationScenariosAcidTables - test replication for ACID tables.
*/
-@org.junit.Ignore("HIVE-25267")
+//@org.junit.Ignore("HIVE-25267")
Review comment:
Thanks for the review @pvary . No, it doesn't. I wanted to get a feedback on this. Also, the current test were in this file only so had enabled it. I will revert this if I couldn't fix the flakiness as a part of JIRA
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r656888895
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -3048,17 +3059,12 @@ public static void validateAcidPartitionLocation(String location, Configuration
* @param tree AST
*/
public static TxnType getTxnType(Configuration conf, ASTNode tree) {
- final ASTSearcher astSearcher = new ASTSearcher();
-
+ int tp = tree.getToken().getType();
Review comment:
Oops!! Was using it while debugging something. Missed to remove it. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655840289
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -74,7 +74,7 @@
/**
* TestReplicationScenariosAcidTables - test replication for ACID tables.
*/
-@org.junit.Ignore("HIVE-25267")
+//@org.junit.Ignore("HIVE-25267")
Review comment:
Thanks for the review @pvary . No, it doesn't. I wanted to get a feedback on this. Also, the current test were in this file only so had enabled it. I will revert this if I couldn't fix the flakiness as a part of JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655841503
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655514162
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
Review comment:
nit: we should use camelcase for methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r657662547
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -182,10 +183,20 @@ public boolean accept(Path path) {
public static final int MAX_STATEMENTS_PER_TXN = 10000;
public static final Pattern LEGACY_BUCKET_DIGIT_PATTERN = Pattern.compile("^[0-9]{6}");
public static final Pattern BUCKET_PATTERN = Pattern.compile("bucket_([0-9]+)(_[0-9]+)?$");
+ private static final Set<Integer> READ_TXN_TOKENS = new HashSet<Integer>();
private static Cache<String, DirInfoValue> dirCache;
private static AtomicBoolean dirCacheInited = new AtomicBoolean();
+ static {
+ READ_TXN_TOKENS.addAll(Arrays.asList(
Review comment:
Yes, they are covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r656877394
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -182,10 +183,20 @@ public boolean accept(Path path) {
public static final int MAX_STATEMENTS_PER_TXN = 10000;
public static final Pattern LEGACY_BUCKET_DIGIT_PATTERN = Pattern.compile("^[0-9]{6}");
public static final Pattern BUCKET_PATTERN = Pattern.compile("bucket_([0-9]+)(_[0-9]+)?$");
+ private static final Set<Integer> READ_TXN_TOKENS = new HashSet<Integer>();
private static Cache<String, DirInfoValue> dirCache;
private static AtomicBoolean dirCacheInited = new AtomicBoolean();
+ static {
+ READ_TXN_TOKENS.addAll(Arrays.asList(
Review comment:
does it cover SHOW LOCKS and EXPLAIN LOCKS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2413:
URL: https://github.com/apache/hive/pull/2413#issuecomment-865160700
@deniskuzZ: This PR extends the scope of the READ-ONLY transactions. If you have time, could you please take a look?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r657937252
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,41 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testReadOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ String dbName = testName.getMethodName();
+ String replDbName = "replicated_" + testName.getMethodName();
+ try {
+ primary.run("CREATE DATABASE " + dbName + " WITH DBPROPERTIES ( '" +
+ SOURCE_OF_REPLICATION + "' = '1,2,3')");
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("CREATE TABLE " + dbName + ".t1 (id int)");
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ primary.run("INSERT INTO " + dbName + ".t1 VALUES(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("USE " + dbName);
+ primary.run("DESCRIBE DATABASE " + dbName);
+ primary.run("DESCRIBE "+ dbName + ".t1");
+ primary.run("SELECT * FROM " + dbName + ".t1");
+ primary.run("SHOW TABLES " + dbName);
+ primary.run("SHOW TABLE EXTENDED LIKE 't1'");
+ primary.run("SHOW TBLPROPERTIES t1");
+ primary.run("EXPLAIN SELECT * from " + dbName + ".t1");
+ primary.run("SHOW LOCKS");
+ primary.run("EXPLAIN SHOW LOCKS");
Review comment:
Could you please add test case for 'EXPLAIN LOCKS <query>' that is widely used?
```
EXPLAIN LOCKS UPDATE target SET b = 1 WHERE p IN (SELECT t.q1 FROM source t WHERE t.a1=5)'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655513679
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -74,7 +74,7 @@
/**
* TestReplicationScenariosAcidTables - test replication for ACID tables.
*/
-@org.junit.Ignore("HIVE-25267")
+//@org.junit.Ignore("HIVE-25267")
Review comment:
Does this fix the flakiness issue mentioned in HIVE-25267?
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
Review comment:
nit: we should use camelcase for methods
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("create table " + primaryDbName + ".t1 (id int)");
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ primary.run("insert into " + primaryDbName + ".t1 values(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("DESCRIBE DATABASE " + primaryDbName );
+ primary.run("SELECT * from " + primaryDbName + ".t1");
+ primary.run("SHOW tables " + primaryDbName);
Review comment:
What is the reason behind running these commands but discarding the results?
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("create table " + primaryDbName + ".t1 (id int)");
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ primary.run("insert into " + primaryDbName + ".t1 values(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("DESCRIBE DATABASE " + primaryDbName );
+ primary.run("SELECT * from " + primaryDbName + ".t1");
+ primary.run("SHOW tables " + primaryDbName);
Review comment:
never mind, I got it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655517089
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("create table " + primaryDbName + ".t1 (id int)");
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ primary.run("insert into " + primaryDbName + ".t1 values(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("DESCRIBE DATABASE " + primaryDbName );
+ primary.run("SELECT * from " + primaryDbName + ".t1");
+ primary.run("SHOW tables " + primaryDbName);
Review comment:
What is the reason behind running these commands but discarding the results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2413: HIVE-25272: READ transactions are getting logged in NOTIFICATION LOG
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655517694
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws Throwable {
+ //Perform empty bootstrap dump and load
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("create table " + primaryDbName + ".t1 (id int)");
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ //Perform empty incremental dump and load so that all db level properties are altered.
+ primary.dump(primaryDbName);
+ replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName);
+ primary.run("insert into " + primaryDbName + ".t1 values(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("DESCRIBE DATABASE " + primaryDbName );
+ primary.run("SELECT * from " + primaryDbName + ".t1");
+ primary.run("SHOW tables " + primaryDbName);
Review comment:
never mind, I got it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org