[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5745: conditional broadcastUri

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5745:
URL: https://github.com/apache/cloudstack/pull/5745#discussion_r761896093



##########
File path: ui/src/config/section/network.js
##########
@@ -29,8 +29,20 @@ export default {
       icon: 'apartment',
       permission: ['listNetworks'],
       resourceType: 'Network',
-      columns: ['name', 'state', 'type', 'vpcname', 'cidr', 'ip6cidr', 'broadcasturi', 'domain', 'account', 'zonename'],
-      details: ['name', 'id', 'description', 'type', 'traffictype', 'vpcid', 'vlan', 'broadcasturi', 'cidr', 'ip6cidr', 'netmask', 'gateway', 'aclname', 'ispersistent', 'restartrequired', 'reservediprange', 'redundantrouter', 'networkdomain', 'zonename', 'account', 'domain'],
+      columns: () => {
+        var fields = ['name', 'state', 'type', 'vpcname', 'cidr', 'ip6cidr', 'broadcasturi', 'domain', 'account', 'zonename']
+        if (!['Admin'].includes(store.getters.userInfo.roletype)) {

Review comment:
       may be, this can be moved to a util method _isAdmin()_
   
   ```suggestion
           if (!isAdmin()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org