You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/03/02 00:01:16 UTC
Re: Review Request 18182: HIVE-5370. format_number udf should take
user specifed format as argument
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18182/
-----------------------------------------------------------
(Updated March 1, 2016, 11:01 p.m.)
Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu.
Changes
-------
Patch updated to master
Bugs: HIVE-5370
https://issues.apache.org/jira/browse/HIVE-5370
Repository: hive-git
Description (updated)
-------
Added the format as optional argument.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 71ca8f2
ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9
ql/src/test/queries/clientpositive/udf_format_number.q 28f087d
ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800
ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c
ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1
ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f
ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d
Diff: https://reviews.apache.org/r/18182/diff/
Testing
-------
Unit tested
Thanks,
Amareshwari Sriramadasu
Re: Review Request 18182: HIVE-5370. format_number udf should take
user specifed format as argument
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18182/
-----------------------------------------------------------
(Updated March 3, 2016, 6:19 a.m.)
Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu.
Changes
-------
Review comments incorporated
Bugs: HIVE-5370
https://issues.apache.org/jira/browse/HIVE-5370
Repository: hive-git
Description
-------
Added the format as optional argument.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 71ca8f2
ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9
ql/src/test/queries/clientpositive/udf_format_number.q 28f087d
ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800
ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c
ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1
ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f
ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d
Diff: https://reviews.apache.org/r/18182/diff/
Testing
-------
Unit tested
Thanks,
Amareshwari Sriramadasu
Re: Review Request 18182: HIVE-5370. format_number udf should take
user specifed format as argument
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 2, 2016, 5:53 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java, line 178
> > <https://reviews.apache.org/r/18182/diff/3/?file=1275798#file1275798line178>
> >
> > I assume you only allow F to be a constant string. If so, this evaluation can happen at compile time in initialize(). You can obtain value via ConstantStringOI.
Yes. Makes sense. Updated.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18182/#review121679
-----------------------------------------------------------
On March 3, 2016, 6:19 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18182/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 6:19 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu.
>
>
> Bugs: HIVE-5370
> https://issues.apache.org/jira/browse/HIVE-5370
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the format as optional argument.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 71ca8f2
> ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9
> ql/src/test/queries/clientpositive/udf_format_number.q 28f087d
> ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800
> ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c
> ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1
> ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f
> ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d
>
> Diff: https://reviews.apache.org/r/18182/diff/
>
>
> Testing
> -------
>
> Unit tested
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 18182: HIVE-5370. format_number udf should take
user specifed format as argument
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18182/#review121679
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java (line 178)
<https://reviews.apache.org/r/18182/#comment183440>
I assume you only allow F to be a constant string. If so, this evaluation can happen at compile time in initialize(). You can obtain value via ConstantStringOI.
- Ashutosh Chauhan
On March 1, 2016, 11:01 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18182/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 11:01 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu.
>
>
> Bugs: HIVE-5370
> https://issues.apache.org/jira/browse/HIVE-5370
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the format as optional argument.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 71ca8f2
> ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9
> ql/src/test/queries/clientpositive/udf_format_number.q 28f087d
> ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800
> ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c
> ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1
> ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f
> ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d
>
> Diff: https://reviews.apache.org/r/18182/diff/
>
>
> Testing
> -------
>
> Unit tested
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>