You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2011/07/03 21:38:16 UTC

bval TCK

Hi,

i wonder how we could pass bval tck,

i mean, in the jsr303 there is nothing useable to pass TCKs, in JEE 6 spec
only the Validator and ValidatorFactory are described.

However in the tck set a lot of standalone (not jee) tests are present and i
don't know how we should pass them.


Any clues/help?

- Romain

Re: bval TCK

Posted by Romain Manni-Bucau <rm...@gmail.com>.
look it (it is in the bval-embedded i commited).. it does nothing, simply
plays with classloading to manage resources...so it tests apache bval not
geronimo...maybe it is the correct approach, i don't know how does glassfish
or other jee containers.

- Romain

2011/7/3 David Blevins <da...@gmail.com>

>
> On Jul 3, 2011, at 2:24 PM, Romain Manni-Bucau wrote:
>
> > it is before it, i copied what you did in fact ;)
> >
> > however i have some issues, a simple example could maybe help:
>
> Yeah, what I created is actually not the right setup for official
> certification.  It doesn't use TomEE at all.
>
> Maybe take a look at the Geronimo bval setup:
>
>
> https://svn.apache.org/repos/asf/geronimo/tck/branches/3.0/validator-tck-runner
>
> They seem to run it with the ServletTestLauncher, but for some reason it
> also has:
>
>
>  org.jboss.testharness.spi.StandaloneContainers=org.hibernate.jsr303.tck.util.StandaloneContainersImpl
>
> Not sure what's up with that, but it passes all the tests.
>
>
> -David
>
> > 2011/7/3 David Blevins <da...@gmail.com>
> >
> >> On Jul 3, 2011, at 12:38 PM, Romain Manni-Bucau wrote:
> >>
> >>> Hi,
> >>>
> >>> i wonder how we could pass bval tck,
> >>>
> >>> i mean, in the jsr303 there is nothing useable to pass TCKs, in JEE 6
> >> spec
> >>> only the Validator and ValidatorFactory are described.
> >>>
> >>> However in the tck set a lot of standalone (not jee) tests are present
> >> and i
> >>> don't know how we should pass them.
> >>
> >> If it is anything like the CDI TCK, we need to run standalone=false for
> >> TomEE.  Basically a matter of booting TomEE, implementing the test suite
> >> hooks to deploy what the test suite gives us (should be a war or an
> ear),
> >> then the tests would be run over a servlet -- there's a build-in runner
> >> called WebAppLauncher or something that you use instead of the
> >> LocalTestLauncher.  That's the the CDI TCK does anyway.
> >>
> >> I figured out a way to run most of it embedded (standalone=true), but
> >> that's more for convenience than a requirement since we can't actually
> pass
> >> all the tests that way.
> >>
> >>
> >> -David
> >>
> >>
>
>

Re: bval TCK

Posted by David Blevins <da...@gmail.com>.
On Jul 3, 2011, at 2:24 PM, Romain Manni-Bucau wrote:

> it is before it, i copied what you did in fact ;)
> 
> however i have some issues, a simple example could maybe help:

Yeah, what I created is actually not the right setup for official certification.  It doesn't use TomEE at all.

Maybe take a look at the Geronimo bval setup:

  https://svn.apache.org/repos/asf/geronimo/tck/branches/3.0/validator-tck-runner

They seem to run it with the ServletTestLauncher, but for some reason it also has:

  org.jboss.testharness.spi.StandaloneContainers=org.hibernate.jsr303.tck.util.StandaloneContainersImpl

Not sure what's up with that, but it passes all the tests.


-David

> 2011/7/3 David Blevins <da...@gmail.com>
> 
>> On Jul 3, 2011, at 12:38 PM, Romain Manni-Bucau wrote:
>> 
>>> Hi,
>>> 
>>> i wonder how we could pass bval tck,
>>> 
>>> i mean, in the jsr303 there is nothing useable to pass TCKs, in JEE 6
>> spec
>>> only the Validator and ValidatorFactory are described.
>>> 
>>> However in the tck set a lot of standalone (not jee) tests are present
>> and i
>>> don't know how we should pass them.
>> 
>> If it is anything like the CDI TCK, we need to run standalone=false for
>> TomEE.  Basically a matter of booting TomEE, implementing the test suite
>> hooks to deploy what the test suite gives us (should be a war or an ear),
>> then the tests would be run over a servlet -- there's a build-in runner
>> called WebAppLauncher or something that you use instead of the
>> LocalTestLauncher.  That's the the CDI TCK does anyway.
>> 
>> I figured out a way to run most of it embedded (standalone=true), but
>> that's more for convenience than a requirement since we can't actually pass
>> all the tests that way.
>> 
>> 
>> -David
>> 
>> 


Re: bval TCK

Posted by Romain Manni-Bucau <rm...@gmail.com>.
it is before it, i copied what you did in fact ;)

however i have some issues, a simple example could maybe help:

a test verify that if the configuration is bad a ValidationException is
thrown -> in OpenEJB it is wrapped (of course we are in a container)

well a lot of tests are like it...finally if we make everything pass...we
have the apache bval tests.

- Romain

2011/7/3 David Blevins <da...@gmail.com>

> On Jul 3, 2011, at 12:38 PM, Romain Manni-Bucau wrote:
>
> > Hi,
> >
> > i wonder how we could pass bval tck,
> >
> > i mean, in the jsr303 there is nothing useable to pass TCKs, in JEE 6
> spec
> > only the Validator and ValidatorFactory are described.
> >
> > However in the tck set a lot of standalone (not jee) tests are present
> and i
> > don't know how we should pass them.
>
> If it is anything like the CDI TCK, we need to run standalone=false for
> TomEE.  Basically a matter of booting TomEE, implementing the test suite
> hooks to deploy what the test suite gives us (should be a war or an ear),
> then the tests would be run over a servlet -- there's a build-in runner
> called WebAppLauncher or something that you use instead of the
> LocalTestLauncher.  That's the the CDI TCK does anyway.
>
> I figured out a way to run most of it embedded (standalone=true), but
> that's more for convenience than a requirement since we can't actually pass
> all the tests that way.
>
>
> -David
>
>

Re: bval TCK

Posted by David Blevins <da...@gmail.com>.
On Jul 3, 2011, at 12:38 PM, Romain Manni-Bucau wrote:

> Hi,
> 
> i wonder how we could pass bval tck,
> 
> i mean, in the jsr303 there is nothing useable to pass TCKs, in JEE 6 spec
> only the Validator and ValidatorFactory are described.
> 
> However in the tck set a lot of standalone (not jee) tests are present and i
> don't know how we should pass them.

If it is anything like the CDI TCK, we need to run standalone=false for TomEE.  Basically a matter of booting TomEE, implementing the test suite hooks to deploy what the test suite gives us (should be a war or an ear), then the tests would be run over a servlet -- there's a build-in runner called WebAppLauncher or something that you use instead of the LocalTestLauncher.  That's the the CDI TCK does anyway.

I figured out a way to run most of it embedded (standalone=true), but that's more for convenience than a requirement since we can't actually pass all the tests that way.


-David