You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2026/03/24 10:28:07 UTC

[PR] Ensure Spark-SQL works correctly when using lance as base file format [hudi]

wombatu-kun opened a new pull request, #18375:
URL: https://github.com/apache/hudi/pull/18375

   ### Describe the issue this Pull Request addresses
   
   Closes https://github.com/apache/hudi/issues/18268
   
   ### Summary and Changelog
   
   Parametrized some Spark-Sql tests with baseFileFormat and fixed bugs
   
   ### Impact
   
   Spark-SQL works correctly when using lance as base file format
   
   ### Risk Level
   
   low
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117311681

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.53%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.53%   -22.85%     
   + Complexity    27505    14798    -12707     
   =============================================
     Files          2428     1963      -465     
     Lines        132926   105823    -27103     
     Branches      16000    12863     -3137     
   =============================================
   - Hits          90902    48188    -42714     
   - Misses        34964    52703    +17739     
   + Partials       7060     4932     -2128     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.47% <17.09%> (-12.95%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <72.72%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1598 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117081237

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0435c7f6d049444a4661a24aa9160fb23714af94 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117525208

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.35043%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.15%   -0.23%     
   + Complexity    27505    27440      -65     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    90799     -103     
   - Misses        34964    35403     +439     
   + Partials       7060     7020      -40     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <27.35%> (-0.04%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <17.94%> (-0.24%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.75% <72.72%> (-0.92%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035479919


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/TestQueryMergeOnReadOptimizedTable.scala:
##########
@@ -19,63 +19,72 @@
 
 package org.apache.spark.sql.hudi.feature
 
+import org.apache.hudi.HoodieSparkUtils
+
 import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase
+import org.scalatest.Inspectors.forAll
 
 class TestQueryMergeOnReadOptimizedTable extends HoodieSparkSqlTestBase {
-  test("Test Query Merge_On_Read Read_Optimized table") {
-    withTempDir { tmp =>
-      val tableName = generateTableName
-      val tablePath = s"${tmp.getCanonicalPath}/$tableName"
-      // create table
-      spark.sql(
-        s"""
-           |create table $tableName (
-           |  id int,
-           |  name string,
-           |  price double,
-           |  ts long,
-           |  partition long
-           |) using hudi
-           | partitioned by (partition)
-           | location '$tablePath'
-           | tblproperties (
-           |  type = 'mor',
-           |  primaryKey = 'id',
-           |  orderingFields = 'ts'
-           | )
-       """.stripMargin)
-      // insert data to table
-      withSQLConf("hoodie.parquet.max.file.size" -> "10000") {
-        spark.sql(s"insert into $tableName values(1, 'a1', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(2, 'a2', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(3, 'a3', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(4, 'a4', 10, 1000, 1000)")
-        spark.sql(s"update $tableName set price = 11 where id = 1")
-        spark.sql(s"update $tableName set price = 21 where id = 2")
-        spark.sql(s"update $tableName set price = 31 where id = 3")
-        spark.sql(s"update $tableName set price = 41 where id = 4")
 
-        // expect that all complete parquet files can be scanned
-        assertQueryResult(4, tablePath)
+  val baseFileFormats: List[String] = if (HoodieSparkUtils.gteqSpark3_4) List("parquet", "lance") else List("parquet")
+
+  forAll(baseFileFormats) { (baseFileFormat: String) =>
+    test(s"Test Query Merge_On_Read Read_Optimized table - $baseFileFormat") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        val tablePath = s"${tmp.getCanonicalPath}/$tableName"
+        // create table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  name string,
+             |  price double,
+             |  ts long,
+             |  partition long
+             |) using hudi
+             | partitioned by (partition)
+             | location '$tablePath'
+             | tblproperties (
+             |  type = 'mor',
+             |  primaryKey = 'id',

Review Comment:
   Intentional — `orderingFields = 'ts'` triggers `EVENT_TIME_ORDERING` mode, which auto-selects `DefaultSparkRecordMerger` for lance's SPARK record type. Added a comment explaining this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3036762313


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -21,25 +21,73 @@ package org.apache.hudi
 
 import org.apache.avro.generic.{GenericRecord, IndexedRecord}
 import org.apache.hudi.common.engine.RecordContext
+import org.apache.hudi.common.model.HoodieRecord
 import org.apache.hudi.common.schema.HoodieSchema
 import org.apache.hudi.common.table.HoodieTableConfig
+import org.apache.hudi.exception.HoodieException
 import org.apache.spark.sql.HoodieInternalRowUtils
 import org.apache.spark.sql.avro.{HoodieAvroDeserializer, HoodieAvroSerializer}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.hudi.SparkAdapter
 
+import java.io.IOException
+import java.util.Properties
 import scala.collection.mutable
 
 trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContext {
 
   lazy val sparkAdapter: SparkAdapter = SparkAdapterSupport.sparkAdapter
   private val deserializerMap: mutable.Map[HoodieSchema, HoodieAvroDeserializer] = mutable.Map()
   private val serializerMap: mutable.Map[HoodieSchema, HoodieAvroSerializer] = mutable.Map()
+  // Maps InternalRow instances (by identity) to their original Avro records when the Avro record's

Review Comment:
   The singleton is only used from `HoodieSparkRecord.isDeleteRecord()`, which calls `isDeleteRecordByColumnValue()` — this path never populates the `avroRecordByRow` cache (`extractDataFromRecord` and `convertToAvroRecord` are never called on the singleton). The cache stays empty, so thread-safety is a non-issue in practice. Added a comment documenting this invariant so it doesn't regress silently.



##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -21,25 +21,84 @@ package org.apache.hudi
 
 import org.apache.avro.generic.{GenericRecord, IndexedRecord}
 import org.apache.hudi.common.engine.RecordContext
+import org.apache.hudi.common.model.HoodieRecord
 import org.apache.hudi.common.schema.HoodieSchema
 import org.apache.hudi.common.table.HoodieTableConfig
+import org.apache.hudi.exception.HoodieException
 import org.apache.spark.sql.HoodieInternalRowUtils
 import org.apache.spark.sql.avro.{HoodieAvroDeserializer, HoodieAvroSerializer}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.hudi.SparkAdapter
 
+import java.io.IOException
+import java.util.Properties
 import scala.collection.mutable
 
 trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContext {
 
   lazy val sparkAdapter: SparkAdapter = SparkAdapterSupport.sparkAdapter
   private val deserializerMap: mutable.Map[HoodieSchema, HoodieAvroDeserializer] = mutable.Map()
   private val serializerMap: mutable.Map[HoodieSchema, HoodieAvroSerializer] = mutable.Map()
+  // Maps InternalRow instances (by identity) to their original Avro records when the Avro record's
+  // schema differs from the BufferedRecord schema. This handles ExpressionPayload records whose
+  // getInsertValue result carries the data schema (no meta fields) while the BufferedRecord
+  // stores writeSchemaWithMetaFields. Returning the original Avro record from convertToAvroRecord
+  // lets ExpressionPayload.combineAndGetUpdateValue decode bytes with the correct data schema.
+  //
+  // IMPORTANT INVARIANT: The identity link between InternalRow and GenericRecord must survive
+  // from extractDataFromRecord (where the cache is populated) to convertToAvroRecord (where
+  // it is consumed via remove()). Any operation that replaces the InternalRow object in between
+  // — such as BufferedRecord.seal() (which calls InternalRow.copy()), replaceRecord(), or
+  // project() — would break this link and cause fallback to schema-based serialization.

Review Comment:
   The leak is bounded — it can only happen for SENTINEL/ignored records that get cached but bypass `convertToAvroRecord`. The `SparkFileFormatInternalRecordContext` instance is scoped to a single FileGroup read, so any leaked entries are GC'd when the reader finishes. Added a lifecycle comment documenting this.



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -251,8 +251,11 @@ public static Collection<Pair<String, Long>> filterKeysFromFile(StoragePath file
       return Collections.emptyList();
     }
     log.info("Going to filter {} keys from file {}", candidateRecordKeys.size(), filePath);

Review Comment:
   Correct — this is pre-existing behavior, not a regression from this PR. The old code was hardcoded to AVRO as well. Added a TODO to respect the merger's configured record type in a follow-up.



##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -136,18 +140,49 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
         GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        Schema recordAvroSchema = recordSchema.toAvroSchema();
+
+        // If convertToAvroRecord returned a cached record with a different schema (e.g., from
+        // extractDataFromRecord caching for ExpressionPayload in the COW write path), the record
+        // is already in write-schema format with correctly evaluated expressions. Convert directly.
+        // Note: SENTINEL records (used by ExpressionPayload to signal "skip this record") always
+        // have null schema (HoodieRecord.EmptyRecord.getSchema() returns null), so they cannot
+        // enter this branch and will always go through the payload path where shouldIgnore handles them.
+        if (record.getSchema() != null && !record.getSchema().equals(recordAvroSchema)) {
+          mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(record));
+        } else {
+          HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
+          try {
+            if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
+              return null;
+            }
+            // Evaluate the payload to get the insert value
+            Option<IndexedRecord> insertValueOpt = hoodieRecord.getData().getInsertValue(recordAvroSchema, properties);
+            if (insertValueOpt.isPresent()) {
+              GenericRecord insertRecord = (GenericRecord) insertValueOpt.get();
+              HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();

Review Comment:
   The record is emitted immediately after `replaceRecord()` via `super.handleNonDeletes()` — there is no spill or serialization step between `replaceRecord` and emit where a stale `schemaId` could cause issues. Added a comment documenting this no-spill assumption.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4187018437

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `28.04878%` with `118 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.88%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a032f3c`](https://app.codecov.io/gh/apache/hudi/commit/a032f3c9e7c93dc725260a909e188e2645dcb98d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (a032f3c). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (a032f3c) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   58.88%   -9.65%     
   + Complexity    27968    24018    -3950     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134589     +133     
     Branches      16226    16283      +57     
   ============================================
   - Hits          92138    79249   -12889     
   - Misses        35054    48552   +13498     
   + Partials       7264     6788     -476     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <15.24%> (+0.12%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <15.32%> (-0.13%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <12.02%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <14.02%> (-16.37%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <25.60%> (-13.04%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.22% <66.66%> (-7.27%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `76.92% <80.00%> (-4.03%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.57% <75.00%> (-3.31%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `90.41% <63.15%> (-6.37%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [677 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4187009139

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.43902%` with `119 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.75%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a032f3c`](https://app.codecov.io/gh/apache/hudi/commit/a032f3c9e7c93dc725260a909e188e2645dcb98d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (a032f3c). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (a032f3c) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.75%   -22.78%     
   + Complexity    27968    15297    -12671     
   =============================================
     Files          2440     1972      -468     
     Lines        134456   109082    -25374     
     Branches      16226    13587     -2639     
   =============================================
   - Hits          92138    49908    -42230     
   - Misses        35054    53906    +18852     
   + Partials       7264     5268     -1996     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <15.32%> (-0.13%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <12.02%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <25.60%> (-12.90%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `76.92% <80.00%> (-4.03%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.57% <75.00%> (-3.31%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.08% <63.15%> (-18.70%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1573 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188704137

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `30.30303%` with `115 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.27%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (ebbf353). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (ebbf353) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.27%   -23.26%     
   + Complexity    27968    15510    -12458     
   =============================================
     Files          2440     2001      -439     
     Lines        134456   111691    -22765     
     Branches      16226    14137     -2089     
   =============================================
   - Hits          92138    50566    -41572     
   - Misses        35054    55698    +20644     
   + Partials       7264     5427     -1837     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.62% <27.87%> (-13.03%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `74.07% <66.66%> (-6.88%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.08% <63.15%> (-18.70%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1558 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188717197

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * a032f3c9e7c93dc725260a909e188e2645dcb98d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070) 
   * ebbf353f9f3785b17ded961be299271837bcb6c1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188723157

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `41.21212%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.30%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   66.30%   -2.22%     
   + Complexity    27968    26987     -981     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   - Hits          92138    89245    -2893     
   - Misses        35054    37874    +2820     
   - Partials       7264     7471     +207     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <15.15%> (-16.37%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <38.78%> (-0.16%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.30% <12.12%> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <100.00%> (+4.23%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `54.43% <100.00%> (-15.19%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [382 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159108437

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.36%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   67.36%   -0.90%     
   + Complexity    27761    27420     -341     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   - Hits          91715    90594    -1121     
   - Misses        35543    36706    +1163     
   - Partials       7097     7179      +82     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <32.67%> (-3.80%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <37.25%> (+0.22%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [149 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4158959992

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `13.49206%` with `109 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.90%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 7.40% | [24 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   44.90%   -23.36%     
   + Complexity    27761     8457    -19304     
   =============================================
     Files          2439     1197     -1242     
     Lines        134355    61733    -72622     
     Branches      16210     6626     -9584     
   =============================================
   - Hits          91715    27721    -63994     
   + Misses        35543    30986     -4557     
   + Partials       7097     3026     -4071     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `57.77% <66.66%> (-31.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `55.55% <40.00%> (-16.32%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `56.33% <41.17%> (-40.44%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `12.75% <7.40%> (-79.92%)` | :arrow_down: |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3084651176


##########
hudi-common/src/main/java/org/apache/hudi/common/engine/RecordContext.java:
##########
@@ -244,6 +244,23 @@ public Comparable convertOrderingValueToEngineType(Comparable value) {
 
   public abstract GenericRecord convertToAvroRecord(T record, HoodieSchema schema);
 
+  /**
+   * Reports whether the most recent {@link #convertToAvroRecord} call returned an Avro
+   * record produced upstream (e.g. cached by {@link #extractDataFromRecord} for
+   * ExpressionPayload) rather than one freshly serialized from the engine-native record.
+   *
+   * <p>This is an explicit signal intended to disambiguate the "came from cache" case from
+   * a legitimate schema-evolution skew between writer and reader schemas. Callers that need
+   * to branch on this distinction should invoke this method immediately after the
+   * corresponding {@code convertToAvroRecord} call; the flag is single-shot and resets on read.
+   *
+   * <p>Default implementation returns {@code false} for engines/contexts that do not
+   * maintain such a cache.
+   */
+  public boolean consumeLastAvroRecordFromCache() {
+    return false;
+  }

Review Comment:
   Eliminated together with the cache (per the `ExtractedData` refactor in 0964e8ad34e4) — the method is gone from `RecordContext` entirely. The signal now lives on the data itself (`BufferedRecord.getOriginalAvroRecord()`), so there's no engine-agnostic hook to leak into Avro/Flink contexts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250265088

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.90610%` with `128 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.00%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 27.27% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 69.56% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   48.00%   -20.53%     
   + Complexity    27968    16474    -11494     
   =============================================
     Files          2440     2008      -432     
     Lines        134456   112349    -22107     
     Branches      16226    14265     -1961     
   =============================================
   - Hits          92138    53928    -38210     
   - Misses        35054    52754    +17700     
   + Partials       7264     5667     -1597     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <24.88%> (-15.60%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.56% <37.08%> (-13.09%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.44% <90.90%> (-7.47%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1515 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250234036

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.43662%` with `129 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.68%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 65.21% | [3 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 27.27% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.68%   -21.84%     
   + Complexity    27968    15015    -12953     
   =============================================
     Files          2440     1944      -496     
     Lines        134456   104891    -29565     
     Branches      16226    12642     -3584     
   =============================================
   - Hits          92138    48971    -43167     
   - Misses        35054    50883    +15829     
   + Partials       7264     5037     -2227     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <37.08%> (-12.55%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1616 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273290723

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `36.81818%` with `139 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.46%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 33.33% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (4920828). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (4920828) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|18|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.87%   48.46%   -20.42%     
   + Complexity    28272    16282    -11990     
   =============================================
     Files          2464     1983      -481     
     Lines        135594   110142    -25452     
     Branches      16447    13777     -2670     
   =============================================
   - Hits          93389    53375    -40014     
   - Misses        34815    51235    +16420     
   + Partials       7390     5532     -1858     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.53% <21.36%> (-15.38%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <34.09%> (-12.78%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `73.68% <85.71%> (-1.32%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1530 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273316638

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.18182%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.20%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   65.20%   -3.67%     
   + Complexity    28272    22519    -5753     
   ============================================
     Files          2464     2012     -452     
     Lines        135594   112745   -22849     
     Branches      16447    14331    -2116     
   ============================================
   - Hits          93389    73519   -19870     
   + Misses        34815    32604    -2211     
   + Partials       7390     6622     -768     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <50.45%> (-3.76%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.69% <45.45%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `81.90% <100.00%> (-7.59%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [922 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250478084

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.05164%` with `100 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 69.56% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 81.81% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.82%   +0.30%     
   - Complexity    27968    28233     +265     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135373     +917     
     Branches      16226    16407     +181     
   ============================================
   + Hits          92138    93175    +1037     
   + Misses        35054    34817     -237     
   - Partials       7264     7381     +117     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.57%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <46.94%> (+0.11%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <45.07%> (+0.11%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <23.47%> (-0.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251677759

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.36652%` with `134 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 49.12%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (68c3a7c). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (68c3a7c) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   49.12%   -19.41%     
   + Complexity    27968    16126    -11842     
   =============================================
     Files          2440     1973      -467     
     Lines        134456   107651    -26805     
     Branches      16226    13263     -2963     
   =============================================
   - Hits          92138    52884    -39254     
   - Misses        35054    49378    +14324     
   + Partials       7264     5389     -1875     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.53% <23.98%> (-15.24%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <36.65%> (-12.57%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `73.68% <85.71%> (-1.32%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3085930840


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -135,19 +139,59 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
       if (previousRecord == null) {
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
-        GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        GenericRecord originalAvro = mergedRecord.getOriginalAvroRecord();
+        Schema recordAvroSchema = recordSchema.toAvroSchema();
+
+        // When the merged record carries an originalAvroRecord (populated by extractDataFromRecord
+        // for ExpressionPayload in the COW write path via ExtractedData), the record is already in
+        // write-schema format with correctly evaluated expressions. Convert directly and skip the
+        // payload path.
+        //
+        // NOTE: this branch bypasses shouldIgnore. That is safe today because the only payload that
+        // populates originalAvroRecord is ExpressionPayload, which never returns shouldIgnore=true.
+        // If a future payload starts producing an originalAvroRecord, it must add a shouldIgnore
+        // check here.
+        if (originalAvro != null) {
+          // After replaceRecord(), mergedRecord.getSchemaId() still references the original schema.
+          // This is safe because the record is emitted immediately via super.handleNonDeletes() below,
+          // which calls seal() and produces the output row — the record is not spilled to disk
+          // (via toBinary()) between replaceRecord and emit in this single-record path. If this
+          // assumption changes, the schemaId must be updated after replaceRecord.
+          mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(originalAvro));
+        } else {
+          GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
+          HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
+          try {
+            if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
+              return null;
+            }
+            // Evaluate the payload to get the insert value
+            Option<IndexedRecord> insertValueOpt = hoodieRecord.getData().getInsertValue(recordAvroSchema, properties);
+            if (insertValueOpt.isPresent()) {
+              GenericRecord insertRecord = (GenericRecord) insertValueOpt.get();
+              HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
+              GenericRecord finalRecord;
+              if (insertRecord.getSchema().equals(recordAvroSchema)) {
+                // Payload preserved the schema (e.g., OverwriteWithLatestAvroPayload).
+                // Rewrite to full reader schema including meta fields.
+                finalRecord = HoodieAvroUtils.rewriteRecordWithNewSchema(insertRecord, readerSchema.toAvroSchema());

Review Comment:
   Fixed in 68c3a7c. Dropped the `(GenericRecord)` cast — `insertRecord` is now declared as `IndexedRecord`. Both subsequent call sites (`insertRecord.getSchema()` and `HoodieAvroUtils.rewriteRecordWithNewSchema(IndexedRecord, Schema)`) already accept the narrower interface, so no behavior change and no ClassCastException surface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3085928880


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1276,8 +1277,9 @@ private Set<String> getDropPartitionColNames() {
   }
 
   public ReaderContextFactory<T> getReaderContextFactoryForWrite() {
+    HoodieRecord.HoodieRecordType recordType =
+        metaClient.getTableConfig().getBaseFileFormat().resolveRecordType(config.getRecordMerger().getRecordType());
     // question: should we just return null when context is serialized as null? the mismatch reader context would throw anyway.
-    return (ReaderContextFactory<T>) getContext().getReaderContextFactoryForWrite(metaClient, config.getRecordMerger().getRecordType(),
-        config.getProps());
+    return (ReaderContextFactory<T>) getContext().getReaderContextFactoryForWrite(metaClient, recordType, config.getProps());

Review Comment:
   Fixed in 68c3a7c. Switched to the effective `getBaseFileFormat()` on `HoodieTable` (which wraps `CommonClientUtils.getBaseFileFormat(config, tableConfig)`), so writer-side overrides and fresh Lance tables resolve the correct record type for the reader context.



##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -40,6 +44,40 @@ trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContex
     HoodieSparkUtils.gteqSpark3_5
   }
 
+  /**
+   * Extracts the engine-native record data from a [[HoodieRecord]].
+   *
+   * For Spark records the data is already an [[InternalRow]]. For records coming from
+   * Avro-payload-based paths (e.g. [[org.apache.spark.sql.hudi.command.payload.ExpressionPayload]]
+   * used in SQL MERGE INTO operations), the Avro representation is extracted via
+   * [[HoodieRecord#toIndexedRecord]] and then deserialized to [[InternalRow]]. When the Avro
+   * record's schema differs from the BufferedRecord schema (e.g. ExpressionPayload's
+   * getInsertValue returns a data-schema record while the buffered schema is
+   * writeSchemaWithMetaFields), the original Avro record is propagated through
+   * [[ExtractedData]] so downstream code can decode it with the correct source schema.
+   */
+  override def extractDataFromRecord(record: HoodieRecord[_], schema: HoodieSchema, properties: Properties): ExtractedData[InternalRow] = {
+    val data = record.getData
+    if (data == null || data.isInstanceOf[InternalRow]) {
+      ExtractedData.of(data.asInstanceOf[InternalRow])
+    } else {
+      try {
+        val avroRecordOpt = record.toIndexedRecord(schema, properties)
+        if (avroRecordOpt.isPresent) {
+          val avroRecord = avroRecordOpt.get().getData.asInstanceOf[GenericRecord]
+          val row = convertAvroRecord(avroRecord)
+          val originalAvro = if (!avroRecord.getSchema.equals(schema.toAvroSchema)) avroRecord else null
+          ExtractedData.of(row, originalAvro)

Review Comment:
   Fixed in 68c3a7c. `indexedRecord` is now kept as `IndexedRecord` and passed straight to `convertAvroRecord` (which already accepts that interface). Narrowing to `GenericRecord` happens only when populating `originalAvro`, via a pattern match — no more unconditional `asInstanceOf[GenericRecord]`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251769677

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.55%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   67.55%   -0.97%     
   + Complexity    27968    27673     -295     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   - Hits          92138    91459     -679     
   - Misses        35054    36555    +1501     
   - Partials       7264     7367     +103     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <46.15%> (-3.72%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <45.24%> (-0.45%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [318 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278158209

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `38.49558%` with `139 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.38%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (aa562f8). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (aa562f8) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|18|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   61.38%   -7.50%     
   + Complexity    28272    25228    -3044     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    83483    -9906     
   - Misses        34815    45505   +10690     
   + Partials       7390     7022     -368     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <23.00%> (-16.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <35.84%> (-12.90%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278197876

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `49.11504%` with `115 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.26%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   66.26%   -2.61%     
   + Complexity    28272    27249    -1023     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    90126    -3263     
   - Misses        34815    38328    +3513     
   - Partials       7390     7556     +166     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <23.00%> (-16.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <46.90%> (-0.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [350 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278219309

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.89%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   67.89%   -0.99%     
   + Complexity    28272    27950     -322     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    92339    -1050     
   - Misses        34815    36226    +1411     
   - Partials       7390     7445      +55     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <51.76%> (-3.69%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <46.90%> (+0.11%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278593021

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * aa562f8015ebdf4972ca2db62de73691d7ccce1c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.

hudi-agent commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3107476150


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +403,45 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Use the schema-aware constructHoodieRecord overload so existingRecordContext
+    // can register the schema locally and resolve it for SPARK records.
+    HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+    HoodieRecord<R> result = mergedSchema != null
+        ? existingRecordContext.constructHoodieRecord(mergeResult, partitionPath, mergedSchema)
+        : existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
     HoodieRecord<R> withMeta = result.prependMetaFields(writeSchema, writeSchemaWithMetaFields,
         new MetadataValues().setRecordKey(incoming.getRecordKey()).setPartitionPath(partitionPath), properties);
     return Option.of(withMeta.wrapIntoHoodieRecordPayloadWithParams(writeSchemaWithMetaFields, properties, Option.empty(),
         config.allowOperationMetadataField(), Option.empty(), false, Option.of(writeSchema)));
   }
 
   private static <R> String inferPartitionPath(HoodieRecord<R> incoming, HoodieRecord<R> existing, HoodieSchema recordSchema, BaseKeyGenerator keyGenerator,

Review Comment:
   🤖 nit: nine parameters is a lot to juggle, especially with three `BufferedRecord` and two `RecordContext` arguments whose names follow similar patterns (`incomingBufferedRecord`/`existingBufferedRecord`/`resultingBufferedRecord`, `existingRecordContext`/`incomingRecordContext`) — easy to transpose at call sites. Could this be inlined at its two call sites, or could the `(HoodieRecord, BufferedRecord, RecordContext)` triple for each side be bundled into a small private record/wrapper?
   
   <sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieReadHandle.java:
##########
@@ -68,14 +70,17 @@ protected HoodieBaseFile getLatestBaseFile() {
   }
 
   protected HoodieFileReader createNewFileReader() throws IOException {
-    return HoodieIOFactory.getIOFactory(hoodieTable.getStorage())
-        .getReaderFactory(this.config.getRecordMerger().getRecordType())
-        .getFileReader(config, getLatestBaseFile().getStoragePath());
+    return createNewFileReader(getLatestBaseFile());
   }
 
   protected HoodieFileReader createNewFileReader(HoodieBaseFile hoodieBaseFile) throws IOException {
+    String extension = hoodieBaseFile.getStoragePath().getFileExtension();

Review Comment:
   🤖 nit: `this.config.getRecordMerger().getRecordType()` is repeated twice in the ternary — could you extract it to a local variable (e.g. `mergerRecordType`) before the conditional to make the intent clearer?
   
   <sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4163573632

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.45098%` with `111 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.10%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`285dd98`](https://app.codecov.io/gh/apache/hudi/commit/285dd985152f4496787f8bbabab89a56ef2d3ed3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (285dd98). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (285dd98) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   48.10%   -20.43%     
   + Complexity    27968    16370    -11598     
   =============================================
     Files          2440     1999      -441     
     Lines        134456   111376    -23080     
     Branches      16226    14081     -2145     
   =============================================
   - Hits          92138    53579    -38559     
   - Misses        35054    52182    +17128     
   + Partials       7264     5615     -1649     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <13.49%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.31% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <13.07%> (-15.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <24.83%> (-13.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4163816252

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940) 
   * 285dd985152f4496787f8bbabab89a56ef2d3ed3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4235441779

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * eba857992a815ed09272098e6846a67d32fe916d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4234907161

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `32.97872%` with `126 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.62%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 26.08% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (eba8579). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (eba8579) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.62%   -22.91%     
   + Complexity    27968    15321    -12647     
   =============================================
     Files          2440     1978      -462     
     Lines        134456   109668    -24788     
     Branches      16226    13706     -2520     
   =============================================
   - Hits          92138    50036    -42102     
   - Misses        35054    54339    +19285     
   + Partials       7264     5293     -1971     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <30.85%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `78.04% <100.00%> (-7.14%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <66.66%> (+4.23%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1584 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4164292703

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 285dd985152f4496787f8bbabab89a56ef2d3ed3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124922042

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.46377%` with `107 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.53%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.52% | [12 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0558b63). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0558b63) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   53.53%   -14.86%     
   + Complexity    27505    21227     -6278     
   =============================================
     Files          2428     2390       -38     
     Lines        132926   128468     -4458     
     Branches      16000    14929     -1071     
   =============================================
   - Hits          90902    68775    -22127     
   - Misses        34964    53908    +18944     
   + Partials       7060     5785     -1275     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <21.01%> (-12.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `77.77% <66.66%> (-11.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `76.89% <55.55%> (-15.78%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [877 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123505045

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `14.28571%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.10%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 44.44% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (00e727b). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (00e727b) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   54.10%   -14.28%     
   + Complexity    27505    12185    -15320     
   =============================================
     Files          2428     1425     -1003     
     Lines        132926    70112    -62814     
     Branches      16000     7816     -8184     
   =============================================
   - Hits          90902    37937    -52965     
   + Misses        34964    28806     -6158     
   + Partials       7060     3369     -3691     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <14.28%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `26.88% <44.44%> (-65.80%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1772 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123325426

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `10.98901%` with `81 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.09%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 22.22% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (00e727b). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (00e727b) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.09%   -23.29%     
   + Complexity    27505     8456    -19049     
   =============================================
     Files          2428     1196     -1232     
     Lines        132926    61406    -71520     
     Branches      16000     6561     -9439     
   =============================================
   - Hits          90902    27693    -63209     
   + Misses        34964    30699     -4265     
   + Partials       7060     3014     -4046     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `57.77% <66.66%> (-31.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `55.55% <40.00%> (-16.32%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `13.26% <22.22%> (-79.42%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [2027 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124045039

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.79412%` with `105 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.26%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (48b2d92). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (48b2d92) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   48.26%   -20.13%     
   + Complexity    27505    16336    -11169     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110675    -22251     
     Branches      16000    13921     -2079     
   =============================================
   - Hits          90902    53415    -37487     
   - Misses        34964    51722    +16758     
   + Partials       7060     5538     -1522     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <14.70%> (-16.07%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <20.58%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1490 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369040182

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.57%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 31 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|1|
   >|spark-java-tests|18|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   46.57%   -21.52%     
   + Complexity    28940    15229    -13711     
   =============================================
     Files          2519     1965      -554     
     Lines        140646   107161    -33485     
     Branches      17427    12994     -4433     
   =============================================
   - Hits          95757    49906    -45851     
   - Misses        37030    52049    +15019     
   + Partials       7859     5206     -2653     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.02% <40.55%> (-11.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `68.32% <90.90%> (-24.35%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1655 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369051836

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.73%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|4|
   >|spark-java-tests|18|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   45.73%   -22.36%     
   + Complexity    28940    15655    -13285     
   =============================================
     Files          2519     1999      -520     
     Lines        140646   111996    -28650     
     Branches      17427    14125     -3302     
   =============================================
   - Hits          95757    51219    -44538     
   - Misses        37030    55239    +18209     
   + Partials       7859     5538     -2321     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <40.55%> (-11.98%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `68.32% <90.90%> (-24.35%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1627 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4368849272

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 06ee8e3e93888db2b920af1c45534fc39ad65b69 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728) 
   * 2def3286cfa1c9467d6dd970e933e2f2925c36b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369159001

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.29%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   67.29%   -0.79%     
   + Complexity    28940    28658     -282     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   - Hits          95757    94746    -1011     
   - Misses        37030    38118    +1088     
   - Partials       7859     7918      +59     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <60.00%> (-3.61%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [137 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369165871

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.07%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.07%   -0.02%     
   - Complexity    28940    28973      +33     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   + Hits          95757    95835      +78     
   - Misses        37030    37074      +44     
   - Partials       7859     7873      +14     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <60.00%> (-0.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122856996

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.79661%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (5dc57e9). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (5dc57e9) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   48.16%   -20.23%     
   + Complexity    27505    16303    -11202     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110664    -22262     
     Branches      16000    13916     -2084     
   =============================================
   - Hits          90902    53296    -37606     
   - Misses        34964    51815    +16851     
   + Partials       7060     5553     -1507     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <8.47%> (-15.30%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <16.10%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `77.27% <100.00%> (-3.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.02% <66.66%> (-6.66%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122868321

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `18.64407%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.31%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (5dc57e9). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (5dc57e9) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   61.31%   -7.07%     
   + Complexity    27505    24715    -2790     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    81723    -9179     
   - Misses        34964    44682    +9718     
   + Partials       7060     6874     -186     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <8.47%> (-16.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <16.10%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `77.27% <100.00%> (-3.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.49% <66.66%> (-6.00%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `88.88% <66.66%> (-3.79%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [547 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123565637

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.79661%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.33%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (00e727b). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (00e727b) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.33%   -23.06%     
   + Complexity    27505    15396    -12109     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110664    -22262     
     Branches      16000    13918     -2082     
   =============================================
   - Hits          90902    50165    -40737     
   - Misses        34964    55159    +20195     
   + Partials       7060     5340     -1720     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <14.28%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <16.10%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <66.66%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1540 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123627220

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `18.64407%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.34%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (00e727b). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (00e727b) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   61.34%   -7.05%     
   + Complexity    27505    24725    -2780     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16040      +40     
   ============================================
   - Hits          90902    81754    -9148     
   - Misses        34964    44655    +9691     
   + Partials       7060     6870     -190     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <14.28%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <8.47%> (-16.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <16.10%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.49% <66.66%> (-6.00%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `88.88% <66.66%> (-3.79%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123676492

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `18.64407%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.89%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.89%   -2.50%     
   + Complexity    27505    26542     -963     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16040      +40     
   ============================================
   - Hits          90902    87823    -3079     
   - Misses        34964    38178    +3214     
   - Partials       7060     7278     +218     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <14.28%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <8.47%> (-16.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <16.94%> (-0.35%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <66.66%> (-4.73%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `86.36% <0.00%> (+5.41%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <66.66%> (-2.00%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [375 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4125016403

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `36.95652%` with `87 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.19%   -3.19%     
   + Complexity    27505    26460    -1045     
   ============================================
     Files          2428     2436       +8     
     Lines        132926   133340     +414     
     Branches      16000    16044      +44     
   ============================================
   - Hits          90902    86937    -3965     
   - Misses        34964    39375    +4411     
   + Partials       7060     7028      -32     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <31.15%> (-3.82%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <35.50%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <7.97%> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [318 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4131893356

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `13.49206%` with `109 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.08%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 7.40% | [24 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (def1b9c). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (def1b9c) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.08%   -23.30%     
   + Complexity    27570     8457    -19113     
   =============================================
     Files          2433     1196     -1237     
     Lines        133224    61448    -71776     
     Branches      16028     6570     -9458     
   =============================================
   - Hits          91103    27705    -63398     
   + Misses        35064    30724     -4340     
   + Partials       7057     3019     -4038     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `57.77% <66.66%> (-31.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `55.55% <40.00%> (-16.32%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `56.33% <41.17%> (-40.44%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `12.75% <7.40%> (-79.92%)` | :arrow_down: |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2026 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132030642

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.45098%` with `111 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.25%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (def1b9c). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (def1b9c) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   48.25%   -20.14%     
   + Complexity    27570    16338    -11232     
   =============================================
     Files          2433     1997      -436     
     Lines        133224   110720    -22504     
     Branches      16028    13929     -2099     
   =============================================
   - Hits          91103    53426    -37677     
   - Misses        35064    51752    +16688     
   + Partials       7057     5542     -1515     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.62% <13.07%> (-16.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <24.83%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1489 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132158137

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.05%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   66.05%   -2.33%     
   + Complexity    27570    22421    -5149     
   ============================================
     Files          2433     1997     -436     
     Lines        133224   110720   -22504     
     Branches      16028    13929    -2099     
   ============================================
   - Hits          91103    73137   -17966     
   + Misses        35064    31375    -3689     
   + Partials       7057     6208     -849     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <32.67%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.53% <37.25%> (+0.14%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <10.45%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [788 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132996817

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.50%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a012c2`](https://app.codecov.io/gh/apache/hudi/commit/4a012c2e3fc86b4edf77e95a566ea35647461acb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.50%   -0.88%     
   + Complexity    27570    27248     -322     
   ============================================
     Files          2433     2436       +3     
     Lines        133224   133378     +154     
     Branches      16028    16053      +25     
   ============================================
   - Hits          91103    90040    -1063     
   - Misses        35064    36202    +1138     
   - Partials       7057     7136      +79     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.30% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <32.67%> (-3.74%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.60% <37.25%> (+0.20%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <10.45%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393950400

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.24%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (fd85491). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (fd85491) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|6|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   58.24%   -9.85%     
   + Complexity    28940    24848    -4092     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   - Hits          95757    82002   -13755     
   - Misses        37030    51494   +14464     
   + Partials       7859     7304     -555     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <23.88%> (-17.00%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.55%> (-12.21%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.67% <90.90%> (-3.00%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [663 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.

hudi-agent commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3198725216


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -135,19 +139,59 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
       if (previousRecord == null) {
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
-        GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        GenericRecord originalAvro = mergedRecord.getOriginalAvroRecord();

Review Comment:
   🤖 nit: with the new originalAvro branch, `handleNonDeletes` is now ~50 lines and four levels deep (if → else → try → if/else). Could you extract the else branch into a helper like `rewriteAndReplaceFromPayload(mergedRecord, recordSchema)` that returns the boolean "emit/suppress" decision? That would let the top of the method read as a clean two-way switch on `originalAvro != null`.
   
   <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>



##########
hudi-common/src/main/java/org/apache/hudi/common/engine/ExtractedData.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.engine;
+
+import org.apache.avro.generic.GenericRecord;
+
+import javax.annotation.Nullable;
+
+/**
+ * Result of {@link RecordContext#extractDataFromRecord} carrying the engine-native row plus,
+ * when extraction went through an Avro payload (e.g. {@code ExpressionPayload} in SQL MERGE INTO),
+ * the original Avro record produced by {@code HoodieRecord#toIndexedRecord}.
+ *
+ * <p>The original Avro record is propagated to {@link org.apache.hudi.common.table.read.BufferedRecord}
+ * so downstream code (e.g. {@code UpdateProcessor}) can decode the payload bytes with the correct
+ * source schema instead of re-serializing the engine-native row through a possibly-mismatched schema.
+ */
+public final class ExtractedData<T> {
+
+  private final T data;
+  @Nullable
+  private final GenericRecord originalAvroRecord;
+
+  private ExtractedData(T data, @Nullable GenericRecord originalAvroRecord) {
+    this.data = data;
+    this.originalAvroRecord = originalAvroRecord;
+  }
+
+  public static <T> ExtractedData<T> of(T data) {
+    return new ExtractedData<>(data, null);
+  }
+
+  public static <T> ExtractedData<T> of(T data, @Nullable GenericRecord originalAvroRecord) {

Review Comment:
   🤖 nit: the two static factories `of(T)` and `of(T, GenericRecord)` differ only by the optional avro hint — could you drop the single-arg overload and just have callers pass `null` (or rename the two-arg one to `of(T, GenericRecord)` and keep the no-hint variant clearly named, e.g. `withoutAvroHint(T)`)? As written, picking between them at call sites is a small distraction since `of(x)` and `of(x, null)` produce identical objects.
   
   <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieReadHandle.java:
##########
@@ -68,14 +70,18 @@ protected HoodieBaseFile getLatestBaseFile() {
   }
 
   protected HoodieFileReader createNewFileReader() throws IOException {
-    return HoodieIOFactory.getIOFactory(hoodieTable.getStorage())
-        .getReaderFactory(this.config.getRecordMerger().getRecordType())
-        .getFileReader(config, getLatestBaseFile().getStoragePath());
+    return createNewFileReader(getLatestBaseFile());
   }
 
   protected HoodieFileReader createNewFileReader(HoodieBaseFile hoodieBaseFile) throws IOException {
+    String extension = hoodieBaseFile.getStoragePath().getFileExtension();
+    HoodieFileFormat format = HoodieFileFormat.fromFileExtensionOrNull(extension);
+    HoodieRecord.HoodieRecordType mergerRecordType = this.config.getRecordMerger().getRecordType();
+    HoodieRecord.HoodieRecordType recordType = format != null

Review Comment:
   🤖 nit: this same `extension → fromFileExtensionOrNull → resolveRecordType, fall back to merger type` snippet now appears here, in `HoodieIndexUtils.filterKeysFromFile`, and in `HoodieFileWriterFactory.getFileWriter`. Could you fold it into a static helper on `HoodieFileFormat` (e.g. `resolveRecordTypeForExtension(String, HoodieRecordType fallback)`)? The three call sites would become a one-liner and stay in lockstep.
   
   <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -327,7 +327,11 @@ public class HoodieWriteConfig extends HoodieConfig {
   public static final ConfigProperty<HoodieFileFormat> BASE_FILE_FORMAT = ConfigProperty
       .key("hoodie.base.file.format")
       .defaultValue(HoodieFileFormat.PARQUET)
-      .withValidValues(HoodieFileFormat.PARQUET.name(), HoodieFileFormat.ORC.name(), HoodieFileFormat.HFILE.name())
+      .withValidValues(
+          HoodieFileFormat.PARQUET.name(),
+          HoodieFileFormat.ORC.name(),
+          HoodieFileFormat.HFILE.name(),
+          HoodieFileFormat.LANCE.name())

Review Comment:
   _⚠️ Potential issue_ | _🟠 Major_
   
   **LANCE is now accepted here, but `getMaxFileSize()` still rejects it.**
   
   Lines 2369-2379 in this same class still only handle `PARQUET`, `ORC`, and `HFILE` before throwing. After advertising `HoodieFileFormat.LANCE` as a valid base format, any path that derives max file size from `config.getBaseFileFormat()` can now fail at runtime for Lance tables. Please either add a `LANCE` branch there or block `LANCE` until its sizing behavior is defined.
   
   <details>
   <summary>🤖 Prompt for AI Agents</summary>
   
   ```
   Verify each finding against the current code and only fix it if needed.
   
   In
   `@hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java`
   around lines 322 - 326, The config now advertises HoodieFileFormat.LANCE as a
   valid base format but getMaxFileSize (in class HoodieWriteConfig) still only
   handles PARQUET, ORC and HFILE and will throw for LANCE; update getMaxFileSize
   to either add a LANCE branch with the appropriate sizing policy (e.g., derive
   from config.getBaseFileFormat() or a new lance-specific config key) or
   explicitly reject/validate HoodieFileFormat.LANCE earlier so it cannot be used
   until sizing behavior is defined; locate the getMaxFileSize method and the
   usages of config.getBaseFileFormat() and implement the LANCE case or add a clear
   validation/error message preventing LANCE selection.
   ```
   
   </details>
   
   <!-- fingerprinting:phantom:medusa:grasshopper:eb97e8e1-02f7-4cb8-914d-86726e9106c5 -->
   
   <!-- This is an auto-generated comment by CodeRabbit -->
   
   — *CodeRabbit* ([original](https://github.com/hudi-agent/hudi/pull/3#discussion_r3108757025)) (source:comment#3108757025)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3198653909


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3756,6 +3761,43 @@ protected void setDefaults() {
       autoAdjustConfigsForConcurrencyMode(isLockProviderPropertySet);
     }
 
+    // Class name referenced by string so hudi-client-common does not depend on hudi-spark-client.
+    private static final String DEFAULT_SPARK_RECORD_MERGER_CLASS = "org.apache.hudi.DefaultSparkRecordMerger";

Review Comment:
   Verified at HoodieWriteConfig.java:3098 — `DEFAULT_SPARK_RECORD_MERGER_CLASS` sits at the top of the `Builder` class (line 3095) with the other field declarations. Pushed at 2def3286, please resolve when convenient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4394012040

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.06%   -0.02%     
   - Complexity    28940    28979      +39     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   + Hits          95757    95841      +84     
   - Misses        37030    37085      +55     
   - Partials       7859     7874      +15     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <60.00%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.66% <27.22%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429070299

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.26%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   66.26%   -1.83%     
   + Complexity    28940    28299     -641     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    93855    -1902     
   - Misses        37030    39855    +2825     
   - Partials       7859     7932      +73     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.58% <31.25%> (-9.07%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <40.34%> (-0.03%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.11% <100.00%> (-0.56%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.57% <100.00%> (-0.92%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `68.55% <ø> (-1.55%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [298 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429105039

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.94%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   67.94%   -0.15%     
   - Complexity    28940    29057     +117     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96236     +479     
   - Misses        37030    37479     +449     
   - Partials       7859     7927      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <60.22%> (-0.27%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [92 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3224862408


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -135,19 +139,59 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
       if (previousRecord == null) {
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
-        GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        GenericRecord originalAvro = mergedRecord.getOriginalAvroRecord();
+        Schema recordAvroSchema = recordSchema.toAvroSchema();
+
+        // When the merged record carries an originalAvroRecord (populated by extractDataFromRecord
+        // for ExpressionPayload in the COW write path via ExtractedData), the record is already in
+        // write-schema format with correctly evaluated expressions. Convert directly and skip the
+        // payload path.
+        //
+        // NOTE: this branch bypasses shouldIgnore. That is safe today because the only payload that
+        // populates originalAvroRecord is ExpressionPayload, which never returns shouldIgnore=true.
+        // If a future payload starts producing an originalAvroRecord, it must add a shouldIgnore
+        // check here.
+        if (originalAvro != null) {

Review Comment:
   Keeping the inline form — the three comment blocks document load-bearing contracts that read most clearly at the dispatch site; splitting into helpers would either move the `shouldIgnore`-bypass NOTE away from where a future originalAvroRecord-producing payload would be added, or fragment the contracts across methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4428998022

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.16%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (4bb5b0f). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (4bb5b0f) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   58.16%   -9.92%     
   + Complexity    28940    24883    -4057     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    82390   -13367     
   - Misses        37030    51956   +14926     
   + Partials       7859     7296     -563     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <25.00%> (-17.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <40.34%> (-11.93%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.96% <100.00%> (-2.71%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [713 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429012387

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13815",
       "triggerID" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13877",
       "triggerID" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "632207766a3333a7db222f08b53808a32d7e016e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13892",
       "triggerID" : "632207766a3333a7db222f08b53808a32d7e016e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13942",
       "triggerID" : "4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 632207766a3333a7db222f08b53808a32d7e016e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13892) 
   * 4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13942) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429262786

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.06%   -0.02%     
   - Complexity    28940    29131     +191     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96414     +657     
   - Misses        37030    37291     +261     
   - Partials       7859     7937      +78     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.02% <60.22%> (+0.38%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `94.62% <100.00%> (+1.94%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [68 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345646757

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.68715%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.05%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.07%   68.05%   -0.02%     
   - Complexity    28913    28928      +15     
   ============================================
     Files          2518     2520       +2     
     Lines        140572   140708     +136     
     Branches      17422    17442      +20     
   ============================================
   + Hits          95695    95762      +67     
   - Misses        37026    37077      +51     
   - Partials       7851     7869      +18     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <36.31%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <60.33%> (-0.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <40.78%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <27.37%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345745554

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.68715%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.07%   68.06%   -0.02%     
   - Complexity    28913    28932      +19     
   ============================================
     Files          2518     2520       +2     
     Lines        140572   140708     +136     
     Branches      17422    17442      +20     
   ============================================
   + Hits          95695    95772      +77     
   - Misses        37026    37070      +44     
   - Partials       7851     7866      +15     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <36.31%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <60.33%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <40.78%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <27.37%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345743244

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 06ee8e3e93888db2b920af1c45534fc39ad65b69 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345266339

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `40.54054%` with `88 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.93%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 47.61% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 36.36% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 33.33% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (426cbb8) and HEAD (06ee8e3). Click for more details.
   > 
   > <details><summary>HEAD has 33 uploads less than BASE</summary>
   >
   >| Flag | BASE (426cbb8) | HEAD (06ee8e3) |
   >|------|------|------|
   >|spark-scala-tests|12|0|
   >|spark-java-tests|18|0|
   >|spark-client-hadoop-common|1|0|
   >|utilities|1|0|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.07%   44.93%   -23.15%     
   + Complexity    28913     8541    -20372     
   =============================================
     Files          2518     1203     -1315     
     Lines        140572    62763    -77809     
     Branches      17422     6793    -10629     
   =============================================
   - Hits          95695    28201    -67494     
   + Misses        37026    31446     -5580     
   + Partials       7851     3116     -4735     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `58.09% <100.00%> (-31.40%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `58.62% <100.00%> (-27.35%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `47.36% <100.00%> (-42.11%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `65.21% <100.00%> (-25.70%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <ø> (-11.86%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <0.00%> (-41.56%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `60.41% <85.71%> (-25.30%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <66.66%> (-13.06%)` | :arrow_down: |
   | ... and [9 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2102 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345535257

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `43.57542%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.62%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (426cbb8) and HEAD (06ee8e3). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (426cbb8) | HEAD (06ee8e3) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|4|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.07%   60.62%   -7.45%     
   + Complexity    28913    25769    -3144     
   ============================================
     Files          2518     2520       +2     
     Lines        140572   140708     +136     
     Branches      17422    17442      +20     
   ============================================
   - Hits          95695    85306   -10389     
   - Misses        37026    47940   +10914     
   + Partials       7851     7462     -389     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <36.31%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.98% <24.02%> (-16.67%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.78%> (-12.15%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <27.37%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.67% <90.90%> (-4.83%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [548 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345542523

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `50.27933%` with `89 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 62.82%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (426cbb8) and HEAD (06ee8e3). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (426cbb8) | HEAD (06ee8e3) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.07%   62.82%   -5.26%     
   + Complexity    28913    26646    -2267     
   ============================================
     Files          2518     2520       +2     
     Lines        140572   140708     +136     
     Branches      17422    17442      +20     
   ============================================
   - Hits          95695    88398    -7297     
   - Misses        37026    44839    +7813     
   + Partials       7851     7471     -380     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <36.31%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.40% <45.81%> (-6.25%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.78%> (-12.15%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <27.37%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.47% <100.00%> (-0.44%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.30% <100.00%> (-2.19%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `97.36% <100.00%> (-2.64%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `57.64% <100.00%> (-12.95%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [408 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402917087

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.45%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.45%   -2.63%     
   + Complexity    28940    23542    -5398     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    76778   -18979     
   + Misses        37030    33559    -3471     
   + Partials       7859     6964     -895     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <60.22%> (+0.05%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <40.34%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.03% <100.00%> (-1.64%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [839 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402825218

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.80%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (6322077). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (6322077) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   47.80%   -20.28%     
   + Complexity    28940    17129    -11811     
   =============================================
     Files          2519     2051      -468     
     Lines        140646   117296    -23350     
     Branches      17427    15246     -2181     
   =============================================
   - Hits          95757    56078    -39679     
   - Misses        37030    55022    +17992     
   + Partials       7859     6196     -1663     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <25.00%> (-15.92%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <40.34%> (-12.04%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.09% <100.00%> (-5.58%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1553 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402835877

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13815",
       "triggerID" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13877",
       "triggerID" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "632207766a3333a7db222f08b53808a32d7e016e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13892",
       "triggerID" : "632207766a3333a7db222f08b53808a32d7e016e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * fd85491409dc0f33b0d8586a2a229266017ef403 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13877) 
   * 632207766a3333a7db222f08b53808a32d7e016e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13892) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402659248

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13728",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13815",
       "triggerID" : "2def3286cfa1c9467d6dd970e933e2f2925c36b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13877",
       "triggerID" : "fd85491409dc0f33b0d8586a2a229266017ef403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "632207766a3333a7db222f08b53808a32d7e016e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "632207766a3333a7db222f08b53808a32d7e016e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * fd85491409dc0f33b0d8586a2a229266017ef403 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13877) 
   * 632207766a3333a7db222f08b53808a32d7e016e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345490836

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `43.57542%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.66%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (426cbb8) and HEAD (06ee8e3). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (426cbb8) | HEAD (06ee8e3) |
   >|------|------|------|
   >|spark-scala-tests|12|4|
   >|spark-java-tests|18|1|
   >|utilities|1|0|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.07%   47.66%   -20.42%     
   + Complexity    28913    16622    -12291     
   =============================================
     Files          2518     2028      -490     
     Lines        140572   114603    -25969     
     Branches      17422    14688     -2734     
   =============================================
   - Hits          95695    54623    -41072     
   - Misses        37026    54122    +17096     
   + Partials       7851     5858     -1993     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <24.02%> (-15.66%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <40.78%> (-11.89%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-7.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1565 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4334561820

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.83%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 47 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.83%   -0.04%     
   - Complexity    28272    28362      +90     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   + Hits          93389    93624     +235     
   - Misses        34815    34972     +157     
   - Partials       7390     7414      +24     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <51.76%> (+0.02%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.70% <46.90%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4428983064

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.51%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 18 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (4bb5b0f). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (4bb5b0f) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|3|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   47.51%   -20.57%     
   + Complexity    28940    16967    -11973     
   =============================================
     Files          2519     2051      -468     
     Lines        140646   117302    -23344     
     Branches      17427    15255     -2172     
   =============================================
   - Hits          95757    55741    -40016     
   - Misses        37030    55483    +18453     
   + Partials       7859     6078     -1781     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.29% <25.00%> (-16.35%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <40.34%> (-11.93%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.09% <100.00%> (-5.58%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429017707

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.55%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (4bb5b0f). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (4bb5b0f) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|6|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   60.55%   -7.53%     
   + Complexity    28940    25846    -3094     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    85771    -9986     
   - Misses        37030    48423   +11393     
   + Partials       7859     7448     -411     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <25.00%> (-17.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <40.34%> (-11.93%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.96% <100.00%> (-2.71%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [597 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429159372

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.06%   -0.02%     
   - Complexity    28940    29131     +191     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96412     +655     
   - Misses        37030    37293     +263     
   - Partials       7859     7937      +78     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.96% <60.22%> (+0.31%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `94.62% <100.00%> (+1.94%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [70 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3224854019


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -251,8 +251,13 @@ public static Collection<Pair<String, Long>> filterKeysFromFile(StoragePath file
       return Collections.emptyList();
     }
     log.info("Going to filter {} keys from file {}", candidateRecordKeys.size(), filePath);
+    // TODO: The AVRO fallback here ignores the merger's configured type. This pre-dates
+    //  the Lance PR and is tracked at https://github.com/apache/hudi/issues/18496 — respect the
+    //  merger's record type for all formats.
+    HoodieRecord.HoodieRecordType recordType = HoodieFileFormat.resolveRecordTypeForExtension(
+        FSUtils.getFileExtension(filePath.toString()), HoodieRecord.HoodieRecordType.AVRO);

Review Comment:
   Done in 4bb5b0f2d2a8.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429078829

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.30%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   66.30%   -1.78%     
   + Complexity    28940    28330     -610     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    93920    -1837     
   - Misses        37030    39777    +2747     
   - Partials       7859     7945      +86     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.58% <31.25%> (-9.07%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <40.34%> (+0.05%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.11% <100.00%> (-0.56%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.57% <100.00%> (-0.92%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `68.55% <ø> (-1.55%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [294 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429099918

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.91%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   67.91%   -0.18%     
   - Complexity    28940    29045     +105     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96193     +436     
   - Misses        37030    37535     +505     
   - Partials       7859     7914      +55     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <60.22%> (-0.47%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [100 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429134528

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.06%   -0.02%     
   - Complexity    28940    29130     +190     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96409     +652     
   - Misses        37030    37294     +264     
   - Partials       7859     7939      +80     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.92% <60.22%> (+0.27%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `94.62% <100.00%> (+1.94%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [71 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429106835

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.01%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.01%   -0.07%     
   - Complexity    28940    29108     +168     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96342     +585     
   - Misses        37030    37372     +342     
   - Partials       7859     7928      +69     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <60.22%> (+0.02%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [80 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369083135

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.64%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   60.64%   -7.44%     
   + Complexity    28940    25805    -3135     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   - Hits          95757    85384   -10373     
   - Misses        37030    47941   +10911     
   + Partials       7859     7457     -402     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.59% <23.88%> (-17.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.55%> (-12.21%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.67% <90.90%> (-3.00%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [548 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369064485

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.98%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   47.98%   -20.10%     
   + Complexity    28940    16788    -12152     
   =============================================
     Files          2519     2029      -490     
     Lines        140646   114672    -25974     
     Branches      17427    14690     -2737     
   =============================================
   - Hits          95757    55025    -40732     
   - Misses        37030    53691    +16661     
   + Partials       7859     5956     -1903     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <23.88%> (-15.54%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <40.55%> (-12.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-5.85%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402978847

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.49%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.49%   -2.59%     
   + Complexity    28940    23554    -5386     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    76831   -18926     
   + Misses        37030    33495    -3535     
   + Partials       7859     6975     -884     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.99% <60.22%> (+0.35%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <40.34%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [829 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402827716

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.81%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (6322077). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (6322077) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   47.81%   -20.28%     
   + Complexity    28940    17129    -11811     
   =============================================
     Files          2519     2051      -468     
     Lines        140646   117301    -23345     
     Branches      17427    15252     -2175     
   =============================================
   - Hits          95757    56084    -39673     
   - Misses        37030    55024    +17994     
   + Partials       7859     6193     -1666     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <25.00%> (-15.92%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <40.34%> (-12.04%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.09% <100.00%> (-5.58%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402878882

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 59.81%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (6322077). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (6322077) |
   >|------|------|------|
   >|spark-scala-tests|12|8|
   >|spark-java-tests|18|6|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   59.81%   -8.28%     
   + Complexity    28940    21231    -7709     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    70160   -25597     
   - Misses        37030    39923    +2893     
   + Partials       7859     7218     -641     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <25.00%> (-17.08%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.34%> (-0.17%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.96% <100.00%> (-2.71%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.22% <100.00%> (-11.69%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `75.55% <100.00%> (-13.94%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `62.37% <ø> (-7.74%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1252 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402902999

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `51.70455%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.05%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   64.05%   -4.03%     
   + Complexity    28940    23005    -5935     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    75139   -20618     
   + Misses        37030    35176    -1854     
   + Partials       7859     6986     -873     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <48.86%> (-4.22%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <40.34%> (+0.05%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <100.00%> (-2.00%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `81.90% <100.00%> (-7.59%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [974 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402923302

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.48%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.48%   -2.60%     
   + Complexity    28940    23554    -5386     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    76820   -18937     
   + Misses        37030    33505    -3525     
   + Partials       7859     6976     -883     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.90% <60.22%> (+0.25%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <40.34%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.03% <100.00%> (-1.64%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [832 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402911227

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.22%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   64.22%   -3.86%     
   + Complexity    28940    23084    -5856     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    75336   -20421     
   + Misses        37030    34957    -2073     
   + Partials       7859     7008     -851     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <60.22%> (-3.82%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <40.34%> (+0.05%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <100.00%> (-2.00%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `81.90% <100.00%> (-7.59%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [961 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4403002091

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.49%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 9 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.49%   -2.59%     
   + Complexity    28940    23554    -5386     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    76831   -18926     
   + Misses        37030    33495    -3535     
   + Partials       7859     6975     -884     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.02% <60.22%> (+0.38%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <40.34%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [829 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393838493

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `40.26846%` with `89 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.93%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 47.61% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 36.36% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 28.57% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (fd85491). Click for more details.
   > 
   > <details><summary>HEAD has 33 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (fd85491) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|12|0|
   >|spark-java-tests|18|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   44.93%   -23.16%     
   + Complexity    28940     8545    -20395     
   =============================================
     Files          2519     1203     -1316     
     Lines        140646    62791    -77855     
     Branches      17427     6798    -10629     
   =============================================
   - Hits          95757    28212    -67545     
   + Misses        37030    31464     -5566     
   + Partials       7859     3115     -4744     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `58.09% <100.00%> (-31.40%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `58.62% <100.00%> (-27.35%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `47.36% <100.00%> (-42.11%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `65.21% <100.00%> (-25.70%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <ø> (-11.86%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <0.00%> (-41.56%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `60.41% <85.71%> (-25.30%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <66.66%> (-13.06%)` | :arrow_down: |
   | ... and [9 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2103 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4394012791

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.06%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.06%   -0.02%     
   - Complexity    28940    28979      +39     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   + Hits          95757    95841      +84     
   - Misses        37030    37085      +55     
   - Partials       7859     7874      +15     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <60.00%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.66% <27.22%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4187006561

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.43902%` with `119 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.81%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a032f3c`](https://app.codecov.io/gh/apache/hudi/commit/a032f3c9e7c93dc725260a909e188e2645dcb98d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (a032f3c). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (a032f3c) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.81%   -21.72%     
   + Complexity    27968    14973    -12995     
   =============================================
     Files          2440     1938      -502     
     Lines        134456   104246    -30210     
     Branches      16226    12528     -3698     
   =============================================
   - Hits          92138    48804    -43334     
   - Misses        35054    50426    +15372     
   + Partials       7264     5016     -2248     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <15.32%> (-0.13%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <12.02%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <25.60%> (-12.46%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `76.92% <80.00%> (-4.03%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.57% <75.00%> (-3.31%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.08% <63.15%> (-18.70%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1611 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3104858796


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -21,25 +21,73 @@ package org.apache.hudi
 
 import org.apache.avro.generic.{GenericRecord, IndexedRecord}
 import org.apache.hudi.common.engine.RecordContext
+import org.apache.hudi.common.model.HoodieRecord
 import org.apache.hudi.common.schema.HoodieSchema
 import org.apache.hudi.common.table.HoodieTableConfig
+import org.apache.hudi.exception.HoodieException
 import org.apache.spark.sql.HoodieInternalRowUtils
 import org.apache.spark.sql.avro.{HoodieAvroDeserializer, HoodieAvroSerializer}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.hudi.SparkAdapter
 
+import java.io.IOException
+import java.util.Properties
 import scala.collection.mutable
 
 trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContext {
 
   lazy val sparkAdapter: SparkAdapter = SparkAdapterSupport.sparkAdapter
   private val deserializerMap: mutable.Map[HoodieSchema, HoodieAvroDeserializer] = mutable.Map()
   private val serializerMap: mutable.Map[HoodieSchema, HoodieAvroSerializer] = mutable.Map()
+  // Maps InternalRow instances (by identity) to their original Avro records when the Avro record's

Review Comment:
   Good catch on the `seal()`-before-`convertToAvroRecord` scenario — that exact failure mode is no longer reachable on this PR because the `IdentityHashMap<InternalRow, GenericRecord>` cache was removed in `492082881e55`'s parent commit `a1ac98ed0d87` ("ExtractedData<T> + schema-aware constructHoodieRecord"). The original Avro record is now propagated explicitly through `ExtractedData` and stored on the `BufferedRecord` itself, so identity equality on `InternalRow` is no longer load-bearing — `seal()` / `replaceRecord()` / `project()` cannot silently break the link.
   
   Added the round-trip unit test you suggested in `492082881e55`: `TestSparkFileFormatInternalRecordContext` covers (1) propagation of `originalAvroRecord` when the payload schema differs from the requested read schema (the ExpressionPayload-like case), (2) `originalAvroRecord` left null when schemas match, (3) `extractDataFromRecord` → `convertToAvroRecord` round-trip preserving field values, and (4) the null-payload edge case. PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3108326844


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieReadHandle.java:
##########
@@ -68,14 +70,17 @@ protected HoodieBaseFile getLatestBaseFile() {
   }
 
   protected HoodieFileReader createNewFileReader() throws IOException {
-    return HoodieIOFactory.getIOFactory(hoodieTable.getStorage())
-        .getReaderFactory(this.config.getRecordMerger().getRecordType())
-        .getFileReader(config, getLatestBaseFile().getStoragePath());
+    return createNewFileReader(getLatestBaseFile());
   }
 
   protected HoodieFileReader createNewFileReader(HoodieBaseFile hoodieBaseFile) throws IOException {
+    String extension = hoodieBaseFile.getStoragePath().getFileExtension();

Review Comment:
   Done in aa562f8015eb.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278136776

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `38.49558%` with `139 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.89%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (aa562f8). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (aa562f8) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|18|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   58.89%   -9.99%     
   + Complexity    28272    24265    -4007     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    80099   -13290     
   - Misses        34815    49045   +14230     
   + Partials       7390     6866     -524     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <23.00%> (-16.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <35.84%> (-12.90%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [649 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273329295

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.18182%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.42%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   66.42%   -2.45%     
   + Complexity    28272    22953    -5319     
   ============================================
     Files          2464     2012     -452     
     Lines        135594   112745   -22849     
     Branches      16447    14331    -2116     
   ============================================
   - Hits          93389    74893   -18496     
   + Misses        34815    31317    -3498     
   + Partials       7390     6535     -855     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <50.45%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.69% <45.45%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [805 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273626123

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.18182%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.85%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.85%   -0.02%     
   - Complexity    28272    28305      +33     
   ============================================
     Files          2464     2468       +4     
     Lines        135594   135769     +175     
     Branches      16447    16473      +26     
   ============================================
   + Hits          93389    93484      +95     
   - Misses        34815    34884      +69     
   - Partials       7390     7401      +11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <26.81%> (-0.03%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <50.45%> (+0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.69% <45.45%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4125012472

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `36.95652%` with `87 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.19%   -3.19%     
   + Complexity    27505    26459    -1046     
   ============================================
     Files          2428     2436       +8     
     Lines        132926   133340     +414     
     Branches      16000    16044      +44     
   ============================================
   - Hits          90902    86936    -3966     
   - Misses        34964    39376    +4412     
   + Partials       7060     7028      -32     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <31.15%> (-3.82%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <35.50%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <7.97%> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [318 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117278733

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `11.71171%` with `98 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.80%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 36.36% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   53.80%   -14.59%     
   + Complexity    27505    12110    -15395     
   =============================================
     Files          2428     1425     -1003     
     Lines        132926    70055    -62871     
     Branches      16000     7809     -8191     
   =============================================
   - Hits          90902    37690    -53212     
   + Misses        34964    28999     -5965     
   + Partials       7060     3366     -3694     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `26.88% <36.36%> (-65.80%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1778 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122860579

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.79661%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.76%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (5dc57e9). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (5dc57e9) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   58.76%   -9.62%     
   + Complexity    27505    23748    -3757     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    78325   -12577     
   - Misses        34964    48231   +13267     
   + Partials       7060     6723     -337     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.00% <8.47%> (-15.69%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <16.10%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `77.27% <100.00%> (-3.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.22% <66.66%> (-7.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `88.88% <66.66%> (-3.79%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [665 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117350128

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.43%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   47.43%   -20.95%     
   + Complexity    27505    15981    -11524     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110607    -22319     
     Branches      16000    13911     -2089     
   =============================================
   - Hits          90902    52471    -38431     
   - Misses        34964    52776    +17812     
   + Partials       7060     5360     -1700     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.34% <9.40%> (-15.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <17.09%> (-13.76%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.02% <72.72%> (-6.66%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1506 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4125463385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 0558b632a959e4d2a44e3de84586d0e294c07654 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124099965

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.44%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.44%   -0.95%     
   + Complexity    27505    27215     -290     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    89895    -1007     
   - Misses        34964    36267    +1303     
   - Partials       7060     7128      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <30.14%> (-3.76%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <22.05%> (-0.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `76.36% <0.00%> (-9.64%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [174 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124108329

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.52%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.52%   -0.86%     
   + Complexity    27505    27252     -253     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    90005     -897     
   - Misses        34964    36157    +1193     
   - Partials       7060     7128      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <30.14%> (-3.65%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <22.05%> (-0.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [154 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123709894

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5dc57e946c09abbfece1b469bf74e81e4c5fd7e9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814) 
   * 00e727be1f7b384f7540434cae54e42cc899c001 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818) 
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124024482

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.05882%` with `106 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.39%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (48b2d92). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (48b2d92) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   46.39%   -22.00%     
   + Complexity    27505    15044    -12461     
   =============================================
     Files          2428     1951      -477     
     Lines        132926   105782    -27144     
     Branches      16000    12873     -3127     
   =============================================
   - Hits          90902    49075    -41827     
   - Misses        34964    51659    +16695     
   + Partials       7060     5048     -2012     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <20.58%> (-12.28%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1571 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124893101

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `13.63636%` with `114 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.10%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 14.81% | [21 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0558b63). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0558b63) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   54.10%   -14.28%     
   + Complexity    27505    12187    -15318     
   =============================================
     Files          2428     1425     -1003     
     Lines        132926    70130    -62796     
     Branches      16000     7820     -8180     
   =============================================
   - Hits          90902    37945    -52957     
   + Misses        34964    28817     -6147     
   + Partials       7060     3368     -3692     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `76.19% <100.00%> (-20.59%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1771 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.

yihua commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3126594503


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +403,45 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Use the schema-aware constructHoodieRecord overload so existingRecordContext
+    // can register the schema locally and resolve it for SPARK records.
+    HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+    HoodieRecord<R> result = mergedSchema != null
+        ? existingRecordContext.constructHoodieRecord(mergeResult, partitionPath, mergedSchema)
+        : existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
     HoodieRecord<R> withMeta = result.prependMetaFields(writeSchema, writeSchemaWithMetaFields,
         new MetadataValues().setRecordKey(incoming.getRecordKey()).setPartitionPath(partitionPath), properties);
     return Option.of(withMeta.wrapIntoHoodieRecordPayloadWithParams(writeSchemaWithMetaFields, properties, Option.empty(),
         config.allowOperationMetadataField(), Option.empty(), false, Option.of(writeSchema)));
   }
 
   private static <R> String inferPartitionPath(HoodieRecord<R> incoming, HoodieRecord<R> existing, HoodieSchema recordSchema, BaseKeyGenerator keyGenerator,
-                                               RecordContext<R> recordContext, BufferedRecord<R> resultingBufferedRecord) {
-    R record = resultingBufferedRecord.getRecord();
-    if (record == incoming.getData()) {
+                                               RecordContext<R> existingRecordContext, BufferedRecord<R> resultingBufferedRecord,
+                                               BufferedRecord<R> incomingBufferedRecord, BufferedRecord<R> existingBufferedRecord,
+                                               RecordContext<R> incomingRecordContext) {
+    // Compare by BufferedRecord identity first: for payload-based records (e.g. ExpressionPayload),
+    // incoming.getData() is the payload object, not the InternalRow extracted from it, so data-identity
+    // checks would incorrectly fall through to the schema-based conversion path.
+    if (resultingBufferedRecord == incomingBufferedRecord || resultingBufferedRecord.getRecord() == incoming.getData()) {
       return incoming.getPartitionPath();
-    } else if (record == existing.getData()) {
+    } else if (resultingBufferedRecord == existingBufferedRecord || resultingBufferedRecord.getRecord() == existing.getData()) {
       return existing.getPartitionPath();
     } else {
-      // the merged record is not the same as either incoming or existing, so we need to compute the partition path
-      return keyGenerator.getPartitionPath(recordContext.convertToAvroRecord(record, recordSchema));
+      // The merged record is genuinely new (e.g. created by HoodieAvroRecordMerger.merge).
+      // Its InternalRow was produced and its schemaId was encoded by incomingRecordContext,
+      // so use incomingRecordContext with the record's actual schema (which may be the data schema,
+      // without meta fields) rather than existingRecordContext with writeSchemaWithMetaFields.
+      HoodieSchema actualSchema = incomingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);
+      if (actualSchema == null) {
+        actualSchema = existingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);
+      }
+      if (actualSchema == null) {
+        actualSchema = recordSchema;
+      }
+      return keyGenerator.getPartitionPath(incomingRecordContext.convertToAvroRecord(resultingBufferedRecord, actualSchema));

Review Comment:
   Could we avoid this change in the PR? This logic is on the critical path and we need perf benchmarking as well.  Changes here are high-risk; if this is for supporting partition path update, we should separate it out into an independent PR.



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3736,6 +3741,36 @@ protected void setDefaults() {
       autoAdjustConfigsForConcurrencyMode(isLockProviderPropertySet);
     }
 
+    // Class name referenced by string so hudi-client-common does not depend on hudi-spark-client.
+    private static final String DEFAULT_SPARK_RECORD_MERGER_CLASS = "org.apache.hudi.DefaultSparkRecordMerger";
+
+    /**
+     * When the table's base file format requires SPARK record type (e.g. Lance) but the user
+     * has not configured a Spark-compatible record merger, inject
+     * {@link #DEFAULT_SPARK_RECORD_MERGER_CLASS} into {@link HoodieWriteConfig#RECORD_MERGE_IMPL_CLASSES}
+     * so every downstream consumer — write handles, file readers, and metadata writers — observes
+     * a SPARK-typed merger consistently. This removes the usability gap where users had to set
+     * the merger override manually for every Lance table.
+     */
+    private void autoSelectSparkRecordMergerForBaseFileFormat() {
+      HoodieFileFormat tableLevel = HoodieFileFormat.getValue(writeConfig.getString(HoodieTableConfig.BASE_FILE_FORMAT.key()));
+      HoodieFileFormat format = tableLevel != null ? tableLevel : writeConfig.getBaseFileFormat();
+      if (format == null || !format.requiresSparkRecordType()) {
+        return;
+      }
+      if (engineType != EngineType.SPARK) {
+        throw new HoodieNotSupportedException(format + " base file format requires the SPARK engine");
+      }
+      // Only inject when the user has not explicitly configured any merger class. A user who
+      // knowingly picks a non-Spark merger for a Spark-only format will still fail fast at
+      // write time — that's a deliberate choice, not a usability gap.
+      String currentMergers = writeConfig.getString(RECORD_MERGE_IMPL_CLASSES);
+      if (!StringUtils.isNullOrEmpty(currentMergers)) {
+        return;
+      }
+      writeConfig.setValue(RECORD_MERGE_IMPL_CLASSES, DEFAULT_SPARK_RECORD_MERGER_CLASS);

Review Comment:
   Since Hudi 1.0 release, the record merge implementation class should only be set in CUSTOM merge mode.  Default merge modes of `COMMIT_TIME` and `EVENT_TIME` do not require this config and setting it interfere with the merge operation to generate unintended merge behavior. @wombatu-kun Could you double check? Why is this needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188658854

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * a032f3c9e7c93dc725260a909e188e2645dcb98d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070) 
   * ebbf353f9f3785b17ded961be299271837bcb6c1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188709774

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `30.90909%` with `114 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.88%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (ebbf353). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (ebbf353) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   58.88%   -9.65%     
   + Complexity    27968    24017    -3951     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   - Hits          92138    79247   -12891     
   - Misses        35054    48554   +13500     
   + Partials       7264     6789     -475     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <15.15%> (-16.37%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.62% <27.87%> (-13.03%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `74.07% <66.66%> (-6.88%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `90.41% <63.15%> (-6.37%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [678 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188701734

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `30.30303%` with `115 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.74%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (ebbf353). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (ebbf353) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.74%   -22.78%     
   + Complexity    27968    15298    -12670     
   =============================================
     Files          2440     1972      -468     
     Lines        134456   109078    -25378     
     Branches      16226    13575     -2651     
   =============================================
   - Hits          92138    49901    -42237     
   - Misses        35054    53911    +18857     
   + Partials       7264     5266     -1998     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <27.87%> (-12.90%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `74.07% <66.66%> (-6.88%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.08% <63.15%> (-18.70%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188724444

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `41.21212%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.74%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   67.74%   -0.78%     
   + Complexity    27968    27668     -300     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   - Hits          92138    91183     -955     
   - Misses        35054    36074    +1020     
   - Partials       7264     7333      +69     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <34.54%> (-3.84%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.70% <38.78%> (+0.05%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.30% <12.12%> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <100.00%> (+4.23%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `69.62% <100.00%> (ø)` | |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [206 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.

yihua commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3036286607


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSqlStatement.scala:
##########
@@ -37,15 +39,23 @@ class TestSqlStatement extends HoodieSparkSqlTestBase {
   val STATE_FINISH_ALL = 12
 
   test("Test Sql Statements") {
-    Seq("cow", "mor").foreach { tableType =>
-      withTempDir { tmp =>
-        val params = Map(
-          "tableType" -> tableType,
-          "tmpDir" -> {
-            tmp.getCanonicalPath.replace('\\', '/')
-          }
-        )
-        execSqlFile("/sql-statements.sql", params)
+    val baseFileFormats = if (HoodieSparkUtils.gteqSpark3_4) Seq("parquet", "lance") else Seq("parquet")
+    baseFileFormats.foreach { baseFileFormat =>
+      Seq("cow", "mor").foreach { tableType =>
+        withTempDir { tmp =>
+          val params = Map(
+            "tableType" -> tableType,
+            "baseFileFormat" -> baseFileFormat,
+            "recordMergerImpl" -> (
+              if (baseFileFormat.equals("parquet")) "" else {
+                s"hoodie.write.record.merge.custom.implementation.classes = '${classOf[DefaultSparkRecordMerger].getName}',"

Review Comment:
   🤖 nit: same as above — `baseFileFormat == "parquet"` is idiomatic Scala; `.equals("parquet")` looks like Java style slipping in here.



##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala:
##########
@@ -216,11 +241,19 @@ class TestSparkSqlCoreFlow extends HoodieSparkSqlTestBase {
       tableType
     }
 
+    val recordMergerImpl = if (baseFileFormat.equals("lance")) {

Review Comment:
   🤖 nit: in Scala, `==` is the idiomatic way to compare strings — `baseFileFormat == "lance"` reads more naturally than `.equals("lance")`.



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());

Review Comment:
   🤖 nit: this chain is pretty long for one line — it might be worth breaking it into a local variable for the IO factory or reader factory to make it easier to scan.



##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSqlStatement.scala:
##########
@@ -37,15 +39,23 @@ class TestSqlStatement extends HoodieSparkSqlTestBase {
   val STATE_FINISH_ALL = 12
 
   test("Test Sql Statements") {
-    Seq("cow", "mor").foreach { tableType =>
-      withTempDir { tmp =>
-        val params = Map(
-          "tableType" -> tableType,
-          "tmpDir" -> {
-            tmp.getCanonicalPath.replace('\\', '/')
-          }
-        )
-        execSqlFile("/sql-statements.sql", params)
+    val baseFileFormats = if (HoodieSparkUtils.gteqSpark3_4) Seq("parquet", "lance") else Seq("parquet")
+    baseFileFormats.foreach { baseFileFormat =>
+      Seq("cow", "mor").foreach { tableType =>
+        withTempDir { tmp =>
+          val params = Map(
+            "tableType" -> tableType,
+            "baseFileFormat" -> baseFileFormat,
+            "recordMergerImpl" -> (

Review Comment:
   🤖 nit: the multi-line `if/else` expression for `recordMergerImpl` embedded inline inside the `Map(...)` literal is a bit hard to parse at a glance — could you assign it to a `val` before the `Map`, similar to how `TestSparkSqlCoreFlow` handles it?



##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java:
##########
@@ -49,7 +49,10 @@ public static <T, I, K, O> HoodieFileWriter getFileWriter(
       String instantTime, StoragePath path, HoodieStorage storage, HoodieConfig config, HoodieSchema schema,
       TaskContextSupplier taskContextSupplier, HoodieRecordType recordType) throws IOException {
     final String extension = FSUtils.getFileExtension(path.getName());
-    HoodieFileWriterFactory factory = HoodieIOFactory.getIOFactory(storage).getWriterFactory(recordType);
+    HoodieFileFormat format = HoodieFileFormat.fromFileExtensionOrNull(extension);
+    HoodieRecordType fixedType = (format != null && format.requiresSparkRecordType())

Review Comment:
   🤖 nit: `fixedType` doesn't communicate much intent — something like `effectiveRecordType` or `resolvedRecordType` would make it clearer that this is the format-aware override of the caller-supplied type.



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +399,51 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Re-encode into existingRecordContext so constructHoodieRecord (which uses
+    // existingRecordContext for the correct payload class) can resolve the schema for SPARK records.
+    BufferedRecord<R> mergeResultForConstruct = mergeResult;
+    if (mergeResult != incomingBufferedRecord && mergeResult != existingBufferedRecord) {
+      HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+      if (mergedSchema != null && existingRecordContext.getSchemaFromBufferRecord(mergeResult) == null) {
+        mergeResultForConstruct = BufferedRecords.fromEngineRecord(
+            mergeResult.getRecord(), mergeResult.getRecordKey(), mergedSchema,
+            existingRecordContext, Arrays.asList(orderingFieldNames), mergeResult.getHoodieOperation());
+      }
+    }
+    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResultForConstruct, partitionPath);
     HoodieRecord<R> withMeta = result.prependMetaFields(writeSchema, writeSchemaWithMetaFields,
         new MetadataValues().setRecordKey(incoming.getRecordKey()).setPartitionPath(partitionPath), properties);
     return Option.of(withMeta.wrapIntoHoodieRecordPayloadWithParams(writeSchemaWithMetaFields, properties, Option.empty(),
         config.allowOperationMetadataField(), Option.empty(), false, Option.of(writeSchema)));
   }

Review Comment:
   🤖 nit: `inferPartitionPath` has grown to 9 parameters — might be worth considering a small value object or passing the incoming/existing `BufferedRecord` pair as a context struct to reduce the signature length.



##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala:
##########
@@ -47,24 +48,47 @@ class TestSparkSqlCoreFlow extends HoodieSparkSqlTestBase {
   val colsToCompare = "timestamp, _row_key, partition_path, rider, driver, begin_lat, begin_lon, end_lat, end_lon, fare.amount, fare.currency, _hoodie_is_deleted"
 
   //params for core flow tests
-  val params: List[String] = List(
-    "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM",
-    "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM",
-    "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE",
-    "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE",
-    "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM",
-    "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM",
-    "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE",
-    "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE",
-    "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM",
-    "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM",
-    "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE",
-    "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE",
-    "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM",
-    "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM",
-    "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE",
-    "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE"
-  )
+  val params: List[String] = {
+    val allParams: List[String] = List(
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|parquet",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|parquet",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|parquet",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|parquet",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|parquet",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|parquet",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|parquet",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|parquet",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|parquet",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|parquet",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|parquet",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|parquet",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|parquet",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|parquet",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|parquet",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|parquet",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|lance",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|lance",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|lance",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|lance",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|lance",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|lance",
+      "COPY_ON_WRITE|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|lance",
+      "COPY_ON_WRITE|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|lance",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|lance",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_BLOOM|lance",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|lance",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.SimpleKeyGenerator|GLOBAL_SIMPLE|lance",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|lance",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|BLOOM|lance",
+      "MERGE_ON_READ|false|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|lance",
+      "MERGE_ON_READ|true|org.apache.hudi.keygen.NonpartitionedKeyGenerator|SIMPLE|lance"

Review Comment:
   🤖 nit: the `if (HoodieSparkUtils.gteqSpark3_4) allParams else allParams.filterNot(_.endsWith("|lance"))` pattern is copy-pasted verbatim for `paramsForImmutable` too — could you pull it into a small helper like `def withLanceIfSupported(ps: List[String]): List[String]` to keep the two call sites DRY?



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieLanceRealtimeInputFormat.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop.realtime;
+
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.hadoop.HoodieLanceInputFormat;
+import org.apache.hudi.hadoop.UseFileSplitsFromInputFormat;
+import org.apache.hudi.hadoop.UseRecordReaderFromInputFormat;
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeInputFormatUtils;
+
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.serde2.ColumnProjectionUtils;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * HoodieRealtimeInputFormat for HUDI datasets which store data in Lance base file format.
+ */
+@UseRecordReaderFromInputFormat
+@UseFileSplitsFromInputFormat
+public class HoodieLanceRealtimeInputFormat extends HoodieMergeOnReadTableInputFormat {
+
+  private static final Logger LOG = LoggerFactory.getLogger(HoodieLanceRealtimeInputFormat.class);
+
+  // NOTE: We're only using {@code HoodieLanceInputFormat} to compose {@code RecordReader}
+  private final HoodieLanceInputFormat lanceInputFormat = new HoodieLanceInputFormat();
+
+  @Override
+  public RecordReader<NullWritable, ArrayWritable> getRecordReader(final InputSplit split, final JobConf jobConf,
+      final Reporter reporter) throws IOException {
+    // Hive on Spark invokes multiple getRecordReaders from different threads in the same spark task (and hence the
+    // same JVM) unlike Hive on MR. Due to this, accesses to JobConf, which is shared across all threads, is at the
+    // risk of experiencing race conditions. Hence, we synchronize on the JobConf object here. There is negligible
+    // latency incurred here due to the synchronization since get record reader is called once per spilt before the
+    // actual heavy lifting of reading the parquet files happen.
+    if (jobConf.get(HoodieInputFormatUtils.HOODIE_READ_COLUMNS_PROP) == null) {

Review Comment:
   🤖 nit: the comment says "reading the parquet files" — looks like a copy-paste artifact from the Parquet realtime format; probably should say "Lance files" (or just "the files").



##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -70,6 +70,14 @@ public String getFileExtension() {
     return extension;
   }
 
+  /**
+   * Returns true if this file format requires the SPARK record type for reading/writing.
+   * Lance only supports the Spark-native InternalRow representation, not Avro.
+   */
+  public boolean requiresSparkRecordType() {

Review Comment:
   🤖 nit: the `requiresSparkRecordType() ? SPARK : <fallback>` ternary is copy-pasted at least five times across this PR (HoodieIndexUtils ×3, HoodieReadHandle, HoodieTable, HoodieFileWriterFactory) — have you considered adding a helper like `resolveRecordType(HoodieRecordType fallback)` directly on `HoodieFileFormat` to avoid the repetition?



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    // TODO Auto-generated method stub
+    return 0;

Review Comment:
   🤖 nit: `// TODO Auto-generated method stub` looks like a leftover IDE placeholder — could you either remove it or replace it with a note explaining why `getPos()` always returns 0 for Lance?



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceInputFormat.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils;
+
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
+
+import java.io.IOException;
+
+/**
+ * HoodieInputFormat for HUDI datasets which store data in Lance base file format.
+ */
+@UseFileSplitsFromInputFormat
+public class HoodieLanceInputFormat extends HoodieCopyOnWriteTableInputFormat {
+
+  protected HoodieTimeline filterInstantsTimeline(HoodieTimeline timeline) {
+    return HoodieInputFormatUtils.filterInstantsTimeline(timeline);

Review Comment:
   🤖 nit: `filterInstantsTimeline` looks like it's overriding a parent method — could you add `@Override` here so the compiler can catch any future signature drift?



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieReadHandle.java:
##########
@@ -68,14 +70,16 @@ protected HoodieBaseFile getLatestBaseFile() {
   }
 
   protected HoodieFileReader createNewFileReader() throws IOException {
-    return HoodieIOFactory.getIOFactory(hoodieTable.getStorage())
-        .getReaderFactory(this.config.getRecordMerger().getRecordType())
-        .getFileReader(config, getLatestBaseFile().getStoragePath());
+    return createNewFileReader(getLatestBaseFile());
   }
 

Review Comment:
   🤖 nit: `ext` is a bit terse — the rest of the codebase (e.g. `HoodieFileWriterFactory`) consistently uses `extension` for the same concept, could you align here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035475848


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    // TODO Auto-generated method stub
+    return 0;
+  }
+
+  @Override
+  public void close() throws IOException {
+    if (reader != null) {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035481798


##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java:
##########
@@ -49,7 +49,13 @@ public static <T, I, K, O> HoodieFileWriter getFileWriter(
       String instantTime, StoragePath path, HoodieStorage storage, HoodieConfig config, HoodieSchema schema,
       TaskContextSupplier taskContextSupplier, HoodieRecordType recordType) throws IOException {
     final String extension = FSUtils.getFileExtension(path.getName());
-    HoodieFileWriterFactory factory = HoodieIOFactory.getIOFactory(storage).getWriterFactory(recordType);
+    HoodieRecordType fixedType;
+    try {
+      fixedType = HoodieFileFormat.fromFileExtension(extension).requiresSparkRecordType() ? HoodieRecordType.SPARK : recordType;

Review Comment:
   Good point. Added `HoodieFileFormat.fromFileExtensionOrNull()` and refactored the caller. No more exception-based control flow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035478274


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java:
##########
@@ -157,6 +175,7 @@ public static String getOutputFormatClassName(HoodieFileFormat baseFileFormat) {
     switch (baseFileFormat) {
       case PARQUET:
       case HFILE:
+      case LANCE:

Review Comment:
   Intentional — these methods are only invoked during Hive metastore sync to register format/SerDe metadata. Actual writes use Spark-native Lance writers. Added explanatory comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188731624

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `41.21212%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.71%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.71%   +0.18%     
   - Complexity    27968    28080     +112     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   + Hits          92138    92481     +343     
   + Misses        35054    34810     -244     
   - Partials       7264     7299      +35     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <34.54%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.85% <38.78%> (+0.20%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.30% <12.12%> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <100.00%> (+4.23%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `69.62% <100.00%> (ø)` | |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [66 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188744136

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `41.21212%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.71%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.71%   +0.18%     
   - Complexity    27968    28080     +112     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   + Hits          92138    92483     +345     
   + Misses        35054    34808     -246     
   - Partials       7264     7299      +35     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <34.54%> (-0.06%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.85% <38.78%> (+0.20%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.30% <12.12%> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <100.00%> (+4.23%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `69.62% <100.00%> (ø)` | |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [65 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3036740978


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    // TODO Auto-generated method stub
+    return 0;

Review Comment:
   removed



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3036740155


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceInputFormat.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils;
+
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
+
+import java.io.IOException;
+
+/**
+ * HoodieInputFormat for HUDI datasets which store data in Lance base file format.
+ */
+@UseFileSplitsFromInputFormat
+public class HoodieLanceInputFormat extends HoodieCopyOnWriteTableInputFormat {
+
+  protected HoodieTimeline filterInstantsTimeline(HoodieTimeline timeline) {
+    return HoodieInputFormatUtils.filterInstantsTimeline(timeline);

Review Comment:
   `filterInstantsTimeline` is not defined in the parent class — adding `@Override` causes a compilation error. The same pattern exists in `HoodieHFileInputFormat` without `@Override`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4131850422

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 0558b632a959e4d2a44e3de84586d0e294c07654 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829) 
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * def1b9c7715891f128d287fb91a27dc20558bca6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132928161

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `28.10458%` with `110 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.35%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a012c2`](https://app.codecov.io/gh/apache/hudi/commit/4a012c2e3fc86b4edf77e95a566ea35647461acb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (4a012c2). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (4a012c2) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   61.35%   -7.04%     
   + Complexity    27570    24729    -2841     
   ============================================
     Files          2433     2436       +3     
     Lines        133224   133364     +140     
     Branches      16028    16051      +23     
   ============================================
   - Hits          91103    81820    -9283     
   - Misses        35064    44663    +9599     
   + Partials       7057     6881     -176     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.30% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <13.07%> (-16.15%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <24.83%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <10.45%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.49% <66.66%> (-6.00%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.24% <59.25%> (-5.44%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [525 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132812346

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `15.64626%` with `124 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.09%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a012c2`](https://app.codecov.io/gh/apache/hudi/commit/4a012c2e3fc86b4edf77e95a566ea35647461acb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 14.81% | [21 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (4a012c2). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (4a012c2) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   54.09%   -14.29%     
   + Complexity    27570    12184    -15386     
   =============================================
     Files          2433     1425     -1008     
     Lines        133224    70154    -63070     
     Branches      16028     7825     -8203     
   =============================================
   - Hits          91103    37949    -53154     
   + Misses        35064    28831     -6233     
   + Partials       7057     3374     -3683     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `70.42% <41.17%> (-26.36%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1771 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3069732092


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -70,6 +70,22 @@ public String getFileExtension() {
     return extension;
   }
 
+  /**
+   * Returns true if this file format requires the SPARK record type for reading/writing.
+   * Lance only supports the Spark-native InternalRow representation, not Avro.
+   */
+  public boolean requiresSparkRecordType() {
+    return this == LANCE;
+  }
+
+  /**

Review Comment:
   **[High]** `resolveRecordType()` fixes the I/O layer (reader/writer factory selection), but every test still must manually set `hoodie.write.record.merge.custom.implementation.classes=DefaultSparkRecordMerger` because the **merger** is selected at config init time before file format is known.
   
   This creates a usability gap — users who set `baseFileFormat=LANCE` but forget the merger property will hit a confusing runtime error. Could the merger selection logic (`HoodieRecordUtils.createRecordMerger`) also consult the table's base file format and auto-select a Spark merger when Lance is configured? That would make `resolveRecordType` a complete solution rather than a partial one.



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/lance/SparkLanceReaderBase.scala:
##########
@@ -76,8 +76,21 @@ class SparkLanceReaderBase(enableVectorizedReader: Boolean) extends SparkColumna
     val filePath = file.filePath.toString
 
     if (requiredSchema.isEmpty && partitionSchema.isEmpty) {
-      // No columns requested - return empty iterator
-      Iterator.empty
+      // No column data needed (e.g. count() on a non-partitioned table). Open the Lance file to
+      // get the actual row count and return that many empty rows, so Spark computes the correct count.
+      val countAllocator = HoodieArrowAllocator.newChildAllocator(
+        getClass.getSimpleName + "-count-" + file.filePath, HoodieSparkLanceReader.LANCE_DATA_ALLOCATOR_SIZE)
+      try {
+        val lanceReader = LanceFileReader.open(file.filePath.toString, countAllocator)
+        try {
+          val rowCount = Math.toIntExact(lanceReader.numRows())
+          Iterator.fill(rowCount)(InternalRow.empty)

Review Comment:
   **[Medium]** `Math.toIntExact(lanceReader.numRows())` will throw `ArithmeticException` if the file exceeds ~2.1B rows. While unlikely for a single file, this is a silent contract — consider using `Long` and `Iterator` that doesn't require materializing an `Int` count, or add a guard with a clear error message.
   
   Also, this opens and closes a full `LanceFileReader` per file just to get the row count for `count(*)`. If Lance exposes row count from file metadata/footer without opening the full reader, that would be more efficient for large tables with many small files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4235161641

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `49.46809%` with `95 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.81%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 73.91% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.81%   +0.29%     
   - Complexity    27968    28192     +224     
   ============================================
     Files          2440     2462      +22     
     Lines        134456   135248     +792     
     Branches      16226    16401     +175     
   ============================================
   + Hits          92138    93076     +938     
   + Misses        35054    34797     -257     
   - Partials       7264     7375     +111     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.49% <20.74%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.90% <43.61%> (+0.13%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.74% <42.02%> (+0.09%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <17.55%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `85.36% <100.00%> (+0.18%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `69.62% <100.00%> (ø)` | |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `89.93% <90.90%> (+0.01%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <83.33%> (+11.64%)` | :arrow_up: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `90.00% <90.90%> (+4.00%)` | :arrow_up: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [142 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250086955

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.01604%` with `129 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.78%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 13.04% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 47.61% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 50.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 81.81% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   44.78%   -23.74%     
   + Complexity    27968     8486    -19482     
   =============================================
     Files          2440     1200     -1240     
     Lines        134456    62132    -72324     
     Branches      16226     6690     -9536     
   =============================================
   - Hits          92138    27828    -64310     
   + Misses        35054    31275     -3779     
   + Partials       7264     3029     -4235     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `58.09% <100.00%> (-31.40%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `58.62% <100.00%> (-27.35%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `47.36% <100.00%> (-42.11%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `65.21% <100.00%> (-25.70%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <0.00%> (-41.56%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `60.41% <85.71%> (-25.30%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <66.66%> (-13.06%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2035 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250251109

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.43662%` with `129 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.73%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 65.21% | [3 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 27.27% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.73%   -22.79%     
   + Complexity    27968    15395    -12573     
   =============================================
     Files          2440     1991      -449     
     Lines        134456   110004    -24452     
     Branches      16226    13764     -2462     
   =============================================
   - Hits          92138    50312    -41826     
   - Misses        35054    54374    +19320     
   + Partials       7264     5318     -1946     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <37.08%> (-12.82%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1575 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250250164

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.43662%` with `129 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.22%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 65.21% | [3 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 27.27% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.22%   -22.31%     
   + Complexity    27968    15179    -12789     
   =============================================
     Files          2440     1962      -478     
     Lines        134456   107401    -27055     
     Branches      16226    13210     -3016     
   =============================================
   - Hits          92138    49643    -42495     
   - Misses        35054    52603    +17549     
   + Partials       7264     5155     -2109     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <37.08%> (-12.68%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1590 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250576379

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251654261

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `38.91403%` with `135 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.68%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 64.00% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (68c3a7c). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (68c3a7c) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.68%   -21.84%     
   + Complexity    27968    15016    -12952     
   =============================================
     Files          2440     1944      -496     
     Lines        134456   104899    -29557     
     Branches      16226    12645     -3581     
   =============================================
   - Hits          92138    48976    -43162     
   - Misses        35054    50885    +15831     
   + Partials       7264     5038     -2226     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <36.65%> (-12.55%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `73.68% <85.71%> (-1.32%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251704930

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `47.51131%` with `116 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.52%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (68c3a7c). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (68c3a7c) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   61.52%   -7.00%     
   + Complexity    27968    20409    -7559     
   ============================================
     Files          2440     1991     -449     
     Lines        134456   110012   -24444     
     Branches      16226    13767    -2459     
   ============================================
   - Hits          92138    67689   -24449     
   - Misses        35054    35711     +657     
   + Partials       7264     6612     -652     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <23.98%> (-15.99%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.27% <45.24%> (+0.62%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.22% <100.00%> (-11.69%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `75.55% <100.00%> (-13.94%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `54.43% <100.00%> (-15.19%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1248 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159084965

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `28.10458%` with `110 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.21%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   61.21%   -7.05%     
   + Complexity    27761    24876    -2885     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   - Hits          91715    82326    -9389     
   - Misses        35543    45240    +9697     
   + Partials       7097     6913     -184     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.46% <13.07%> (-16.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <24.83%> (-12.64%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.49% <66.66%> (-6.00%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.24% <59.25%> (-5.44%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [527 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159093711

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.91%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   65.91%   -2.35%     
   + Complexity    27761    26767     -994     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   - Hits          91715    88648    -3067     
   - Misses        35543    38486    +2943     
   - Partials       7097     7345     +248     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.46% <13.07%> (-16.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <37.25%> (-0.08%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `56.52% <100.00%> (-10.15%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [351 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159070347

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.45098%` with `111 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.18%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   48.18%   -20.09%     
   + Complexity    27761    16383    -11378     
   =============================================
     Files          2439     1998      -441     
     Lines        134355   111276    -23079     
     Branches      16210    14063     -2147     
   =============================================
   - Hits          91715    53616    -38099     
   - Misses        35543    52053    +16510     
   + Partials       7097     5607     -1490     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.46% <13.07%> (-16.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <24.83%> (-12.64%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1498 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159047279

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `15.64626%` with `124 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.88%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 14.81% | [21 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   53.88%   -14.39%     
   + Complexity    27761    12195    -15566     
   =============================================
     Files          2439     1426     -1013     
     Lines        134355    70620    -63735     
     Branches      16210     7941     -8269     
   =============================================
   - Hits          91715    38052    -53663     
   + Misses        35543    29156     -6387     
   + Partials       7097     3412     -3685     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `70.42% <41.17%> (-26.36%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1779 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159157672

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.23%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   68.23%   -0.04%     
   - Complexity    27761    27772      +11     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   + Hits          91715    91757      +42     
   - Misses        35543    35611      +68     
   - Partials       7097     7111      +14     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.73% <32.67%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <37.25%> (+0.22%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3084648606


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -21,25 +21,93 @@ package org.apache.hudi
 
 import org.apache.avro.generic.{GenericRecord, IndexedRecord}
 import org.apache.hudi.common.engine.RecordContext
+import org.apache.hudi.common.model.HoodieRecord
 import org.apache.hudi.common.schema.HoodieSchema
 import org.apache.hudi.common.table.HoodieTableConfig
+import org.apache.hudi.exception.HoodieException
 import org.apache.spark.sql.HoodieInternalRowUtils
 import org.apache.spark.sql.avro.{HoodieAvroDeserializer, HoodieAvroSerializer}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.hudi.SparkAdapter
 
+import java.io.IOException
+import java.util.Properties
 import scala.collection.mutable
 
 trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContext {
 
   lazy val sparkAdapter: SparkAdapter = SparkAdapterSupport.sparkAdapter
   private val deserializerMap: mutable.Map[HoodieSchema, HoodieAvroDeserializer] = mutable.Map()
   private val serializerMap: mutable.Map[HoodieSchema, HoodieAvroSerializer] = mutable.Map()
+  // Maps InternalRow instances (by identity) to their original Avro records when the Avro record's
+  // schema differs from the BufferedRecord schema. This handles ExpressionPayload records whose
+  // getInsertValue result carries the data schema (no meta fields) while the BufferedRecord
+  // stores writeSchemaWithMetaFields. Returning the original Avro record from convertToAvroRecord
+  // lets ExpressionPayload.combineAndGetUpdateValue decode bytes with the correct data schema.
+  //
+  // IMPORTANT INVARIANT: The identity link between InternalRow and GenericRecord must survive
+  // from extractDataFromRecord (where the cache is populated) to convertToAvroRecord (where
+  // it is consumed via remove()). Any operation that replaces the InternalRow object in between
+  // — such as BufferedRecord.seal() (which calls InternalRow.copy()), replaceRecord(), or
+  // project() — would break this link and cause fallback to schema-based serialization.
+  //
+  // Current safety: In the MOR read path (UpdateProcessor.handleNonDeletes), convertToAvroRecord
+  // is called on the original InternalRow BEFORE seal() runs in super.handleNonDeletes().
+  // In the COW write path (HoodieIndexUtils.inferPartitionPath), convertToAvroRecord is similarly
+  // called before any record transformation.
+  // LIFECYCLE: Entries are added in extractDataFromRecord and removed in convertToAvroRecord.
+  // If a record is cached but never reaches convertToAvroRecord (e.g., SENTINEL records that
+  // are filtered out), the entry leaks. This is bounded because: (1) SENTINEL records are rare,
+  // and (2) this instance is scoped to a single FileGroup read and is GC'd afterwards.
+  private val avroRecordByRow: java.util.IdentityHashMap[InternalRow, GenericRecord] =

Review Comment:
   Adopted your suggestion in 0964e8ad34e4. `extractDataFromRecord` now returns `ExtractedData<T>` (data + optional original Avro record); the IdentityHashMap cache, the `lastAvroFromCache` flag, and the entire 20-line safety-comment block are gone. `UpdateProcessor` (and the Avro mergers via a new `convertToAvroRecord(BufferedRecord, schema)` overload) read the original Avro record directly off `BufferedRecord.getOriginalAvroRecord()` — no identity dependency, no flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3084671910


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +401,51 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Re-encode into existingRecordContext so constructHoodieRecord (which uses
+    // existingRecordContext for the correct payload class) can resolve the schema for SPARK records.
+    BufferedRecord<R> mergeResultForConstruct = mergeResult;
+    if (mergeResult != incomingBufferedRecord && mergeResult != existingBufferedRecord) {
+      HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+      if (mergedSchema != null && existingRecordContext.getSchemaFromBufferRecord(mergeResult) == null) {
+        mergeResultForConstruct = BufferedRecords.fromEngineRecord(
+            mergeResult.getRecord(), mergeResult.getRecordKey(), mergedSchema,
+            existingRecordContext, Arrays.asList(orderingFieldNames), mergeResult.getHoodieOperation());
+      }
+    }
+    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResultForConstruct, partitionPath);
     HoodieRecord<R> withMeta = result.prependMetaFields(writeSchema, writeSchemaWithMetaFields,
         new MetadataValues().setRecordKey(incoming.getRecordKey()).setPartitionPath(partitionPath), properties);
     return Option.of(withMeta.wrapIntoHoodieRecordPayloadWithParams(writeSchemaWithMetaFields, properties, Option.empty(),
         config.allowOperationMetadataField(), Option.empty(), false, Option.of(writeSchema)));
   }
 
   private static <R> String inferPartitionPath(HoodieRecord<R> incoming, HoodieRecord<R> existing, HoodieSchema recordSchema, BaseKeyGenerator keyGenerator,
-                                               RecordContext<R> recordContext, BufferedRecord<R> resultingBufferedRecord) {
-    R record = resultingBufferedRecord.getRecord();
-    if (record == incoming.getData()) {
+                                               RecordContext<R> existingRecordContext, BufferedRecord<R> resultingBufferedRecord,
+                                               BufferedRecord<R> incomingBufferedRecord, BufferedRecord<R> existingBufferedRecord,
+                                               RecordContext<R> incomingRecordContext) {
+    // Compare by BufferedRecord identity first: for payload-based records (e.g. ExpressionPayload),
+    // incoming.getData() is the payload object, not the InternalRow extracted from it, so data-identity
+    // checks would incorrectly fall through to the schema-based conversion path.
+    if (resultingBufferedRecord == incomingBufferedRecord || resultingBufferedRecord.getRecord() == incoming.getData()) {
       return incoming.getPartitionPath();
-    } else if (record == existing.getData()) {
+    } else if (resultingBufferedRecord == existingBufferedRecord || resultingBufferedRecord.getRecord() == existing.getData()) {
       return existing.getPartitionPath();
     } else {
-      // the merged record is not the same as either incoming or existing, so we need to compute the partition path
-      return keyGenerator.getPartitionPath(recordContext.convertToAvroRecord(record, recordSchema));
+      // The merged record is genuinely new (e.g. created by HoodieAvroRecordMerger.merge).
+      // Its InternalRow was produced and its schemaId was encoded by incomingRecordContext,
+      // so use incomingRecordContext with the record's actual schema (which may be the data schema,
+      // without meta fields) rather than existingRecordContext with writeSchemaWithMetaFields.
+      HoodieSchema actualSchema = incomingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);
+      if (actualSchema == null) {
+        actualSchema = existingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);

Review Comment:
   The final `recordSchema` (writeSchemaWithMetaFields) fallback is the legacy behavior for merger-produced records that predates this PR. Both contexts returning null would only happen if a custom merger produced a `BufferedRecord` whose `schemaId` wasn't registered in either context — none of the built-in mergers (`HoodieAvroRecordMerger`, `HoodiePreCombineAvroRecordMerger`, `HoodieSparkRecordMerger`) do that. Kept it as the safe default rather than failing hard; happy to tighten to an exception if you'd prefer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251972946

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.82%   +0.29%     
   - Complexity    27968    28231     +263     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   + Hits          92138    93172    +1034     
   + Misses        35054    34823     -231     
   - Partials       7264     7386     +122     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <46.15%> (+0.10%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <45.24%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250253320

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.43662%` with `129 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.19%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 65.21% | [3 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 27.27% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (0964e8a). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (0964e8a) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.19%   -23.33%     
   + Complexity    27968    15556    -12412     
   =============================================
     Files          2440     2008      -432     
     Lines        134456   112349    -22107     
     Branches      16226    14265     -1961     
   =============================================
   - Hits          92138    50779    -41359     
   - Misses        35054    56110    +21056     
   + Partials       7264     5460     -1804     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.56% <37.08%> (-13.09%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `62.06% <100.00%> (-23.90%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4344966420

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379",
       "triggerID" : "aa562f8015ebdf4972ca2db62de73691d7ccce1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "06ee8e3e93888db2b920af1c45534fc39ad65b69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * aa562f8015ebdf4972ca2db62de73691d7ccce1c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13379) 
   * 06ee8e3e93888db2b920af1c45534fc39ad65b69 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4341050729

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.83%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 48 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.83%   -0.04%     
   - Complexity    28272    28362      +90     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   + Hits          93389    93624     +235     
   - Misses        34815    34972     +157     
   - Partials       7390     7414      +24     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <51.76%> (+0.02%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.70% <46.90%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4345511269

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `43.57542%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.31%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06ee8e3`](https://app.codecov.io/gh/apache/hudi/commit/06ee8e3e93888db2b920af1c45534fc39ad65b69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (426cbb8) and HEAD (06ee8e3). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (426cbb8) | HEAD (06ee8e3) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|3|
   >|utilities|1|0|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.07%   47.31%   -20.76%     
   + Complexity    28913    16868    -12045     
   =============================================
     Files          2518     2049      -469     
     Lines        140572   117087    -23485     
     Branches      17422    15225     -2197     
   =============================================
   - Hits          95695    55402    -40293     
   - Misses        37026    55661    +18635     
   + Partials       7851     6024     -1827     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.54%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <32.33%> (-0.02%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.39% <24.02%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <40.78%> (-12.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-7.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4290163692

   @yihua to take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3108339331


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -135,19 +139,59 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
       if (previousRecord == null) {
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
-        GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        GenericRecord originalAvro = mergedRecord.getOriginalAvroRecord();
+        Schema recordAvroSchema = recordSchema.toAvroSchema();
+
+        // When the merged record carries an originalAvroRecord (populated by extractDataFromRecord
+        // for ExpressionPayload in the COW write path via ExtractedData), the record is already in
+        // write-schema format with correctly evaluated expressions. Convert directly and skip the
+        // payload path.
+        //
+        // NOTE: this branch bypasses shouldIgnore. That is safe today because the only payload that
+        // populates originalAvroRecord is ExpressionPayload, which never returns shouldIgnore=true.
+        // If a future payload starts producing an originalAvroRecord, it must add a shouldIgnore
+        // check here.
+        if (originalAvro != null) {
+          // After replaceRecord(), mergedRecord.getSchemaId() still references the original schema.
+          // This is safe because the record is emitted immediately via super.handleNonDeletes() below,
+          // which calls seal() and produces the output row — the record is not spilled to disk
+          // (via toBinary()) between replaceRecord and emit in this single-record path. If this
+          // assumption changes, the schemaId must be updated after replaceRecord.
+          mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(originalAvro));
+        } else {
+          GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
+          HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
+          try {
+            if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
+              return null;
+            }
+            // Evaluate the payload to get the insert value
+            Option<IndexedRecord> insertValueOpt = hoodieRecord.getData().getInsertValue(recordAvroSchema, properties);
+            if (insertValueOpt.isPresent()) {
+              IndexedRecord insertRecord = insertValueOpt.get();
+              HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
+              GenericRecord finalRecord;
+              if (insertRecord.getSchema().equals(recordAvroSchema)) {
+                // Payload preserved the schema (e.g., OverwriteWithLatestAvroPayload).
+                // Rewrite to full reader schema including meta fields.
+                finalRecord = HoodieAvroUtils.rewriteRecordWithNewSchema(insertRecord, readerSchema.toAvroSchema());
+              } else {
+                // Payload transformed the schema (e.g., ExpressionPayload maps source→target fields).
+                // The result has different field names than recordSchema. Use data-only schema as
+                // the rewrite target to maintain arity consistency with BufferedRecord's schemaId,
+                // which is immutable and corresponds to the data-only recordSchema.
+                HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(readerSchema);
+                finalRecord = HoodieAvroUtils.rewriteRecordWithNewSchema(insertRecord, dataSchema.toAvroSchema());
+              }
+              mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(finalRecord));
+            } else {
+              // Payload returned empty (e.g., soft-deleted record in DefaultHoodieRecordPayload).
+              // Suppress the record — do not emit it as an insert.
+              return null;
+            }
+          } catch (IOException e) {
+            throw new HoodieIOException("Error processing record with payload class: " + payloadClass, e);

Review Comment:
   The invariant is already documented inline at 155-159: `replaceRecord(...)` is followed immediately by `super.handleNonDeletes()` → `seal()` → emit, with no `toBinary()` in between, so the stale `schemaId` is never consulted. The comment also calls out precisely what must change if the assumption breaks (update `schemaId` after `replaceRecord`, or build a new `BufferedRecord`). Refactoring `schemaId` to mutable or rebuilding the record is a larger change that affects every `BufferedRecord` caller — out of scope for this PR. Happy to open a follow-up issue to track.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278206853

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `49.11504%` with `115 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.40%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   66.40%   -2.47%     
   + Complexity    28272    27323     -949     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    90321    -3068     
   - Misses        34815    38112    +3297     
   - Partials       7390     7577     +187     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <23.00%> (-16.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <46.90%> (+0.10%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [325 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278230346

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.82%   -0.05%     
   - Complexity    28272    28361      +89     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   + Hits          93389    93614     +225     
   - Misses        34815    34981     +166     
   - Partials       7390     7415      +25     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <51.76%> (-0.08%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.70% <46.90%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273304098

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `47.72727%` with `115 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.83%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (4920828). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (4920828) |
   >|------|------|------|
   >|spark-scala-tests|10|6|
   >|spark-java-tests|18|5|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   60.83%   -8.05%     
   + Complexity    28272    20719    -7553     
   ============================================
     Files          2464     2012     -452     
     Lines        135594   112745   -22849     
     Branches      16447    14331    -2116     
   ============================================
   - Hits          93389    68584   -24805     
   - Misses        34815    37350    +2535     
   + Partials       7390     6811     -579     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <21.36%> (-16.58%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <45.45%> (-0.29%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.22% <100.00%> (-11.69%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `75.55% <100.00%> (-13.94%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1221 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273293022

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `36.81818%` with `139 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.00%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 33.33% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (4920828). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (4920828) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|18|3|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.87%   48.00%   -20.87%     
   + Complexity    28272    16517    -11755     
   =============================================
     Files          2464     2012      -452     
     Lines        135594   112745    -22849     
     Branches      16447    14331     -2116     
   =============================================
   - Hits          93389    54124    -39265     
   - Misses        34815    52940    +18125     
   + Partials       7390     5681     -1709     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <21.36%> (-16.19%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <34.09%> (-12.91%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `73.68% <85.71%> (-1.32%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1515 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278132923

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `38.49558%` with `139 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.86%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (3d0ab80) and HEAD (aa562f8). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d0ab80) | HEAD (aa562f8) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|18|3|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.87%   58.86%   -10.02%     
   + Complexity    28272    24251     -4021     
   =============================================
     Files          2464     2470        +6     
     Lines        135594   136010      +416     
     Branches      16447    16506       +59     
   =============================================
   - Hits          93389    80058    -13331     
   - Misses        34815    49083    +14268     
   + Partials       7390     6869      -521     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <23.00%> (-16.19%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <35.84%> (-12.90%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `87.50% <87.50%> (ø)` | |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [650 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122820574

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `14.28571%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.90%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 44.44% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (5dc57e9). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (5dc57e9) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   53.90%   -14.48%     
   + Complexity    27505    12143    -15362     
   =============================================
     Files          2428     1425     -1003     
     Lines        132926    70112    -62814     
     Branches      16000     7816     -8184     
   =============================================
   - Hits          90902    37796    -53106     
   + Misses        34964    28948     -6016     
   + Partials       7060     3368     -3692     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `77.27% <100.00%> (-3.68%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `59.68% <66.66%> (-29.81%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `26.88% <44.44%> (-65.80%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `21.62% <11.76%> (-68.38%)` | :arrow_down: |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1779 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123784912

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5dc57e946c09abbfece1b469bf74e81e4c5fd7e9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814) 
   * 00e727be1f7b384f7540434cae54e42cc899c001 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818) 
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 48b2d926bd07a6c8ac879da74d24118d46b91540 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124160175

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.32%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.32%   -0.06%     
   - Complexity    27505    27566      +61     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   + Hits          90902    91073     +171     
   - Misses        34964    35147     +183     
   - Partials       7060     7070      +10     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <30.14%> (+<0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <22.05%> (-0.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.00% <59.25%> (-2.68%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132614967

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * def1b9c7715891f128d287fb91a27dc20558bca6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854) 
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 4a012c2e3fc86b4edf77e95a566ea35647461acb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122745643

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0435c7f6d049444a4661a24aa9160fb23714af94 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800) 
   * 5dc57e946c09abbfece1b469bf74e81e4c5fd7e9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124963416

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `24.63768%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 59.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0558b63). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0558b63) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   59.17%   -9.21%     
   + Complexity    27505    23986    -3519     
   ============================================
     Files          2428     2436       +8     
     Lines        132926   133340     +414     
     Branches      16000    16044      +44     
   ============================================
   - Hits          90902    78907   -11995     
   - Misses        34964    47678   +12714     
   + Partials       7060     6755     -305     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <14.49%> (-16.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <21.73%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <7.97%> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.49% <66.66%> (-6.00%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.24% <59.25%> (-5.44%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [651 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132004343

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.79739%` with `112 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.32%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (def1b9c). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (def1b9c) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.32%   -23.06%     
   + Complexity    27570    15398    -12172     
   =============================================
     Files          2433     1997      -436     
     Lines        133224   110720    -22504     
     Branches      16028    13929     -2099     
   =============================================
   - Hits          91103    50182    -40921     
   - Misses        35064    55190    +20126     
   + Partials       7057     5348     -1709     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <24.83%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4131994842

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.79739%` with `112 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.88%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (def1b9c). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (def1b9c) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   46.88%   -21.50%     
   + Complexity    27570    14882    -12688     
   =============================================
     Files          2433     1934      -499     
     Lines        133224   103368    -29856     
     Branches      16028    12335     -3693     
   =============================================
   - Hits          91103    48468    -42635     
   - Misses        35064    49954    +14890     
   + Partials       7057     4946     -2111     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <24.83%> (-12.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1594 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117357872

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.48%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   47.48%   -20.91%     
   + Complexity    27505    15991    -11514     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110607    -22319     
     Branches      16000    13911     -2089     
   =============================================
   - Hits          90902    52517    -38385     
   - Misses        34964    52737    +17773     
   + Partials       7060     5353     -1707     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <9.40%> (-15.75%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <17.09%> (-13.76%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.02% <72.72%> (-6.66%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1506 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117360733

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.68%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   47.68%   -20.71%     
   + Complexity    27505    16039    -11466     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110607    -22319     
     Branches      16000    13911     -2089     
   =============================================
   - Hits          90902    52741    -38161     
   - Misses        34964    52433    +17469     
   + Partials       7060     5433     -1627     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <9.40%> (-16.24%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <17.09%> (-13.76%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.02% <72.72%> (-6.66%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1502 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117323317

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.13%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   44.13%   -24.25%     
   + Complexity    27505    14960    -12545     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110607    -22319     
     Branches      16000    13911     -2089     
   =============================================
   - Hits          90902    48821    -42081     
   - Misses        34964    56747    +21783     
   + Partials       7060     5039     -2021     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <17.09%> (-13.76%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <72.72%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1565 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122902434

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `18.64407%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.99%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.99%   -2.39%     
   + Complexity    27505    26576     -929     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    87961    -2941     
   - Misses        34964    38052    +3088     
   - Partials       7060     7266     +206     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <8.47%> (-16.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <16.94%> (-0.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <66.66%> (-4.73%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <66.66%> (-2.00%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [343 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122890998

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `18.64407%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.87%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.87%   -2.52%     
   + Complexity    27505    26530     -975     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    87792    -3110     
   - Misses        34964    38205    +3241     
   - Partials       7060     7282     +222     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <8.47%> (-16.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <16.94%> (-0.34%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <66.66%> (-4.73%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `63.88% <60.00%> (-7.99%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <66.66%> (-2.00%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [378 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122903581

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.27119%` with `87 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.40%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.40%   -0.99%     
   + Complexity    27505    27204     -301     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    89834    -1068     
   - Misses        34964    36311    +1347     
   - Partials       7060     7134      +74     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <26.27%> (-3.83%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <16.94%> (-0.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `66.66% <60.00%> (-5.21%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.39% <66.66%> (-1.28%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `76.36% <0.00%> (-9.64%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [180 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123540842

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.79661%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.89%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`00e727b`](https://app.codecov.io/gh/apache/hudi/commit/00e727be1f7b384f7540434cae54e42cc899c001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (00e727b). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (00e727b) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   46.89%   -21.50%     
   + Complexity    27505    14882    -12623     
   =============================================
     Files          2428     1934      -494     
     Lines        132926   103326    -29600     
     Branches      16000    12326     -3674     
   =============================================
   - Hits          90902    48451    -42451     
   - Misses        34964    49939    +14975     
   + Partials       7060     4936     -2124     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <14.28%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.30% <16.10%> (-12.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <66.66%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1596 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132713663

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `13.49206%` with `109 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.09%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a012c2`](https://app.codecov.io/gh/apache/hudi/commit/4a012c2e3fc86b4edf77e95a566ea35647461acb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 7.40% | [24 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (4a012c2). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (4a012c2) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.09%   -23.29%     
   + Complexity    27570     8459    -19111     
   =============================================
     Files          2433     1196     -1237     
     Lines        133224    61448    -71776     
     Branches      16028     6570     -9458     
   =============================================
   - Hits          91103    27711    -63392     
   + Misses        35064    30719     -4345     
   + Partials       7057     3018     -4039     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `57.77% <66.66%> (-31.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `55.55% <40.00%> (-16.32%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `56.33% <41.17%> (-40.44%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `12.75% <7.40%> (-79.92%)` | :arrow_down: |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2024 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159068030

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.45098%` with `111 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.11%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   48.11%   -20.15%     
   + Complexity    27761    16363    -11398     
   =============================================
     Files          2439     1998      -441     
     Lines        134355   111276    -23079     
     Branches      16210    14063     -2147     
   =============================================
   - Hits          91715    53541    -38174     
   - Misses        35543    52115    +16572     
   + Partials       7097     5620     -1477     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.28% <13.07%> (-15.50%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <24.83%> (-12.64%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1498 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159061164

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.79739%` with `112 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.74%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   45.74%   -22.52%     
   + Complexity    27761    15230    -12531     
   =============================================
     Files          2439     1969      -470     
     Lines        134355   108679    -25676     
     Branches      16210    13510     -2700     
   =============================================
   - Hits          91715    49717    -41998     
   - Misses        35543    53715    +18172     
   + Partials       7097     5247     -1850     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <24.83%> (-12.50%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159104907

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.27%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   67.27%   -1.00%     
   + Complexity    27761    27387     -374     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   - Hits          91715    90465    -1250     
   - Misses        35543    36815    +1272     
   - Partials       7097     7199     +102     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <32.67%> (-3.80%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <37.25%> (+0.02%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [177 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159119864

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.22%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   68.22%   -0.05%     
   - Complexity    27761    27771      +10     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   + Hits          91715    91744      +29     
   - Misses        35543    35622      +79     
   - Partials       7097     7113      +16     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <32.67%> (-0.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <37.25%> (+0.22%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159129015

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.22%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   68.22%   -0.04%     
   - Complexity    27761    27771      +10     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   + Hits          91715    91747      +32     
   - Misses        35543    35621      +78     
   - Partials       7097     7111      +14     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <32.67%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <37.25%> (+0.22%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117309519

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.66%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   46.66%   -21.73%     
   + Complexity    27505    14798    -12707     
   =============================================
     Files          2428     1934      -494     
     Lines        132926   103269    -29657     
     Branches      16000    12319     -3681     
   =============================================
   - Hits          90902    48188    -42714     
   - Misses        34964    50149    +15185     
   + Partials       7060     4932     -2128     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.27% <17.09%> (-12.14%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <72.72%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1602 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124072712

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `23.52941%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.89%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.89%   -2.49%     
   + Complexity    27505    26543     -962     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    87832    -3070     
   - Misses        34964    38178    +3214     
   - Partials       7060     7280     +220     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <14.70%> (-16.07%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <22.05%> (-0.34%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <66.66%> (-4.73%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `86.36% <0.00%> (+5.41%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `88.96% <59.25%> (-3.71%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [374 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124102420

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.44%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.44%   -0.95%     
   + Complexity    27505    27215     -290     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    89895    -1007     
   - Misses        34964    36267    +1303     
   - Partials       7060     7128      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <30.14%> (-3.76%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <22.05%> (-0.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `76.36% <0.00%> (-9.64%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [174 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4131830101

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `4.57516%` with `146 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 9.11%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`01f8f24`](https://app.codecov.io/gh/apache/hudi/commit/01f8f2423215b4bf3e3bc2b5d96406477f2e535c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (9859f9a) and HEAD (01f8f24). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (9859f9a) | HEAD (01f8f24) |
   >|------|------|------|
   >|hadoop-mr-java-client|1|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|2|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%    9.11%   -59.27%     
   + Complexity    27570     3856    -23714     
   =============================================
     Files          2433     2402       -31     
     Lines        133224   128726     -4498     
     Branches      16028    15063      -965     
   =============================================
   - Hits          91103    11735    -79368     
   - Misses        35064   116026    +80962     
   + Partials       7057      965     -6092     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `9.29% <4.57%> (-35.05%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `10.16% <4.57%> (-38.55%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `63.63% <0.00%> (-17.32%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-89.50%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-71.88%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `77.46% <41.17%> (-19.31%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `0.00% <0.00%> (-73.08%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1924 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4132083360

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.98%. Comparing base ([`9859f9a`](https://app.codecov.io/gh/apache/hudi/commit/9859f9aa29df124069c8d8d12df44a1635d48380?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def1b9c`](https://app.codecov.io/gh/apache/hudi/commit/def1b9c7715891f128d287fb91a27dc20558bca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.98%   -2.41%     
   + Complexity    27570    22396    -5174     
   ============================================
     Files          2433     1997     -436     
     Lines        133224   110720   -22504     
     Branches      16028    13929    -2099     
   ============================================
   - Hits          91103    73056   -18047     
   + Misses        35064    31452    -3612     
   + Partials       7057     6212     -845     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <13.49%> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <10.88%> (-0.08%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <32.67%> (-0.24%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.53% <37.25%> (+0.14%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <10.45%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [806 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251830278

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.70%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.70%   +0.17%     
   - Complexity    27968    28162     +194     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   + Hits          92138    93010     +872     
   + Misses        35054    35030      -24     
   - Partials       7264     7341      +77     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <46.15%> (+0.03%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <45.24%> (-0.03%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4252233887

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 68c3a7c332aded67dac0a6e9804236c2ee30bd15 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4234905256

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `32.97872%` with `126 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.74%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 26.08% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (eba8579). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (eba8579) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.74%   -21.78%     
   + Complexity    27968    14997    -12971     
   =============================================
     Files          2440     1943      -497     
     Lines        134456   104962    -29494     
     Branches      16226    12701     -3525     
   =============================================
   - Hits          92138    49067    -43071     
   - Misses        35054    50896    +15842     
   + Partials       7264     4999     -2265     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <30.85%> (-12.47%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `78.04% <100.00%> (-7.14%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <66.66%> (+4.23%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1602 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4234906296

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `32.97872%` with `126 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.17%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 26.08% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [3 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (eba8579). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (eba8579) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   46.17%   -22.36%     
   + Complexity    27968    15159    -12809     
   =============================================
     Files          2440     1960      -480     
     Lines        134456   107307    -27149     
     Branches      16226    13202     -3024     
   =============================================
   - Hits          92138    49546    -42592     
   - Misses        35054    52612    +17558     
   + Partials       7264     5149     -2115     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <30.85%> (-12.74%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.95% <100.00%> (-28.54%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `78.04% <100.00%> (-7.14%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `81.97% <90.90%> (-7.95%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <66.66%> (+4.23%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1592 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4163556075

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.79739%` with `112 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.71%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`285dd98`](https://app.codecov.io/gh/apache/hudi/commit/285dd985152f4496787f8bbabab89a56ef2d3ed3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (285dd98). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (285dd98) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   45.71%   -22.82%     
   + Complexity    27968    15229    -12739     
   =============================================
     Files          2440     1970      -470     
     Lines        134456   108768    -25688     
     Branches      16226    13525     -2701     
   =============================================
   - Hits          92138    49724    -42414     
   - Misses        35054    53793    +18739     
   + Partials       7264     5251     -2013     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <13.49%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.31% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <24.83%> (-12.87%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4163354529

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `13.49206%` with `109 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.92%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`285dd98`](https://app.codecov.io/gh/apache/hudi/commit/285dd985152f4496787f8bbabab89a56ef2d3ed3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 7.40% | [24 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 41.17% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (285dd98). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (285dd98) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   44.92%   -23.61%     
   + Complexity    27968     8464    -19504     
   =============================================
     Files          2440     1197     -1243     
     Lines        134456    61750    -72706     
     Branches      16226     6629     -9597     
   =============================================
   - Hits          92138    27741    -64397     
   + Misses        35054    30989     -4065     
   + Partials       7264     3020     -4244     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <13.49%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `57.77% <66.66%> (-31.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `55.55% <40.00%> (-16.32%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `56.33% <41.17%> (-40.44%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `12.75% <7.40%> (-79.92%)` | :arrow_down: |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4133354074

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 4a012c2e3fc86b4edf77e95a566ea35647461acb Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117472012

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.35043%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.15%   -0.24%     
   + Complexity    27505    27439      -66     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    90795     -107     
   - Misses        34964    35407     +443     
   + Partials       7060     7020      -40     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <27.35%> (-0.15%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <17.94%> (-0.24%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.75% <72.72%> (-0.92%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [54 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117440039

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.35043%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.16%   -1.23%     
   + Complexity    27505    27028     -477     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    89478    -1424     
   - Misses        34964    36699    +1735     
   + Partials       7060     7045      -15     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <27.35%> (-3.79%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <17.94%> (-0.64%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.39% <72.72%> (-1.28%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [177 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124040689

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.79412%` with `105 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (48b2d92). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (48b2d92) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   48.19%   -20.20%     
   + Complexity    27505    16316    -11189     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110675    -22251     
     Branches      16000    13921     -2079     
   =============================================
   - Hits          90902    53340    -37562     
   - Misses        34964    51784    +16820     
   + Partials       7060     5551     -1509     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.45% <14.70%> (-15.24%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <20.58%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1490 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124029257

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.05882%` with `106 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.83%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (48b2d92). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (48b2d92) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.83%   -22.55%     
   + Complexity    27505    15205    -12300     
   =============================================
     Files          2428     1968      -460     
     Lines        132926   108121    -24805     
     Branches      16000    13378     -2622     
   =============================================
   - Hits          90902    49561    -41341     
   - Misses        34964    53371    +18407     
   + Partials       7060     5189     -1871     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <20.58%> (-12.55%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `66.55% <55.55%> (-26.13%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124131707

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.32%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.32%   -0.07%     
   - Complexity    27505    27565      +60     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   + Hits          90902    91070     +168     
   - Misses        34964    35149     +185     
   - Partials       7060     7071      +11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <30.14%> (-0.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <22.05%> (-0.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.00% <59.25%> (-2.68%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123204161

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5dc57e946c09abbfece1b469bf74e81e4c5fd7e9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814) 
   * 00e727be1f7b384f7540434cae54e42cc899c001 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188698256

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `19.49686%` with `128 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.94%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 22.22% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 11.76% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 42.10% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (ebbf353). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (ebbf353) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   53.94%   -14.59%     
   + Complexity    27968    12263    -15705     
   =============================================
     Files          2440     1427     -1013     
     Lines        134456    70865    -63591     
     Branches      16226     7973     -8253     
   =============================================
   - Hits          92138    38226    -53912     
   + Misses        35054    29215     -5839     
   + Partials       7264     3424     -3840     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.00% <100.00%> (-29.50%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `74.07% <66.66%> (-6.88%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `69.86% <42.10%> (-26.92%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `58.24% <0.00%> (-14.83%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1784 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.

yihua commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3082972667


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    HoodieIOFactory ioFactory = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf));
+    reader = ioFactory.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+

Review Comment:
   <a href="#"><img alt="P1" src="https://greptile-static-assets.s3.amazonaws.com/badges/p1.svg?v=7" align="top"></a> **AVRO record type contradicts Lance's Spark-only requirement**
   
   `HoodieRecord.HoodieRecordType.AVRO` is passed to `getReaderFactory`, but the newly added `HoodieFileFormat.requiresSparkRecordType()` Javadoc explicitly states: *"Lance only supports the Spark-native InternalRow representation, not Avro."* If the underlying Lance reader truly cannot produce `IndexedRecord` results, the subsequent cast on line 86 will throw a `ClassCastException` at runtime:
   
   ```java
   IndexedRecord record = recordIterator.next().getData(); // getData() returns InternalRow, not IndexedRecord
   ```
   
   Consider using `HoodieRecord.HoodieRecordType.SPARK` and converting the resulting `InternalRow` to Avro before calling `avroToArrayWritable`, or document why the AVRO path is acceptable here despite the stated constraint.
   
   — *Greptile* ([original](https://github.com/yihua/hudi/pull/17#discussion_r3036302465)) (source:comment#3036302465)



##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    HoodieIOFactory ioFactory = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf));
+    reader = ioFactory.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    return 0;
+  }
+
+  @Override
+  public void close() throws IOException {

Review Comment:
   <a href="#"><img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=7" align="top"></a> **`getPos()` stub always returns 0**
   
   `getPos()` returns a hardcoded `0`, which means the MapReduce job tracker will never see progress updates for Lance file reads beyond the start position. For large Lance files, this causes incorrect task-progress estimates and prevents the framework from detecting hung tasks. The TODO comment acknowledges this, but it should be tracked as a follow-up issue before production use.
   
   — *Greptile* ([original](https://github.com/yihua/hudi/pull/17#discussion_r3036302560)) (source:comment#3036302560)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3198651888


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -83,6 +99,20 @@ public static HoodieFileFormat fromFileExtension(String extension) {
     throw new IllegalArgumentException("Unknown file extension :" + extension);
   }
 
+  /**
+   * Returns the {@link HoodieFileFormat} matching the given file extension, or {@code null}
+   * if no match is found. Useful when the caller wants to handle unknown extensions without
+   * exception-based control flow.
+   */
+  public static HoodieFileFormat fromFileExtensionOrNull(String extension) {

Review Comment:
   Verified at HoodieFileFormat.java:93 — `fromFileExtension` now delegates to `fromFileExtensionOrNull` (line 106) and throws on null. Pushed at 2def3286, please resolve when convenient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393932444

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 49.01%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (fd85491). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (fd85491) |
   >|------|------|------|
   >|spark-scala-tests|12|3|
   >|spark-java-tests|18|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   49.01%   -19.08%     
   + Complexity    28940    16348    -12592     
   =============================================
     Files          2519     1982      -537     
     Lines        140646   109642    -31004     
     Branches      17427    13617     -3810     
   =============================================
   - Hits          95757    53738    -42019     
   - Misses        37030    50330    +13300     
   + Partials       7859     5574     -2285     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <23.88%> (-15.56%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <40.55%> (-11.79%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-5.85%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1590 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393982138

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.09%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.09%   -3.00%     
   + Complexity    28940    27712    -1228     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   - Hits          95757    91651    -4106     
   - Misses        37030    41246    +4216     
   - Partials       7859     7903      +44     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <23.88%> (-17.00%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <40.55%> (-0.22%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.66% <27.22%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `62.37% <ø> (-7.74%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.45% <90.90%> (-1.22%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [367 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4394025440

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.07%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.07%   -0.02%     
   - Complexity    28940    28980      +40     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   + Hits          95757    95843      +86     
   - Misses        37030    37084      +54     
   - Partials       7859     7873      +14     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <60.00%> (-0.08%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.66% <27.22%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369085447

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.65%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|6|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   60.65%   -7.44%     
   + Complexity    28940    25806    -3134     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   - Hits          95757    85385   -10372     
   - Misses        37030    47941   +10911     
   + Partials       7859     7456     -403     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <23.88%> (-17.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.55%> (-12.21%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.67% <90.90%> (-3.00%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [548 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369073031

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 47.68%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (2def328). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (2def328) |
   >|------|------|------|
   >|spark-scala-tests|12|6|
   >|spark-java-tests|18|5|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   47.68%   -20.40%     
   + Complexity    28940    17070    -11870     
   =============================================
     Files          2519     2050      -469     
     Lines        140646   117161    -23485     
     Branches      17427    15227     -2200     
   =============================================
   - Hits          95757    55871    -39886     
   - Misses        37030    55157    +18127     
   + Partials       7859     6133     -1726     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.59% <23.88%> (-17.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <40.55%> (-12.21%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-5.85%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369180438

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.07%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.07%   -0.01%     
   - Complexity    28940    28973      +33     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   + Hits          95757    95840      +83     
   - Misses        37030    37072      +42     
   - Partials       7859     7870      +11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <60.00%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4369178322

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `62.77778%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.07%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2def328`](https://app.codecov.io/gh/apache/hudi/commit/2def3286cfa1c9467d6dd970e933e2f2925c36b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 71.42% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 90.90% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 87.50% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.07%   -0.01%     
   - Complexity    28940    28973      +33     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140782     +136     
     Branches      17427    17444      +17     
   ============================================
   + Hits          95757    95840      +83     
   - Misses        37030    37072      +42     
   - Partials       7859     7870      +11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.34% <36.11%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <40.26%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <31.54%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <60.00%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <40.55%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.67% <27.22%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429008443

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.55%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (4bb5b0f). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (4bb5b0f) |
   >|------|------|------|
   >|spark-scala-tests|12|5|
   >|spark-java-tests|18|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   60.55%   -7.53%     
   + Complexity    28940    25846    -3094     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    85771    -9986     
   - Misses        37030    48423   +11393     
   + Partials       7859     7448     -411     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <25.00%> (-17.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <40.34%> (-11.93%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.96% <100.00%> (-2.71%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [597 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429038994

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.61364%` with `101 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.19%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 55.55% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.19%   -2.90%     
   + Complexity    28940    27876    -1064     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   - Hits          95757    92337    -3420     
   - Misses        37030    41313    +4283     
   - Partials       7859     7992     +133     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <25.00%> (-17.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.60% <40.34%> (-0.16%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.75% <100.00%> (-0.92%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `62.37% <ø> (-7.74%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [417 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4429109588

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.05%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4bb5b0f`](https://app.codecov.io/gh/apache/hudi/commit/4bb5b0f2d2a8c17e1e47df2c4f2b5a5e90707482?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 19 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   68.05%   -0.04%     
   - Complexity    28940    29129     +189     
   ============================================
     Files          2519     2530      +11     
     Lines        140646   141642     +996     
     Branches      17427    17570     +143     
   ============================================
   + Hits          95757    96392     +635     
   - Misses        37030    37310     +280     
   - Partials       7859     7940      +81     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <35.79%> (+0.03%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <40.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <31.09%> (-0.12%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <60.22%> (+0.23%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <40.34%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.61% <28.40%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.83% <100.00%> (+0.15%)` | :arrow_up: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [70 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun closed pull request #18375: feat(lance): Ensure Spark-SQL works correctly when using lance as base file format
URL: https://github.com/apache/hudi/pull/18375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117396523

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.94872%` with `96 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.45%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.45%   -2.93%     
   + Complexity    27505    26265    -1240     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    87203    -3699     
   - Misses        34964    38844    +3880     
   - Partials       7060     7175     +115     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <9.40%> (-16.24%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.09% <17.94%> (-1.32%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <66.66%> (-4.73%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `86.36% <0.00%> (+5.41%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.68% <72.72%> (-2.00%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [386 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117450893

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.35043%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.15%   -0.24%     
   + Complexity    27505    27439      -66     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    90793     -109     
   - Misses        34964    35408     +444     
   + Partials       7060     7021      -39     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <27.35%> (-0.19%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <17.94%> (-0.24%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.75% <72.72%> (-0.92%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [54 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117320829

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `17.09402%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.07%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0435c7f). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0435c7f) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   45.07%   -23.31%     
   + Complexity    27505    14960    -12545     
   =============================================
     Files          2428     1980      -448     
     Lines        132926   108268    -24658     
     Branches      16000    13407     -2593     
   =============================================
   - Hits          90902    48806    -42096     
   - Misses        34964    54421    +19457     
   + Partials       7060     5041     -2019     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.32% <17.09%> (-13.09%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.63% <66.66%> (-28.86%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `60.60% <50.00%> (-11.27%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.38% <72.72%> (-25.30%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1573 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4117529289

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.35043%` with `85 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0435c7f`](https://app.codecov.io/gh/apache/hudi/commit/0435c7f6d049444a4661a24aa9160fb23714af94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   68.15%   -0.23%     
   + Complexity    27505    27440      -65     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133222     +296     
     Branches      16000    16033      +33     
   ============================================
   - Hits          90902    90799     -103     
   - Misses        34964    35403     +439     
   + Partials       7060     7020      -40     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.29% <9.40%> (-0.06%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <10.00%> (-0.02%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.84% <11.71%> (-0.37%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <27.35%> (-0.04%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <17.94%> (-0.24%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.83%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.69% <100.00%> (-2.18%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.75% <72.72%> (-0.92%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `70.10% <25.00%> (-2.98%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124111823

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.52%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.52%   -0.86%     
   + Complexity    27505    27252     -253     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    90006     -896     
   - Misses        34964    36156    +1192     
   - Partials       7060     7128      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <30.14%> (-3.64%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <22.05%> (-0.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4122908092

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.27119%` with `87 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.42%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5dc57e9`](https://app.codecov.io/gh/apache/hudi/commit/5dc57e946c09abbfece1b469bf74e81e4c5fd7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 66.66% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.42%   -0.97%     
   + Complexity    27505    27210     -295     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133279     +353     
     Branches      16000    16038      +38     
   ============================================
   - Hits          90902    89862    -1040     
   - Misses        34964    36287    +1323     
   - Partials       7060     7130      +70     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <10.16%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <10.98%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <14.28%> (+0.06%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <26.27%> (-3.75%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <16.94%> (-0.12%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <7.62%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `66.66% <60.00%> (-5.21%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.39% <66.66%> (-1.28%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `76.36% <0.00%> (-9.64%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [174 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124036599

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `22.79412%` with `105 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.12%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (48b2d92). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (48b2d92) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   48.12%   -20.26%     
   + Complexity    27505    16288    -11217     
   =============================================
     Files          2428     1997      -431     
     Lines        132926   110675    -22251     
     Branches      16000    13921     -2079     
   =============================================
   - Hits          90902    53263    -37639     
   - Misses        34964    51856    +16892     
   + Partials       7060     5556     -1504     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <14.70%> (-14.94%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <20.58%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `51.35% <29.41%> (-38.65%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1491 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124941690

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `23.91304%` with `105 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.69%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0558b63). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0558b63) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   54.69%   -13.70%     
   + Complexity    27505    22453     -5052     
   =============================================
     Files          2428     2436        +8     
     Lines        132926   133340      +414     
     Branches      16000    16044       +44     
   =============================================
   - Hits          90902    72929    -17973     
   - Misses        34964    54093    +19129     
   + Partials       7060     6318      -742     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <14.49%> (-15.30%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <21.73%> (-12.75%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.22% <66.66%> (-7.27%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `87.24% <59.25%> (-5.44%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [788 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124924321

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `23.18841%` with `106 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 52.97%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 55.55% | [3 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (817b3ad) and HEAD (0558b63). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (817b3ad) | HEAD (0558b63) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.38%   52.97%   -15.42%     
   + Complexity    27505    21388     -6117     
   =============================================
     Files          2428     2407       -21     
     Lines        132926   130772     -2154     
     Branches      16000    15419      -581     
   =============================================
   - Hits          90902    69274    -21628     
   - Misses        34964    55580    +20616     
   + Partials       7060     5918     -1142     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.04% <21.73%> (-12.37%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `77.77% <66.66%> (-11.72%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `76.89% <55.55%> (-15.78%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [867 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4123803308

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5dc57e946c09abbfece1b469bf74e81e4c5fd7e9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814) 
   * 00e727be1f7b384f7540434cae54e42cc899c001 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818) 
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 48b2d926bd07a6c8ac879da74d24118d46b91540 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124093813

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `24.26471%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.25%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.25%   -1.13%     
   + Complexity    27505    27143     -362     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    89649    -1253     
   - Misses        34964    36480    +1516     
   - Partials       7060     7161     +101     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.30% <22.79%> (-6.40%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <22.05%> (-0.25%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `59.42% <100.00%> (-7.25%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.61% <66.66%> (-1.88%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `86.36% <0.00%> (+5.41%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `64.86% <35.29%> (-25.14%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [217 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4124107825

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `31.61765%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.52%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48b2d92`](https://app.codecov.io/gh/apache/hudi/commit/48b2d926bd07a6c8ac879da74d24118d46b91540?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   67.52%   -0.86%     
   + Complexity    27505    27252     -253     
   ============================================
     Files          2428     2435       +7     
     Lines        132926   133290     +364     
     Branches      16000    16043      +43     
   ============================================
   - Hits          90902    90005     -897     
   - Misses        34964    36157    +1193     
   - Partials       7060     7128      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <8.82%> (-0.07%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <9.17%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.30%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <30.14%> (-3.65%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <22.05%> (-0.05%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <6.61%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `63.91% <25.00%> (-9.16%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.65% <59.25%> (-3.02%)` | :arrow_down: |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [154 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4125031401

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `36.95652%` with `87 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0558b63`](https://app.codecov.io/gh/apache/hudi/commit/0558b632a959e4d2a44e3de84586d0e294c07654?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.38%   65.29%   -3.09%     
   + Complexity    27505    26492    -1013     
   ============================================
     Files          2428     2436       +8     
     Lines        132926   133340     +414     
     Branches      16000    16044      +44     
   ============================================
   - Hits          90902    87065    -3837     
   - Misses        34964    39270    +4306     
   + Partials       7060     7005      -55     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.24% <10.14%> (-7.11%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <10.81%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <12.12%> (+0.29%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <31.15%> (-3.76%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.54% <35.50%> (+0.13%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.48% <7.97%> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `96.82% <100.00%> (+0.05%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `78.18% <0.00%> (-7.82%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [284 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159069133

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `27.45098%` with `111 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.15%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (1ff0506) and HEAD (83a8c0d). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (1ff0506) | HEAD (83a8c0d) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.26%   48.15%   -20.11%     
   + Complexity    27761    16373    -11388     
   =============================================
     Files          2439     1998      -441     
     Lines        134355   111276    -23079     
     Branches      16210    14063     -2147     
   =============================================
   - Hits          91715    53583    -38132     
   - Misses        35543    52082    +16539     
   + Partials       7097     5611     -1486     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <13.07%> (-15.89%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <24.83%> (-12.64%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.11% <66.66%> (-18.38%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `81.81% <0.00%> (+0.86%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `69.44% <80.00%> (-2.44%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `68.96% <0.00%> (-19.93%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `78.87% <64.70%> (-17.91%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `84.48% <59.25%> (-8.20%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1498 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4159106808

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `39.21569%` with `93 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.33%. Comparing base ([`1ff0506`](https://app.codecov.io/gh/apache/hudi/commit/1ff0506ec3400fd87c0a3bbb9ffe2f8fb58cb310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83a8c0d`](https://app.codecov.io/gh/apache/hudi/commit/83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 59.25% | [2 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 64.70% | [3 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.26%   67.33%   -0.93%     
   + Complexity    27761    27404     -357     
   ============================================
     Files          2439     2442       +3     
     Lines        134355   134479     +124     
     Branches      16210    16231      +21     
   ============================================
   - Hits          91715    90550    -1165     
   - Misses        35543    36751    +1208     
   - Partials       7097     7178      +81     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <13.72%> (-0.04%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.49%> (-0.09%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <10.88%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <32.67%> (-3.80%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.44% <37.25%> (+0.14%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.37% <10.45%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `89.65% <100.00%> (+0.76%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `90.90% <100.00%> (+9.95%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (+3.12%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `66.66% <100.00%> (ø)` | |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `70.58% <80.00%> (-4.42%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `91.54% <64.70%> (-5.23%)` | :arrow_down: |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188709235

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `30.90909%` with `114 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 58.87%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 29.41% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (ebbf353). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (ebbf353) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   58.87%   -9.65%     
   + Complexity    27968    24017    -3951     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   - Hits          92138    79246   -12892     
   - Misses        35054    48554   +13500     
   + Partials       7264     6790     -474     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.40% <15.15%> (-16.37%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.62% <27.87%> (-13.03%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.53% <100.00%> (-6.96%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `74.07% <66.66%> (-6.88%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (-86.00%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | `90.41% <63.15%> (-6.37%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [678 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035479919


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/TestQueryMergeOnReadOptimizedTable.scala:
##########
@@ -19,63 +19,72 @@
 
 package org.apache.spark.sql.hudi.feature
 
+import org.apache.hudi.HoodieSparkUtils
+
 import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase
+import org.scalatest.Inspectors.forAll
 
 class TestQueryMergeOnReadOptimizedTable extends HoodieSparkSqlTestBase {
-  test("Test Query Merge_On_Read Read_Optimized table") {
-    withTempDir { tmp =>
-      val tableName = generateTableName
-      val tablePath = s"${tmp.getCanonicalPath}/$tableName"
-      // create table
-      spark.sql(
-        s"""
-           |create table $tableName (
-           |  id int,
-           |  name string,
-           |  price double,
-           |  ts long,
-           |  partition long
-           |) using hudi
-           | partitioned by (partition)
-           | location '$tablePath'
-           | tblproperties (
-           |  type = 'mor',
-           |  primaryKey = 'id',
-           |  orderingFields = 'ts'
-           | )
-       """.stripMargin)
-      // insert data to table
-      withSQLConf("hoodie.parquet.max.file.size" -> "10000") {
-        spark.sql(s"insert into $tableName values(1, 'a1', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(2, 'a2', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(3, 'a3', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(4, 'a4', 10, 1000, 1000)")
-        spark.sql(s"update $tableName set price = 11 where id = 1")
-        spark.sql(s"update $tableName set price = 21 where id = 2")
-        spark.sql(s"update $tableName set price = 31 where id = 3")
-        spark.sql(s"update $tableName set price = 41 where id = 4")
 
-        // expect that all complete parquet files can be scanned
-        assertQueryResult(4, tablePath)
+  val baseFileFormats: List[String] = if (HoodieSparkUtils.gteqSpark3_4) List("parquet", "lance") else List("parquet")
+
+  forAll(baseFileFormats) { (baseFileFormat: String) =>
+    test(s"Test Query Merge_On_Read Read_Optimized table - $baseFileFormat") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        val tablePath = s"${tmp.getCanonicalPath}/$tableName"
+        // create table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  name string,
+             |  price double,
+             |  ts long,
+             |  partition long
+             |) using hudi
+             | partitioned by (partition)
+             | location '$tablePath'
+             | tblproperties (
+             |  type = 'mor',
+             |  primaryKey = 'id',

Review Comment:
   Fixed, added merger impl config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035476931


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    // TODO Auto-generated method stub
+    return 0;
+  }
+
+  @Override
+  public void close() throws IOException {
+    if (reader != null) {
+      reader.close();
+      reader = null;
+    }
+    if (recordIterator != null) {
+      recordIterator.close();
+      recordIterator = null;
+    }
+  }
+
+  @Override
+  public float getProgress() throws IOException {
+    return 1.0f * count / reader.getTotalRecords();

Review Comment:
   Fixed with the suggested guard. Applied same fix to HoodieHFileRecordReader.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035482138


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -136,18 +140,43 @@ protected BufferedRecord<T> handleNonDeletes(BufferedRecord<T> previousRecord, B
         // special case for payloads when there is no previous record
         HoodieSchema recordSchema = readerContext.getRecordContext().decodeAvroSchema(mergedRecord.getSchemaId());
         GenericRecord record = readerContext.getRecordContext().convertToAvroRecord(mergedRecord.getRecord(), recordSchema);
-        HoodieAvroRecord hoodieRecord = new HoodieAvroRecord<>(null, HoodieRecordUtils.loadPayload(payloadClass, record, mergedRecord.getOrderingValue()));
-        try {
-          if (hoodieRecord.shouldIgnore(recordSchema, properties)) {
-            return null;
-          } else {
-            HoodieSchema readerSchema = readerContext.getSchemaHandler().getRequestedSchema();
-            // If the record schema is different from the reader schema, rewrite the record using the payload methods to ensure consistency with legacy writer paths
-            hoodieRecord.rewriteRecordWithNewSchema(recordSchema, properties, readerSchema).toIndexedRecord(readerSchema, properties)
-                .ifPresent(rewrittenRecord -> mergedRecord.replaceRecord(readerContext.getRecordContext().convertAvroRecord(rewrittenRecord.getData())));
+        Schema recordAvroSchema = recordSchema.toAvroSchema();
+
+        // If convertToAvroRecord returned a cached record with a different schema (e.g., from
+        // extractDataFromRecord caching for ExpressionPayload in the COW write path), the record
+        // is already in write-schema format with correctly evaluated expressions. Convert directly.
+        // Note: SENTINEL records have null schema and must go through the payload path for shouldIgnore.

Review Comment:
   Safe — SENTINEL records always have `null` schema (`HoodieRecord.EmptyRecord.getSchema()` returns null), so the `record.getSchema() != null` guard prevents them from entering this branch. Strengthened the comment to make this invariant explicit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035478575


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/TestQueryMergeOnReadOptimizedTable.scala:
##########
@@ -19,63 +19,72 @@
 
 package org.apache.spark.sql.hudi.feature
 
+import org.apache.hudi.HoodieSparkUtils
+
 import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase
+import org.scalatest.Inspectors.forAll
 
 class TestQueryMergeOnReadOptimizedTable extends HoodieSparkSqlTestBase {
-  test("Test Query Merge_On_Read Read_Optimized table") {
-    withTempDir { tmp =>
-      val tableName = generateTableName
-      val tablePath = s"${tmp.getCanonicalPath}/$tableName"
-      // create table
-      spark.sql(
-        s"""
-           |create table $tableName (
-           |  id int,
-           |  name string,
-           |  price double,
-           |  ts long,
-           |  partition long
-           |) using hudi
-           | partitioned by (partition)
-           | location '$tablePath'
-           | tblproperties (
-           |  type = 'mor',
-           |  primaryKey = 'id',
-           |  orderingFields = 'ts'
-           | )
-       """.stripMargin)
-      // insert data to table
-      withSQLConf("hoodie.parquet.max.file.size" -> "10000") {
-        spark.sql(s"insert into $tableName values(1, 'a1', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(2, 'a2', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(3, 'a3', 10, 1000, 1000)")
-        spark.sql(s"insert into $tableName values(4, 'a4', 10, 1000, 1000)")
-        spark.sql(s"update $tableName set price = 11 where id = 1")
-        spark.sql(s"update $tableName set price = 21 where id = 2")
-        spark.sql(s"update $tableName set price = 31 where id = 3")
-        spark.sql(s"update $tableName set price = 41 where id = 4")
 
-        // expect that all complete parquet files can be scanned
-        assertQueryResult(4, tablePath)
+  val baseFileFormats: List[String] = if (HoodieSparkUtils.gteqSpark3_4) List("parquet", "lance") else List("parquet")
+

Review Comment:
   Fixed, switched to `baseFileFormats.foreach`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4188747583

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `41.21212%` with `97 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.71%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebbf353`](https://app.codecov.io/gh/apache/hudi/commit/ebbf353f9f3785b17ded961be299271837bcb6c1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 13 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 70.58% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.71%   +0.18%     
   - Complexity    27968    28080     +112     
   ============================================
     Files          2440     2449       +9     
     Lines        134456   134590     +134     
     Branches      16226    16277      +51     
   ============================================
   + Hits          92138    92483     +345     
   + Misses        35054    34808     -246     
   - Partials       7264     7299      +35     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <16.96%> (+0.13%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <16.66%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <14.46%> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.74% <34.54%> (-0.03%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.85% <38.78%> (+0.20%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.30% <12.12%> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <100.00%> (+4.23%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `69.62% <100.00%> (ø)` | |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | `81.08% <70.58%> (-8.92%)` | :arrow_down: |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | `80.00% <0.00%> (-6.00%)` | :arrow_down: |
   | ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [65 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.

hudi-bot commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273290887

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12800",
       "triggerID" : "0435c7f6d049444a4661a24aa9160fb23714af94",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12814",
       "triggerID" : "5dc57e946c09abbfece1b469bf74e81e4c5fd7e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12818",
       "triggerID" : "00e727be1f7b384f7540434cae54e42cc899c001",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0a1f3c81b356d279a5f51cfb70822166e2bb27f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12821",
       "triggerID" : "48b2d926bd07a6c8ac879da74d24118d46b91540",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12829",
       "triggerID" : "0558b632a959e4d2a44e3de84586d0e294c07654",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f8f2423215b4bf3e3bc2b5d96406477f2e535c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12854",
       "triggerID" : "def1b9c7715891f128d287fb91a27dc20558bca6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4116335da8cfbe4bf1062ea03a918c558e87e542",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12855",
       "triggerID" : "4a012c2e3fc86b4edf77e95a566ea35647461acb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12940",
       "triggerID" : "83a8c0d8bf7dfd9f105bcd823cd974a21e17cc3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12967",
       "triggerID" : "285dd985152f4496787f8bbabab89a56ef2d3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13070",
       "triggerID" : "a032f3c9e7c93dc725260a909e188e2645dcb98d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13083",
       "triggerID" : "ebbf353f9f3785b17ded961be299271837bcb6c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eba857992a815ed09272098e6846a67d32fe916d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13231",
       "triggerID" : "eba857992a815ed09272098e6846a67d32fe916d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13258",
       "triggerID" : "0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265",
       "triggerID" : "68c3a7c332aded67dac0a6e9804236c2ee30bd15",
       "triggerType" : "PUSH"
     }, {
       "hash" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358",
       "triggerID" : "492082881e55bb077b964e7d700ab1357dc08e17",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0a1f3c81b356d279a5f51cfb70822166e2bb27f0 UNKNOWN
   * 01f8f2423215b4bf3e3bc2b5d96406477f2e535c UNKNOWN
   * 4116335da8cfbe4bf1062ea03a918c558e87e542 UNKNOWN
   * 68c3a7c332aded67dac0a6e9804236c2ee30bd15 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13265) 
   * 492082881e55bb077b964e7d700ab1357dc08e17 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13358) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273565590

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.18182%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.85%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.85%   -0.03%     
   - Complexity    28272    28304      +32     
   ============================================
     Files          2464     2468       +4     
     Lines        135594   135769     +175     
     Branches      16447    16473      +26     
   ============================================
   + Hits          93389    93482      +93     
   - Misses        34815    34885      +70     
   - Partials       7390     7402      +12     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <26.81%> (-0.03%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.90% <50.45%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.69% <45.45%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278217610

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 67.89%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   67.89%   -0.99%     
   + Complexity    28272    27950     -322     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   - Hits          93389    92339    -1050     
   - Misses        34815    36226    +1411     
   - Partials       7390     7445      +55     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <51.76%> (-3.69%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <46.90%> (+0.11%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.93% <100.00%> (-1.56%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4278260648

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `54.42478%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa562f8`](https://app.codecov.io/gh/apache/hudi/commit/aa562f8015ebdf4972ca2db62de73691d7ccce1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   68.82%   -0.05%     
   - Complexity    28272    28361      +89     
   ============================================
     Files          2464     2470       +6     
     Lines        135594   136010     +416     
     Branches      16447    16506      +59     
   ============================================
   + Hits          93389    93614     +225     
   - Misses        34815    34981     +166     
   - Partials       7390     7415      +25     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <28.76%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <30.30%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.36% <25.11%> (-0.06%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <51.76%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.70% <46.90%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.15% <21.68%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4273324169

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.18182%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.42%. Comparing base ([`3d0ab80`](https://app.codecov.io/gh/apache/hudi/commit/3d0ab800de5ea2e476e014d93bc4f70a247d2baf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4920828`](https://app.codecov.io/gh/apache/hudi/commit/492082881e55bb077b964e7d700ab1357dc08e17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.87%   66.42%   -2.45%     
   + Complexity    28272    22953    -5319     
   ============================================
     Files          2464     2012     -452     
     Lines        135594   112745   -22849     
     Branches      16447    14331    -2116     
   ============================================
   - Hits          93389    74893   -18496     
   + Misses        34815    31317    -3498     
   + Partials       7390     6535     -855     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.72% <28.12%> (-0.05%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <22.96%> (-0.07%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <50.45%> (-0.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.69% <45.45%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <20.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `92.59% <100.00%> (+11.64%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [805 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3108328426


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3736,6 +3737,36 @@ protected void setDefaults() {
       autoAdjustConfigsForConcurrencyMode(isLockProviderPropertySet);
     }
 
+    // Class name referenced by string so hudi-client-common does not depend on hudi-spark-client.
+    private static final String DEFAULT_SPARK_RECORD_MERGER_CLASS = "org.apache.hudi.DefaultSparkRecordMerger";
+
+    /**
+     * When the table's base file format requires SPARK record type (e.g. Lance) but the user
+     * has not configured a Spark-compatible record merger, inject
+     * {@link #DEFAULT_SPARK_RECORD_MERGER_CLASS} into {@link HoodieWriteConfig#RECORD_MERGE_IMPL_CLASSES}
+     * so every downstream consumer — write handles, file readers, and metadata writers — observes
+     * a SPARK-typed merger consistently. This removes the usability gap where users had to set
+     * the merger override manually for every Lance table.
+     */
+    private void autoSelectSparkRecordMergerForBaseFileFormat() {
+      HoodieFileFormat tableLevel = HoodieFileFormat.getValue(writeConfig.getString(HoodieTableConfig.BASE_FILE_FORMAT.key()));
+      HoodieFileFormat format = tableLevel != null ? tableLevel : writeConfig.getBaseFileFormat();
+      if (format == null || !format.requiresSparkRecordType()) {
+        return;
+      }
+      if (engineType != EngineType.SPARK) {
+        throw new HoodieNotSupportedException(format + " base file format requires the SPARK engine");
+      }
+      // Only inject when the user has not explicitly configured any merger class. A user who
+      // knowingly picks a non-Spark merger for a Spark-only format will still fail fast at
+      // write time — that's a deliberate choice, not a usability gap.
+      String currentMergers = writeConfig.getString(RECORD_MERGE_IMPL_CLASSES);
+      if (!StringUtils.isNullOrEmpty(currentMergers)) {
+        return;
+      }
+      writeConfig.setValue(RECORD_MERGE_IMPL_CLASSES, DEFAULT_SPARK_RECORD_MERGER_CLASS);
+    }

Review Comment:
   Good catch — added `LANCE` to the `withValidValues(...)` list in aa562f8015eb.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3035475848


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceRecordReader.java:
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.config.HoodieConfig;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
+import org.apache.hudi.io.storage.HoodieFileReader;
+import org.apache.hudi.io.storage.HoodieIOFactory;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Writable;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+
+import java.io.IOException;
+
+import static org.apache.hudi.common.util.ConfigUtils.getReaderConfigs;
+import static org.apache.hudi.hadoop.fs.HadoopFSUtils.convertToStoragePath;
+
+public class HoodieLanceRecordReader implements RecordReader<NullWritable, ArrayWritable> {
+
+  private long count = 0;
+  private final ArrayWritable valueObj;
+  private HoodieFileReader reader;
+  private ClosableIterator<HoodieRecord<IndexedRecord>> recordIterator;
+  private final HoodieSchema schema;
+
+  public HoodieLanceRecordReader(Configuration conf, InputSplit split, JobConf job) throws IOException {
+    FileSplit fileSplit = (FileSplit) split;
+    StoragePath path = convertToStoragePath(fileSplit.getPath());
+    StorageConfiguration<?> storageConf = HadoopFSUtils.getStorageConf(conf);
+    HoodieConfig hoodieConfig = getReaderConfigs(storageConf);
+    reader = HoodieIOFactory.getIOFactory(HoodieStorageUtils.getStorage(path, storageConf)).getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
+        .getFileReader(hoodieConfig, path, HoodieFileFormat.LANCE, Option.empty());
+
+    schema = reader.getSchema();
+    valueObj = new ArrayWritable(Writable.class, new Writable[schema.getFields().size()]);
+  }
+
+  @Override
+  public boolean next(NullWritable key, ArrayWritable value) throws IOException {
+    if (recordIterator == null) {
+      recordIterator = reader.getRecordIterator(schema);
+    }
+
+    if (!recordIterator.hasNext()) {
+      return false;
+    }
+
+    IndexedRecord record = recordIterator.next().getData();
+    ArrayWritable aWritable = (ArrayWritable) HoodieRealtimeRecordReaderUtils.avroToArrayWritable(record, schema.toAvroSchema());
+    value.set(aWritable.get());
+    count++;
+    return true;
+  }
+
+  @Override
+  public NullWritable createKey() {
+    return null;
+  }
+
+  @Override
+  public ArrayWritable createValue() {
+    return valueObj;
+  }
+
+  @Override
+  public long getPos() throws IOException {
+    // TODO Auto-generated method stub
+    return 0;
+  }
+
+  @Override
+  public void close() throws IOException {
+    if (reader != null) {

Review Comment:
   fixed. And also fixed the same issue in HoodieHFileRecordReader.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.

yihua commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3126611595


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +403,45 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Use the schema-aware constructHoodieRecord overload so existingRecordContext
+    // can register the schema locally and resolve it for SPARK records.
+    HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+    HoodieRecord<R> result = mergedSchema != null
+        ? existingRecordContext.constructHoodieRecord(mergeResult, partitionPath, mergedSchema)
+        : existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
     HoodieRecord<R> withMeta = result.prependMetaFields(writeSchema, writeSchemaWithMetaFields,
         new MetadataValues().setRecordKey(incoming.getRecordKey()).setPartitionPath(partitionPath), properties);
     return Option.of(withMeta.wrapIntoHoodieRecordPayloadWithParams(writeSchemaWithMetaFields, properties, Option.empty(),
         config.allowOperationMetadataField(), Option.empty(), false, Option.of(writeSchema)));
   }
 
   private static <R> String inferPartitionPath(HoodieRecord<R> incoming, HoodieRecord<R> existing, HoodieSchema recordSchema, BaseKeyGenerator keyGenerator,
-                                               RecordContext<R> recordContext, BufferedRecord<R> resultingBufferedRecord) {
-    R record = resultingBufferedRecord.getRecord();
-    if (record == incoming.getData()) {
+                                               RecordContext<R> existingRecordContext, BufferedRecord<R> resultingBufferedRecord,
+                                               BufferedRecord<R> incomingBufferedRecord, BufferedRecord<R> existingBufferedRecord,
+                                               RecordContext<R> incomingRecordContext) {
+    // Compare by BufferedRecord identity first: for payload-based records (e.g. ExpressionPayload),
+    // incoming.getData() is the payload object, not the InternalRow extracted from it, so data-identity
+    // checks would incorrectly fall through to the schema-based conversion path.
+    if (resultingBufferedRecord == incomingBufferedRecord || resultingBufferedRecord.getRecord() == incoming.getData()) {
       return incoming.getPartitionPath();
-    } else if (record == existing.getData()) {
+    } else if (resultingBufferedRecord == existingBufferedRecord || resultingBufferedRecord.getRecord() == existing.getData()) {
       return existing.getPartitionPath();
     } else {
-      // the merged record is not the same as either incoming or existing, so we need to compute the partition path
-      return keyGenerator.getPartitionPath(recordContext.convertToAvroRecord(record, recordSchema));
+      // The merged record is genuinely new (e.g. created by HoodieAvroRecordMerger.merge).
+      // Its InternalRow was produced and its schemaId was encoded by incomingRecordContext,
+      // so use incomingRecordContext with the record's actual schema (which may be the data schema,
+      // without meta fields) rather than existingRecordContext with writeSchemaWithMetaFields.
+      HoodieSchema actualSchema = incomingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);
+      if (actualSchema == null) {
+        actualSchema = existingRecordContext.getSchemaFromBufferRecord(resultingBufferedRecord);
+      }
+      if (actualSchema == null) {
+        actualSchema = recordSchema;
+      }
+      return keyGenerator.getPartitionPath(incomingRecordContext.convertToAvroRecord(resultingBufferedRecord, actualSchema));

Review Comment:
   Also, can we add COW support with base upserts in this PR to start with and limit the test parameterization for that as well?  That will make development, reviewing, and issue triaging much easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4247307808

   @yihua can you take one pass of this PR when you get a chance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3082725709


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRecordContext.scala:
##########
@@ -21,25 +21,93 @@ package org.apache.hudi
 
 import org.apache.avro.generic.{GenericRecord, IndexedRecord}
 import org.apache.hudi.common.engine.RecordContext
+import org.apache.hudi.common.model.HoodieRecord
 import org.apache.hudi.common.schema.HoodieSchema
 import org.apache.hudi.common.table.HoodieTableConfig
+import org.apache.hudi.exception.HoodieException
 import org.apache.spark.sql.HoodieInternalRowUtils
 import org.apache.spark.sql.avro.{HoodieAvroDeserializer, HoodieAvroSerializer}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.hudi.SparkAdapter
 
+import java.io.IOException
+import java.util.Properties
 import scala.collection.mutable
 
 trait SparkFileFormatInternalRecordContext extends BaseSparkInternalRecordContext {
 
   lazy val sparkAdapter: SparkAdapter = SparkAdapterSupport.sparkAdapter
   private val deserializerMap: mutable.Map[HoodieSchema, HoodieAvroDeserializer] = mutable.Map()
   private val serializerMap: mutable.Map[HoodieSchema, HoodieAvroSerializer] = mutable.Map()
+  // Maps InternalRow instances (by identity) to their original Avro records when the Avro record's
+  // schema differs from the BufferedRecord schema. This handles ExpressionPayload records whose
+  // getInsertValue result carries the data schema (no meta fields) while the BufferedRecord
+  // stores writeSchemaWithMetaFields. Returning the original Avro record from convertToAvroRecord
+  // lets ExpressionPayload.combineAndGetUpdateValue decode bytes with the correct data schema.
+  //
+  // IMPORTANT INVARIANT: The identity link between InternalRow and GenericRecord must survive
+  // from extractDataFromRecord (where the cache is populated) to convertToAvroRecord (where
+  // it is consumed via remove()). Any operation that replaces the InternalRow object in between
+  // — such as BufferedRecord.seal() (which calls InternalRow.copy()), replaceRecord(), or
+  // project() — would break this link and cause fallback to schema-based serialization.
+  //
+  // Current safety: In the MOR read path (UpdateProcessor.handleNonDeletes), convertToAvroRecord
+  // is called on the original InternalRow BEFORE seal() runs in super.handleNonDeletes().
+  // In the COW write path (HoodieIndexUtils.inferPartitionPath), convertToAvroRecord is similarly
+  // called before any record transformation.
+  // LIFECYCLE: Entries are added in extractDataFromRecord and removed in convertToAvroRecord.
+  // If a record is cached but never reaches convertToAvroRecord (e.g., SENTINEL records that
+  // are filtered out), the entry leaks. This is bounded because: (1) SENTINEL records are rare,
+  // and (2) this instance is scoped to a single FileGroup read and is GC'd afterwards.
+  private val avroRecordByRow: java.util.IdentityHashMap[InternalRow, GenericRecord] =

Review Comment:
   **CRITICAL: IdentityHashMap cache is fragile**
   
   This cache relies on the exact same `InternalRow` Java object surviving from `extractDataFromRecord` to `convertToAvroRecord`. Any intermediate `copy()`, `seal()`, or `project()` silently breaks it. The 20 lines of safety comments (42-61) confirm this fragility.
   
   **Suggestion:** Instead of caching the Avro record by row identity, have `extractDataFromRecord` return the original schema alongside the record (e.g. an `ExtractedData<T>` with a `@Nullable originalSchema` field). Pass it through explicitly — no cache, no flag, no identity dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3069732092


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -70,6 +70,22 @@ public String getFileExtension() {
     return extension;
   }
 
+  /**
+   * Returns true if this file format requires the SPARK record type for reading/writing.
+   * Lance only supports the Spark-native InternalRow representation, not Avro.
+   */
+  public boolean requiresSparkRecordType() {
+    return this == LANCE;
+  }
+
+  /**

Review Comment:
   **[High]** `resolveRecordType()` fixes the I/O layer (reader/writer factory selection), but every test still must manually set `hoodie.write.record.merge.custom.implementation.classes=DefaultSparkRecordMerger` because the **merger** is selected at config init time before file format is known.
   
   This creates a usability gap — users who set `baseFileFormat=LANCE` but forget the merger property will hit a confusing runtime error. Could the merger selection logic (`HoodieRecordUtils.createRecordMerger`) also consult the table's base file format and auto-select a Spark merger when Lance is configured? That would make `resolveRecordType` a complete solution rather than a partial one.
   
   Note: for the above I am ok with filling this as a github followup issue, as I think we will want to change this requirement of passing `DefaultSparkRecordMerger` at some point for Lance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.

rahil-c commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4232006077

   **[High] Recommend splitting ExpressionPayload merge fixes into a separate PR**
   
   The changes to `UpdateProcessor.handleNonDeletes`, `HoodieIndexUtils.inferPartitionPath`, and `SparkFileFormatInternalRecordContext` are not Lance-specific — they affect Parquet and HFile equally. `ExpressionPayload` is used by `MERGE INTO` for all file formats, `UpdateProcessor` runs for all MOR reads, and `SparkFileFormatInternalRecordContext` is the shared trait used by the Parquet reader context too.
   
   Recommend splitting into:
   - **PR A (low risk):** Lance InputFormat plumbing + record type resolution + misc fixes
   - **PR B (higher risk):** ExpressionPayload merge fixes — needs dedicated Parquet `MERGE INTO` test coverage and makes regressions easier to bisect
   
   With just PR A, these would work end-to-end:
   - `CREATE TABLE`
   - `CTAS` (CREATE TABLE AS SELECT)
   - `INSERT INTO`
   - `SELECT` / read queries
   - `count(*)`
   
   And then for the remaining issues we can follow up in PR B:
   - **`MERGE INTO`** — uses `ExpressionPayload`, needs the Layer 3 fixes
   - **`UPDATE` / `DELETE` on COW** — the `inferPartitionPath` fix is needed when the merged record isn't identity-equal to incoming or existing. The PR's own comment explains: *"for payload-based records, `incoming.getData()` is the payload object, not the InternalRow"* — so the identity check falls through to the schema conversion path, which breaks without the fix
   - **MOR snapshot reads after updates** — `UpdateProcessor.handleNonDeletes` is needed to correctly process payload-based records during log file merging
   
   
   Note: @yihua @wombatu-kun Let me know if this split would work rather than doing this in one PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4234883867

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `24.29379%` with `134 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.87%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 22.22% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 13.04% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 42.10% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 66.66% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (eba8579). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (eba8579) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   53.87%   -14.66%     
   + Complexity    27968    12281    -15687     
   =============================================
     Files          2440     1428     -1012     
     Lines        134456    71054    -63402     
     Branches      16226     8021     -8205     
   =============================================
   - Hits          92138    38281    -53857     
   + Misses        35054    29348     -5706     
   + Partials       7264     3425     -3839     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `60.00% <100.00%> (-29.50%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `73.17% <100.00%> (-12.02%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `80.61% <90.90%> (-9.31%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <66.66%> (+4.23%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1788 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4234963247

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `34.57447%` with `123 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 61.31%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eba8579`](https://app.codecov.io/gh/apache/hudi/commit/eba857992a815ed09272098e6846a67d32fe916d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 29 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 34.78% | [13 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 70.37% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 63.15% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (eba8579). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (eba8579) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   61.31%   -7.22%     
   + Complexity    27968    25063    -2905     
   ============================================
     Files          2440     2462      +22     
     Lines        134456   135248     +792     
     Branches      16226    16401     +175     
   ============================================
   - Hits          92138    82922    -9216     
   - Misses        35054    45337   +10283     
   + Partials       7264     6989     -275     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.49% <20.74%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <22.66%> (-0.22%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <19.20%> (-0.01%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.32% <19.14%> (-16.45%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <30.85%> (-13.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <17.55%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | `81.70% <100.00%> (-3.48%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `87.27% <90.90%> (-2.64%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-69.63%)` | :arrow_down: |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `85.18% <66.66%> (+4.23%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `58.82% <0.00%> (-32.09%)` | :arrow_down: |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [622 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4250279860

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `47.41784%` with `112 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.00%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0964e8a`](https://app.codecov.io/gh/apache/hudi/commit/0964e8ad34e47bef4ae25aa2ec1155a11aac4e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 32 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 69.56% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 81.81% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   64.00%   -4.52%     
   + Complexity    27968    26249    -1719     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135373     +917     
     Branches      16226    16407     +181     
   ============================================
   - Hits          92138    86651    -5487     
   - Misses        35054    41326    +6272     
   - Partials       7264     7396     +132     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.57%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <31.01%> (-0.21%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.74%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.37% <24.88%> (-16.41%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <45.07%> (-0.45%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.80% <100.00%> (-5.69%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [562 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251980480

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.82%   +0.29%     
   - Complexity    27968    28231     +263     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   + Hits          92138    93172    +1034     
   + Misses        35054    34823     -231     
   - Partials       7264     7386     +122     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.91% <46.15%> (+0.13%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <45.24%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251752429

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `47.51131%` with `116 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.87%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (68c3a7c). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (68c3a7c) |
   >|------|------|------|
   >|spark-scala-tests|10|6|
   >|spark-java-tests|15|5|
   >|common-and-other-modules|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.52%   60.87%   -7.66%     
   + Complexity    27968    20675    -7293     
   ============================================
     Files          2440     2008     -432     
     Lines        134456   112357   -22099     
     Branches      16226    14268    -1958     
   ============================================
   - Hits          92138    68394   -23744     
   - Misses        35054    37155    +2101     
   + Partials       7264     6808     -456     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <23.98%> (-16.41%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <45.24%> (-0.45%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.22% <100.00%> (-11.69%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `75.55% <100.00%> (-13.94%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `54.43% <100.00%> (-15.19%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1235 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251795754

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.59%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.59%   +0.07%     
   - Complexity    27968    28098     +130     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   + Hits          92138    92868     +730     
   - Misses        35054    35217     +163     
   - Partials       7264     7296      +32     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <46.15%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.45% <45.24%> (-0.20%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [158 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3084659163


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -396,24 +401,51 @@ private static <R> Option<HoodieRecord<R>> mergeIncomingWithExistingRecordWithEx
     }
 
     //record is inserted or updated
-    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
-    HoodieRecord<R> result = existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+    String partitionPath = inferPartitionPath(incoming, existing, writeSchemaWithMetaFields, keyGenerator,
+        existingRecordContext, mergeResult, incomingBufferedRecord, existingBufferedRecord, incomingRecordContext);
+    // When HoodieAvroRecordMerger creates a genuinely new BufferedRecord, it encodes the schema into
+    // incomingRecordContext. Re-encode into existingRecordContext so constructHoodieRecord (which uses
+    // existingRecordContext for the correct payload class) can resolve the schema for SPARK records.
+    BufferedRecord<R> mergeResultForConstruct = mergeResult;
+    if (mergeResult != incomingBufferedRecord && mergeResult != existingBufferedRecord) {
+      HoodieSchema mergedSchema = incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+      if (mergedSchema != null && existingRecordContext.getSchemaFromBufferRecord(mergeResult) == null) {
+        mergeResultForConstruct = BufferedRecords.fromEngineRecord(
+            mergeResult.getRecord(), mergeResult.getRecordKey(), mergedSchema,
+            existingRecordContext, Arrays.asList(orderingFieldNames), mergeResult.getHoodieOperation());
+      }
+    }

Review Comment:
   Implemented exactly as you suggested in 0964e8ad34e4. Added `RecordContext.constructHoodieRecord(BufferedRecord<T>, String partitionPath, HoodieSchema schema)` that registers the schema locally and creates a thin wrapper with a locally-valid `schemaId` (preserving recordKey, orderingValue, hoodieOperation, and `originalAvroRecord`). The 8-line `fromEngineRecord` block in `HoodieIndexUtils` collapsed to a single ternary call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.

wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3085931695


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieLanceInputFormat.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop;
+
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils;
+
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
+
+import java.io.IOException;
+
+/**
+ * HoodieInputFormat for HUDI datasets which store data in Lance base file format.
+ */
+@UseFileSplitsFromInputFormat
+public class HoodieLanceInputFormat extends HoodieCopyOnWriteTableInputFormat {
+
+  protected HoodieTimeline filterInstantsTimeline(HoodieTimeline timeline) {
+    return HoodieInputFormatUtils.filterInstantsTimeline(timeline);
+  }
+
+  @Override
+  public RecordReader<NullWritable, ArrayWritable> getRecordReader(final InputSplit split, final JobConf job,
+      final Reporter reporter) throws IOException {
+    return new HoodieLanceRecordReader(conf, split, job);
+  }

Review Comment:
   Good catch — fixed in 68c3a7c. `HoodieLanceRealtimeInputFormat` composes this InputFormat without calling `setConf()`, so the inherited `conf` was indeed null there. Switched to the non-null `job` parameter, which also matches what `HoodieLanceRecordReader` uses to initialise its `StorageConfiguration`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251704126

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `47.51131%` with `116 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 56.09%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (35e2bbf) and HEAD (68c3a7c). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (35e2bbf) | HEAD (68c3a7c) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.52%   56.09%   -12.44%     
   + Complexity    27968    18807     -9161     
   =============================================
     Files          2440     1991      -449     
     Lines        134456   110012    -24444     
     Branches      16226    13767     -2459     
   =============================================
   - Hits          92138    61711    -30427     
   - Misses        35054    42140     +7086     
   + Partials       7264     6161     -1103     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <23.98%> (-15.99%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.27% <45.24%> (+0.62%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.22% <100.00%> (-11.69%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `74.28% <100.00%> (-15.21%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `54.43% <100.00%> (-15.19%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1361 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4251821525

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `52.94118%` with `104 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.59%. Comparing base ([`35e2bbf`](https://app.codecov.io/gh/apache/hudi/commit/35e2bbf9813f313006c773b92578db6cb93da9ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`68c3a7c`](https://app.codecov.io/gh/apache/hudi/commit/68c3a7c332aded67dac0a6e9804236c2ee30bd15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 35 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...adoop/realtime/HoodieLanceRealtimeInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Frealtime%2FHoodieLanceRealtimeInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUxhbmNlUmVhbHRpbWVJbnB1dEZvcm1hdC5qYXZh) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 33.33% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | 25.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 68.00% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/hadoop/HoodieLanceInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlSW5wdXRGb3JtYXQuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   + Coverage     68.52%   68.59%   +0.07%     
   - Complexity    27968    28099     +131     
   ============================================
     Files          2440     2464      +24     
     Lines        134456   135381     +925     
     Branches      16226    16410     +184     
   ============================================
   + Hits          92138    92871     +733     
   - Misses        35054    35216     +162     
   - Partials       7264     7294      +30     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <29.41%> (+0.19%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <31.08%> (-0.14%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.41% <25.71%> (+0.03%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <46.15%> (+0.03%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.45% <45.24%> (-0.20%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.19% <22.62%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.52% <100.00%> (+0.03%)` | :arrow_up: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.17% <100.00%> (+0.26%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `73.52% <100.00%> (+1.65%)` | :arrow_up: |
   | ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [159 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4402950633

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `63.06818%` with `65 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.49%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6322077`](https://app.codecov.io/gh/apache/hudi/commit/632207766a3333a7db222f08b53808a32d7e016e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 82.35% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 91.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   65.49%   -2.60%     
   + Complexity    28940    23554    -5386     
   ============================================
     Files          2519     2051     -468     
     Lines        140646   117301   -23345     
     Branches      17427    15252    -2175     
   ============================================
   - Hits          95757    76822   -18935     
   + Misses        37030    33504    -3526     
   + Partials       7859     6975     -884     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <40.00%> (+0.02%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.33% <31.09%> (-0.11%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.95% <60.22%> (+0.31%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <40.34%> (+0.12%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.62% <28.40%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.03% <100.00%> (-1.64%)` | :arrow_down: |
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (-0.87%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `76.47% <100.00%> (+1.47%)` | :arrow_up: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.73%)` | :arrow_down: |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `91.66% <100.00%> (-0.23%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...a/org/apache/hudi/common/engine/ExtractedData.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FExtractedData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9FeHRyYWN0ZWREYXRhLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `89.47% <100.00%> (ø)` | |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `83.33% <100.00%> (-2.39%)` | :arrow_down: |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [831 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393939099

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.49%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   > :exclamation:  There is a different number of reports uploaded between BASE (4d0e9cd) and HEAD (fd85491). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (4d0e9cd) | HEAD (fd85491) |
   >|------|------|------|
   >|spark-scala-tests|12|4|
   >|spark-java-tests|18|2|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18375       +/-   ##
   =============================================
   - Coverage     68.08%   48.49%   -19.59%     
   + Complexity    28940    16554    -12386     
   =============================================
     Files          2519     1999      -520     
     Lines        140646   112014    -28632     
     Branches      17427    14126     -3301     
   =============================================
   - Hits          95757    54325    -41432     
   - Misses        37030    51938    +14908     
   + Partials       7859     5751     -2108     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.22% <23.88%> (-15.42%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <40.55%> (-11.98%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `71.42% <100.00%> (-18.07%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `67.24% <100.00%> (-18.73%)` | :arrow_down: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `72.91% <100.00%> (-12.80%)` | :arrow_down: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `82.60% <100.00%> (-8.31%)` | :arrow_down: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.83% <90.90%> (-5.85%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [1579 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(lance): Ensure Spark-SQL works correctly when using lance as base file format [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #18375:
URL: https://github.com/apache/hudi/pull/18375#issuecomment-4393970031

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.77778%` with `103 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.90%. Comparing base ([`4d0e9cd`](https://app.codecov.io/gh/apache/hudi/commit/4d0e9cd47f9e70564dee2ea0718f8272d8eb4df4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd85491`](https://app.codecov.io/gh/apache/hudi/commit/fd85491409dc0f33b0d8586a2a229266017ef403?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/hadoop/HoodieLanceRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieLanceRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUxhbmNlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/hudi/common/engine/RecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fengine%2FRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9SZWNvcmRDb250ZXh0LmphdmE=) | 20.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ution/datasources/lance/SparkLanceReaderBase.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fdatasources%2Flance%2FSparkLanceReaderBase.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL2V4ZWN1dGlvbi9kYXRhc291cmNlcy9sYW5jZS9TcGFya0xhbmNlUmVhZGVyQmFzZS5zY2FsYQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/hudi/SparkFileFormatInternalRecordContext.scala](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FSparkFileFormatInternalRecordContext.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL1NwYXJrRmlsZUZvcm1hdEludGVybmFsUmVjb3JkQ29udGV4dC5zY2FsYQ==) | 23.07% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 52.94% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/common/table/read/UpdateProcessor.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FUpdateProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvVXBkYXRlUHJvY2Vzc29yLmphdmE=) | 66.66% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...torage/row/HoodieInternalRowFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieInternalRowFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllSW50ZXJuYWxSb3dGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/hadoop/HoodieHFileRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieHFileRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUhGaWxlUmVjb3JkUmVhZGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...org/apache/hudi/common/model/HoodieFileFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | 42.85% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ache/hudi/common/model/HoodieAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUF2cm9SZWNvcmRNZXJnZXIuamF2YQ==) | 0.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18375      +/-   ##
   ============================================
   - Coverage     68.08%   64.90%   -3.18%     
   + Complexity    28940    27613    -1327     
   ============================================
     Files          2519     2521       +2     
     Lines        140646   140800     +154     
     Branches      17427    17445      +18     
   ============================================
   - Hits          95757    91387    -4370     
   - Misses        37030    41526    +4496     
   - Partials       7859     7887      +28     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <36.11%> (-0.02%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <40.26%> (-0.04%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <31.54%> (-0.04%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <23.88%> (-17.00%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.15% <40.55%> (-0.61%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.66% <27.22%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.07% <100.00%> (-4.42%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/avro/AvroRecordContext.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Favro%2FAvroRecordContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9BdnJvUmVjb3JkQ29udGV4dC5qYXZh) | `86.20% <100.00%> (+0.24%)` | :arrow_up: |
   | [...common/model/HoodiePreCombineAvroRecordMerger.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodiePreCombineAvroRecordMerger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZVByZUNvbWJpbmVBdnJvUmVjb3JkTWVyZ2VyLmphdmE=) | `57.89% <100.00%> (-31.58%)` | :arrow_down: |
   | [.../apache/hudi/common/table/read/BufferedRecord.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecord.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmQuamF2YQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
   | [...apache/hudi/common/table/read/BufferedRecords.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FBufferedRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvQnVmZmVyZWRSZWNvcmRzLmphdmE=) | `91.30% <100.00%> (+0.39%)` | :arrow_up: |
   | [...pache/hudi/io/storage/HoodieFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVGaWxlV3JpdGVyRmFjdG9yeS5qYXZh) | `70.58% <100.00%> (-1.29%)` | :arrow_down: |
   | [...ache/hudi/hadoop/utils/HoodieInputFormatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2Futils%2FHoodieInputFormatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3V0aWxzL0hvb2RpZUlucHV0Rm9ybWF0VXRpbHMuamF2YQ==) | `60.82% <ø> (-9.28%)` | :arrow_down: |
   | [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.45% <90.90%> (-1.22%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/io/HoodieReadHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieReadHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVJlYWRIYW5kbGUuamF2YQ==) | `75.00% <87.50%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/hudi/pull/18375?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [396 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org