You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/06/10 03:10:00 UTC
Review Request 35281: Added QoS module loader to ::create() factory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
Bugs: MESOS-2703
https://issues.apache.org/jira/browse/MESOS-2703
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
Diff: https://reviews.apache.org/r/35281/diff/
Testing
-------
make check
Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
Thanks,
Niklas Nielsen
Re: Review Request 35281: Added QoS module loader to ::create()
factory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/#review87610
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35278, 35279, 35280, 35281]
All tests passed.
- Mesos ReviewBot
On June 11, 2015, 6:55 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35281/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 6:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
>
>
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
>
> Diff: https://reviews.apache.org/r/35281/diff/
>
>
> Testing
> -------
>
> make check
> Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35281: Added QoS module loader to ::create()
factory.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/
-----------------------------------------------------------
(Updated June 11, 2015, 11:55 a.m.)
Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
Bugs: MESOS-2703
https://issues.apache.org/jira/browse/MESOS-2703
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
Diff: https://reviews.apache.org/r/35281/diff/
Testing
-------
make check
Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
Thanks,
Niklas Nielsen
Re: Review Request 35281: Added QoS module loader to ::create()
factory.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/#review87594
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35281/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 1:09 a.m.)
>
>
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
>
>
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
>
> Diff: https://reviews.apache.org/r/35281/diff/
>
>
> Testing
> -------
>
> make check
> Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35281: Added QoS module loader to ::create()
factory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/#review87346
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35278, 35279, 35280, 35281]
All tests passed.
- Mesos ReviewBot
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35281/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 1:09 a.m.)
>
>
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
>
>
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
>
> Diff: https://reviews.apache.org/r/35281/diff/
>
>
> Testing
> -------
>
> make check
> Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35281: Added QoS module loader to ::create()
factory.
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/#review87421
-----------------------------------------------------------
Ship it!
src/slave/qos_controller.cpp
<https://reviews.apache.org/r/35281/#comment139742>
Reorder.
- Bartek Plotka
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35281/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 1:09 a.m.)
>
>
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
>
>
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73
>
> Diff: https://reviews.apache.org/r/35281/diff/
>
>
> Testing
> -------
>
> make check
> Tested new example module manually, since we don't have a good type param'ed test for resource estimator and qos controller yet.
>
>
> Thanks,
>
> Niklas Nielsen
>
>