You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/17 06:02:23 UTC
[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9610: [BUG] fix bug for vectorized compaction
Gabriel39 opened a new pull request, #9610:
URL: https://github.com/apache/incubator-doris/pull/9610
# Proposed changes
Issue Number: close #9604
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r874659756
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -55,7 +55,8 @@ void VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
DCHECK(!rs_readers.empty());
for (auto [c_iter, r_iter] = std::pair {_children.begin(), rs_readers.begin()};
c_iter != _children.end();) {
- if ((*c_iter)->init() != Status::OK()) {
+ auto s = (*c_iter)->init();
+ if (!s.ok() && s.precise_code() != OLAP_ERR_DATA_EOF) {
delete (*c_iter);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r875666791
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -91,6 +103,7 @@ void VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
}
Level1Iterator* cumu_iter = new Level1Iterator(cumu_children, _reader,
cumu_children.size() > 1, _skip_same);
+ RETURN_IF_NOT_EOF_AND_OK(cumu_iter->init());
cumu_iter->init();
std::list<LevelIterator*> children;
Review Comment:
Forgot to remove this line and I did this just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#issuecomment-1128847903
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r875665233
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -91,6 +103,7 @@ void VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
}
Level1Iterator* cumu_iter = new Level1Iterator(cumu_children, _reader,
cumu_children.size() > 1, _skip_same);
+ RETURN_IF_NOT_EOF_AND_OK(cumu_iter->init());
cumu_iter->init();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#issuecomment-1128847866
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r875663771
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -91,6 +103,7 @@ void VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
}
Level1Iterator* cumu_iter = new Level1Iterator(cumu_children, _reader,
cumu_children.size() > 1, _skip_same);
+ RETURN_IF_NOT_EOF_AND_OK(cumu_iter->init());
cumu_iter->init();
std::list<LevelIterator*> children;
Review Comment:
cumu_iter->init(); called twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9610: [BUG] fix bug for vectorized compaction
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r874433661
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -55,7 +55,8 @@ void VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
DCHECK(!rs_readers.empty());
for (auto [c_iter, r_iter] = std::pair {_children.begin(), rs_readers.begin()};
c_iter != _children.end();) {
- if ((*c_iter)->init() != Status::OK()) {
+ auto s = (*c_iter)->init();
+ if (!s.ok() && s.precise_code() != OLAP_ERR_DATA_EOF) {
delete (*c_iter);
Review Comment:
Need to return an error status here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org