You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2020/05/22 16:57:31 UTC

[pulsar] branch master updated: Fix swagger annotations for builtin sources/sinks rest api (#7009)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new e298ccc  Fix swagger annotations for builtin sources/sinks rest api (#7009)
e298ccc is described below

commit e298ccc55143a2dca8bf7b5cae5edbf84bfbd54d
Author: Sanjeev Kulkarni <sa...@gmail.com>
AuthorDate: Fri May 22 09:57:18 2020 -0700

    Fix swagger annotations for builtin sources/sinks rest api (#7009)
    
    Co-authored-by: Sanjeev Kulkarni <sa...@splunk.com>
---
 .../main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java   | 7 ++++---
 .../main/java/org/apache/pulsar/broker/admin/impl/SourcesBase.java | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java
index 416f390..61d3603 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java
@@ -469,8 +469,9 @@ public class SinksBase extends AdminResource implements Supplier<WorkerService>
 
     @GET
     @ApiOperation(
-            value = "Fetches a list of supported Pulsar IO sink connectors currently running in cluster mode",
-            response = List.class
+            value = "Fetches the list of built-in Pulsar IO sinks",
+            response = ConnectorDefinition.class,
+            responseContainer = "List"
     )
     @ApiResponses(value = {
             @ApiResponse(code = 200, message = "Get builtin sinks successfully.")
@@ -489,7 +490,7 @@ public class SinksBase extends AdminResource implements Supplier<WorkerService>
 
     @POST
     @ApiOperation(
-            value = "Reload the available built-in connectors, include Source and Sink",
+            value = "Reload the built-in connectors, including Sources and Sinks",
             response = Void.class
     )
     @ApiResponses(value = {
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SourcesBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SourcesBase.java
index d2ddc9e..aba9069 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SourcesBase.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SourcesBase.java
@@ -455,8 +455,9 @@ public class SourcesBase extends AdminResource implements Supplier<WorkerService
 
     @GET
     @ApiOperation(
-            value = "Fetches a list of supported Pulsar IO source connectors currently running in cluster mode",
-            response = List.class
+            value = "Fetches the list of built-in Pulsar IO sources",
+            response = ConnectorDefinition.class,
+            responseContainer = "List"
     )
     @ApiResponses(value = {
             @ApiResponse(code = 403, message = "The requester doesn't have admin permissions"),
@@ -479,7 +480,7 @@ public class SourcesBase extends AdminResource implements Supplier<WorkerService
 
     @POST
     @ApiOperation(
-            value = "Reload the available built-in connectors, include Source and Sink",
+            value = "Reload the built-in connectors, including Sources and Sinks",
             response = Void.class
     )
     @ApiResponses(value = {