You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ev...@apache.org on 2013/11/19 23:44:21 UTC
git commit: Revert "Refactored QueueApi and pushed name param up to
MarconiApi."
Updated Branches:
refs/heads/master dc452f776 -> c0d9b1c89
Revert "Refactored QueueApi and pushed name param up to MarconiApi."
This reverts commit dc452f77605459921c2bc8a08c3d675a4d9d4bd4.
Turns out you can't implement list messages with this refactoring.
Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/commit/c0d9b1c8
Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/tree/c0d9b1c8
Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/diff/c0d9b1c8
Branch: refs/heads/master
Commit: c0d9b1c892d111b10681093b13ab7c91480b6a6a
Parents: dc452f7
Author: Everett Toews <ev...@rackspace.com>
Authored: Tue Nov 19 16:38:56 2013 -0600
Committer: Everett Toews <ev...@rackspace.com>
Committed: Tue Nov 19 16:38:56 2013 -0600
----------------------------------------------------------------------
.../openstack/marconi/v1/MarconiApi.java | 7 +---
.../openstack/marconi/v1/features/QueueApi.java | 41 +++++++++++++++-----
.../marconi/v1/features/MessageApiLiveTest.java | 8 ++--
.../marconi/v1/features/QueueApiLiveTest.java | 32 +++++++--------
.../marconi/v1/features/QueueApiMockTest.java | 32 +++++++--------
5 files changed, 70 insertions(+), 50 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/blob/c0d9b1c8/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java
----------------------------------------------------------------------
diff --git a/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java b/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java
index 3be40bf..fe4c048 100644
--- a/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java
+++ b/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java
@@ -47,13 +47,10 @@ public interface MarconiApi extends Closeable {
* Provides access to Queue features.
*
* @param zone The zone where this queue will live.
- * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
- * letters, digits, underscores, and hyphens.
*/
@Delegate
- @Path("/queues/{name}")
- QueueApi getQueueApiForZoneAndQueue(
- @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone, @PathParam("name") String name);
+ QueueApi getQueueApiForZone(
+ @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone);
/**
* Provides access to Message features.
http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/blob/c0d9b1c8/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java
----------------------------------------------------------------------
diff --git a/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java b/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java
index 9373cba..c80c610 100644
--- a/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java
+++ b/openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java
@@ -46,29 +46,43 @@ import java.util.Map;
@SkipEncoding({'/', '='})
@RequestFilters(AuthenticateRequest.class)
public interface QueueApi {
+ // TODO: Move name parameter into MarconiApi.getQueueApiForZone(String name, String zone)
+
/**
* Create a queue.
+ *
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
*/
@Named("queue:create")
@PUT
+ @Path("queues/{name}")
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- boolean create();
+ boolean create(@PathParam("name") String name);
/**
* Delete a queue.
+ *
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
*/
@Named("queue:delete")
@DELETE
+ @Path("queues/{name}")
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- boolean delete();
+ boolean delete(@PathParam("name") String name);
/**
* Check for a queue's existence.
+ *
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
*/
@Named("queue:get")
@GET
+ @Path("queues/{name}")
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- boolean exists();
+ boolean exists(@PathParam("name") String name);
// TODO stream method!
@@ -80,34 +94,43 @@ public interface QueueApi {
* This operation replaces any existing metadata document in its entirety. Ensure that you do not accidentally
* overwrite existing metadata that you want to retain.
*
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
* @param metadata Metadata in key/value pairs.
*/
@Named("queue:setMetadata")
@PUT
- @Path("/metadata")
+ @Path("queues/{name}/metadata")
@Produces(MediaType.APPLICATION_JSON)
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- boolean setMetadata(@BinderParam(BindToJsonPayload.class) Map<String, String> metadata);
+ boolean setMetadata(@PathParam("name") String name,
+ @BinderParam(BindToJsonPayload.class) Map<String, String> metadata);
/**
* Gets metadata for the specified queue.
+ *
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
*/
@Named("queue:getMetadata")
@GET
- @Path("/metadata")
+ @Path("queues/{name}/metadata")
@Consumes(MediaType.APPLICATION_JSON)
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- Map<String, String> getMetadata();
+ Map<String, String> getMetadata(@PathParam("name") String name);
/**
* Gets stats for the specified queue.
+ *
+ * @param name Name of the queue. The name must not exceed 64 bytes in length, and it is limited to US-ASCII
+ * letters, digits, underscores, and hyphens.
*/
@Named("queue:getStats")
@GET
- @Path("/stats")
+ @Path("queues/{name}/stats")
@Consumes(MediaType.APPLICATION_JSON)
@ResponseParser(ParseQueueStats.class)
@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
- QueueStats getStats();
+ QueueStats getStats(@PathParam("name") String name);
}
http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/blob/c0d9b1c8/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java
----------------------------------------------------------------------
diff --git a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java
index 68a6c4b..3bfe3e0 100644
--- a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java
+++ b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java
@@ -38,8 +38,8 @@ public class MessageApiLiveTest extends BaseMarconiApiLiveTest {
public void createQueues() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.create();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.create("jclouds-test");
assertTrue(success);
}
@@ -138,8 +138,8 @@ public class MessageApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "streamManyPagesOfMessages" })
public void delete() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.delete();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.delete("jclouds-test");
assertTrue(success);
}
http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/blob/c0d9b1c8/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java
----------------------------------------------------------------------
diff --git a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java
index f232de9..cb3dfa3 100644
--- a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java
+++ b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java
@@ -37,8 +37,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
public void create() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.create();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.create("jclouds-test");
assertTrue(success);
}
@@ -47,8 +47,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "create" })
public void exists() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.exists();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.exists("jclouds-test");
assertTrue(success);
}
@@ -57,9 +57,9 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "exists" })
public void setMetadata() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
Map<String, String> metadata = ImmutableMap.of("key1", "value1");
- boolean success = queueApi.setMetadata(metadata);
+ boolean success = queueApi.setMetadata("jclouds-test", metadata);
assertTrue(success);
}
@@ -68,8 +68,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "setMetadata" })
public void getMetadata() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- Map<String, String> metadata = queueApi.getMetadata();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ Map<String, String> metadata = queueApi.getMetadata("jclouds-test");
assertEquals(metadata.get("key1"), "value1");
}
@@ -78,8 +78,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "getMetadata" })
public void getStatsWithoutTotal() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- QueueStats stats = queueApi.getStats();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ QueueStats stats = queueApi.getStats("jclouds-test");
assertEquals(stats.getMessagesStats().getClaimed(), 0);
assertEquals(stats.getMessagesStats().getFree(), 0);
@@ -101,8 +101,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
messageApi.create(clientId, message);
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- QueueStats stats = queueApi.getStats();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ QueueStats stats = queueApi.getStats("jclouds-test");
assertEquals(stats.getMessagesStats().getClaimed(), 0);
assertEquals(stats.getMessagesStats().getFree(), 1);
@@ -117,8 +117,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "getStatsWithTotal" })
public void delete() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.delete();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.delete("jclouds-test");
assertTrue(success);
}
@@ -127,8 +127,8 @@ public class QueueApiLiveTest extends BaseMarconiApiLiveTest {
@Test(dependsOnMethods = { "delete" })
public void doesNotExist() throws Exception {
for (String zoneId : api.getConfiguredZones()) {
- QueueApi queueApi = api.getQueueApiForZoneAndQueue(zoneId, "jclouds-test");
- boolean success = queueApi.exists();
+ QueueApi queueApi = api.getQueueApiForZone(zoneId);
+ boolean success = queueApi.exists("jclouds-test");
assertFalse(success);
}
http://git-wip-us.apache.org/repos/asf/jclouds-labs-openstack/blob/c0d9b1c8/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java
----------------------------------------------------------------------
diff --git a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java
index 76b0fa2..375f24d 100644
--- a/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java
+++ b/openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java
@@ -45,8 +45,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- boolean success = queueApi.create();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ boolean success = queueApi.create("jclouds-test");
assertTrue(success);
@@ -66,8 +66,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- boolean success = queueApi.delete();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ boolean success = queueApi.delete("jclouds-test");
assertTrue(success);
@@ -87,8 +87,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- boolean success = queueApi.exists();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ boolean success = queueApi.exists("jclouds-test");
assertTrue(success);
@@ -108,8 +108,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-blerg");
- boolean success = queueApi.exists();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ boolean success = queueApi.exists("jclouds-blerg");
assertFalse(success);
@@ -129,9 +129,9 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
Map<String, String> metadata = ImmutableMap.of("key1", "value1");
- boolean success = queueApi.setMetadata(metadata);
+ boolean success = queueApi.setMetadata("jclouds-test", metadata);
assertTrue(success);
@@ -153,8 +153,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- Map<String, String> metadata = queueApi.getMetadata();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ Map<String, String> metadata = queueApi.getMetadata("jclouds-test");
assertEquals(metadata.get("key1"), "value1");
@@ -175,8 +175,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- QueueStats stats = queueApi.getStats();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ QueueStats stats = queueApi.getStats("jclouds-test");
assertEquals(stats.getMessagesStats().getClaimed(), 0);
assertEquals(stats.getMessagesStats().getFree(), 0);
@@ -201,8 +201,8 @@ public class QueueApiMockTest extends BaseOpenStackMockTest<MarconiApi> {
try {
MarconiApi api = api(server.getUrl("/").toString(), "openstack-marconi");
- QueueApi queueApi = api.getQueueApiForZoneAndQueue("DFW", "jclouds-test");
- QueueStats stats = queueApi.getStats();
+ QueueApi queueApi = api.getQueueApiForZone("DFW");
+ QueueStats stats = queueApi.getStats("jclouds-test");
assertEquals(stats.getMessagesStats().getClaimed(), 0);
assertEquals(stats.getMessagesStats().getFree(), 4);