You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/14 17:12:01 UTC
[GitHub] [pinot] walterddr opened a new pull request, #9794: [multistage] expand test framework features
walterddr opened a new pull request, #9794:
URL: https://github.com/apache/pinot/pull/9794
- allow multiple SQLs to run at the same table input setup
- allow output checkers, so we don't need to load data into H2 if not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9794:
URL: https://github.com/apache/pinot/pull/9794#issuecomment-1314197748
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9794](https://codecov.io/gh/apache/pinot/pull/9794?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75c26e5) into [master](https://codecov.io/gh/apache/pinot/commit/dc49b2cbb104df0f3e5d97a26130bfad5f665188?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc49b2c) will **increase** coverage by `6.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #9794 +/- ##
============================================
+ Coverage 64.08% 70.19% +6.10%
- Complexity 4970 5408 +438
============================================
Files 1903 1956 +53
Lines 102553 104975 +2422
Branches 15605 15892 +287
============================================
+ Hits 65722 73687 +7965
+ Misses 32062 26142 -5920
- Partials 4769 5146 +377
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `25.31% <ø> (?)` | |
| integration2 | `24.55% <ø> (?)` | |
| unittests1 | `67.76% <ø> (+0.06%)` | :arrow_up: |
| unittests2 | `15.70% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ore/query/scheduler/resources/ResourceManager.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvcmVzb3VyY2VzL1Jlc291cmNlTWFuYWdlci5qYXZh) | `84.00% <0.00%> (-12.00%)` | :arrow_down: |
| [.../pinot/core/query/scheduler/PriorityScheduler.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvUHJpb3JpdHlTY2hlZHVsZXIuamF2YQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `77.41% <0.00%> (-3.23%)` | :arrow_down: |
| [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `77.48% <0.00%> (-2.62%)` | :arrow_down: |
| [.../pinot/core/data/manager/BaseTableDataManager.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvQmFzZVRhYmxlRGF0YU1hbmFnZXIuamF2YQ==) | `75.44% <0.00%> (-0.39%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `88.10% <0.00%> (-0.28%)` | :arrow_down: |
| [.../assignment/segment/RealtimeSegmentAssignment.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZVNlZ21lbnRBc3NpZ25tZW50LmphdmE=) | `92.47% <0.00%> (-0.09%)` | :arrow_down: |
| [...core/query/reduce/ExplainPlanDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRXhwbGFpblBsYW5EYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `82.99% <0.00%> (ø)` | |
| [...pache/pinot/plugin/metrics/yammer/YammerMeter.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1tZXRyaWNzL3Bpbm90LXlhbW1lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL21ldHJpY3MveWFtbWVyL1lhbW1lck1ldGVyLmphdmE=) | `55.55% <0.00%> (ø)` | |
| [.../helix/IngestionBasedConsumptionStatusChecker.java](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9Jbmdlc3Rpb25CYXNlZENvbnN1bXB0aW9uU3RhdHVzQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [437 more](https://codecov.io/gh/apache/pinot/pull/9794/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
walterddr commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1021860041
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,40 @@
+{
+ "special_syntax": {
+ "description": "test special syntax that cannot be supported by reference engine",
+ "sql": [
+ "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col1)",
+ "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col2)"
+ ],
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
+ ["foo", "alice", 1],
+ ["bar", "bob", 2]
+ ],
+ "tbl2": [
+ ["foo", "bob", 3],
+ ["alice", "alice", 4]
+ ]
+ },
+ "outputs": [
+ [
+ ["foo", 3]
+ ],
+ [
+ ["bar", 3],
+ ["foo", 4]
+ ]
+ ]
+ }
+}
Review Comment:
```suggestion
}
```
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -257,13 +257,15 @@ private static List<String> toH2FieldNamesAndTypes(org.apache.pinot.spi.data.Sch
public static class QueryTestCase {
@JsonProperty("sql")
- public String _sql;
+ public List<String> _sql;
Review Comment:
got it. let me try to remodel (best do it first, otherwise need lots of json refactoring later)
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,40 @@
+{
+ "special_syntax": {
+ "description": "test special syntax that cannot be supported by reference engine",
Review Comment:
```suggestion
"special_join_syntax": {
"description": "test special join syntax that cannot be supported by reference H2 engine",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] agavra commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
agavra commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1021916211
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -257,13 +257,15 @@ private static List<String> toH2FieldNamesAndTypes(org.apache.pinot.spi.data.Sch
public static class QueryTestCase {
@JsonProperty("sql")
- public String _sql;
+ public List<String> _sql;
Review Comment:
suggestion: I think it might be better to model it like:
```
{
"tables": [..],
"inputs": {...},
"tests": [
{
"description": "",
"sql": "...",
"outputs": [...]
},
{
"description": "",
"sql": "...",
"outputs": [...]
}
]
}
```
I think that'll be much easier to handle (both in the code and when we want to make changes going forward). I also don't know how that shows up in IntelliJ - but this will make it clear that every element within `tests` is a single test case in TestNG. It also lets us have the same setup where part of it uses H2 and others don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
walterddr commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022063405
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
+ ["foo", "alice", 1],
+ ["bar", "bob", 2]
+ ],
+ "tbl2": [
+ ["foo", "bob", 3],
+ ["alice", "alice", 4]
+ ]
+ },
+ "queries": [
+ {
+ "description": "test join with using clause",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col1)",
+ "outputs": [
+ ["foo", 3]
+ ]
+ },
+ {
+ "description": "test join with using clause but join with columns not being selected",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col2)",
+ "outputs": [
Review Comment:
yeah this is a good question. we will add a alias/column reference test json separately to test these
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
Review Comment:
yes
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022063060
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
Review Comment:
This is input rows / data ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
walterddr commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022063082
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
Review Comment:
these are SQL syntax that are not support in H2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022061229
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
Review Comment:
What is meant by special syntax ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022062730
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
Review Comment:
this is input schema ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
walterddr merged PR #9794:
URL: https://github.com/apache/pinot/pull/9794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022060437
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
+ ["foo", "alice", 1],
+ ["bar", "bob", 2]
+ ],
+ "tbl2": [
+ ["foo", "bob", 3],
+ ["alice", "alice", 4]
+ ]
+ },
+ "queries": [
+ {
+ "description": "test join with using clause",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col1)",
+ "outputs": [
+ ["foo", 3]
+ ]
+ },
+ {
+ "description": "test join with using clause but join with columns not being selected",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col2)",
+ "outputs": [
Review Comment:
We may want to assert the output schema as well. Especially the output column names esp if queries are slightly complex (aliases / dot notation etc). Need not be done in this PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9794: [multistage] expand test framework features
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022064349
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
Review Comment:
may be want ?
```
"tables": {
"table1" : {
"schema": {
........
}
"input": {
........
}
}
"table2": {
.........
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org