You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by jiazhai <gi...@git.apache.org> on 2017/06/15 17:38:08 UTC
[GitHub] bookkeeper pull request #192: Issue 191: add template for ISSUE and PR
GitHub user jiazhai opened a pull request:
https://github.com/apache/bookkeeper/pull/192
Issue 191: add template for ISSUE and PR
Following BP-9, provide a template for ISSUE and PR.
When create issue, will use ISSUE template; while create PR will use PR template.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiazhai/bookkeeper-1 issue_191
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
commit aa5d77ecd7936d5219dd64dd24344dabc81702bf
Author: jiazhai <zh...@live.com>
Date: 2017-06-15T17:36:07Z
Issue 191: add template for ISSUE and PR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/192
merging it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #192: Issue 191: add template for ISSUE and PR
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/192
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/192
@sijie for you is ok ? so that we can merge and start using it for new issues/pr ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by jiazhai <gi...@git.apache.org>.
Github user jiazhai commented on the issue:
https://github.com/apache/bookkeeper/pull/192
@sijie Done the fix, excluded .github dir.
Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/192
+1 I will try the new script at #194 againts this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #192: Issue 191: add template for ISSUE and PR
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/192
@jiazhai I think these two files introduced the rate-check warnings. please either exclude them from apache-rat checking or add apache license header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---