Newsgroup admin/filtering (was: Bug 20746)

["Noel J. Bergman" <no...@devtech.com>]

> It maybe be better to not have newsgroups in config.xml. Chages to
> config.xml require restart and repository should know the set of
> news groups in it.

> - Remove newsgroups from config.xml
> - Have commands in admin telnet session to add/remove newsgroups

That's one way.  Possibly the best choice.  If you've time, please do submit
a patch to the remote manager.

This gets back to the question I had raised in January: ''If you delete
newsgroups from config.xml, they are still present unless you delete the
repositories as well.  NNTPRepositoryImpl.getGroups() doesn't know to check
the configuration for valid groups.  We have the information to check
against, but looking at the code for configure(), the variable known as
"addGroups" ... someone knew and didn't document this feature.  Is this
behavior intentional, or should I fix it by filtering out newsgroups that
are not listed in config.xml?''

ref:
http://archives.apache.org/eyebrowse/ReadMsg?listName=james-dev@jakarta.apac
he.org&msgId=601424

I don't know what our users think the list of newsgroups is intended to do.
Certainly, it is not scalable to list all newsgroups in config.xml, not to
mention the issue that you raised.  It has acted as an "add newsgroups", but
I don't know if anyone wanted to use it as a filter.  Considering the bug
report, the author actually prefered the option to use it as a filter.

I've completed the filtering mechanism that Peter started, and made it
conditional.

  <newsgroups [only="FALSE | true"]>

The default is false, since the previous semantic was just a non-intuitive
"add newsgroup" operation.  So far, from my telnet tests, it seems to be
working.

	--- Noel


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org