You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/06 16:26:27 UTC

[GitHub] [guacamole-client] necouchman commented on a change in pull request #471: GUACAMOLE-753: Add TOTP auth method to Docker image

necouchman commented on a change in pull request #471: GUACAMOLE-753: Add TOTP auth method to Docker image
URL: https://github.com/apache/guacamole-client/pull/471#discussion_r375940141
 
 

 ##########
 File path: guacamole-docker/bin/start.sh
 ##########
 @@ -707,6 +722,11 @@ END
     exit 1;
 fi
 
+# Use TOTP if specified.
+if [ -n "$TOTP_ISSUER" ]; then
 
 Review comment:
   Is this the best way to do this?  The `totp-issuer` has a default value, per the manual, so should setting the issuer be what triggers activation of this module?  Or should we go with something like `TOTP_ENABLED`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services