You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "aairey (via GitHub)" <gi...@apache.org> on 2024/08/20 15:21:02 UTC
[PR] chore(docs): add note about Helm Chart [airflow]
aairey opened a new pull request, #41617:
URL: https://github.com/apache/airflow/pull/41617
The Helm Chart does not support both git-sync and persistence to be configured at the same time.
Fixes #27476
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #41617:
URL: https://github.com/apache/airflow/pull/41617#discussion_r1728914520
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -144,6 +144,11 @@ hence Webserver does not need access to DAG files, so ``git-sync`` sidecar is no
Notes for combining git-sync and persistence
............................................
+.. note::
+
+ When using the helm chart, it is not possible to use git-sync and persistence at the same time
Review Comment:
if it's not possible we should change this line too.
`While using both git-sync and persistence for DAGs is possible`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41617: chore(docs): add note about Helm Chart
URL: https://github.com/apache/airflow/pull/41617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #41617:
URL: https://github.com/apache/airflow/pull/41617#issuecomment-2299123687
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "shalberd (via GitHub)" <gi...@apache.org>.
shalberd commented on PR #41617:
URL: https://github.com/apache/airflow/pull/41617#issuecomment-2854041158
@potiuk The content of this PR is completely valid, yet it was never approved and merged. Weird, to say the least.
On the one hand, you demand PRs in #27476, on the other hand, when the user does submit one, it is not taken seriously ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "aairey (via GitHub)" <gi...@apache.org>.
aairey commented on code in PR #41617:
URL: https://github.com/apache/airflow/pull/41617#discussion_r1727646015
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -144,6 +144,11 @@ hence Webserver does not need access to DAG files, so ``git-sync`` sidecar is no
Notes for combining git-sync and persistence
............................................
+.. note::
+
+ When using the helm chart, it is not possible to use git-sync and persistence at the same time
Review Comment:
I believe @mashanm mentioned it is technically not even possible to use both at the same time when using the Helm Chart.
And this is undocumented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41617:
URL: https://github.com/apache/airflow/pull/41617#issuecomment-2495713899
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #41617:
URL: https://github.com/apache/airflow/pull/41617#discussion_r1726592977
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -144,6 +144,11 @@ hence Webserver does not need access to DAG files, so ``git-sync`` sidecar is no
Notes for combining git-sync and persistence
............................................
+.. note::
+
+ When using the helm chart, it is not possible to use git-sync and persistence at the same time
Review Comment:
```suggestion
When using the helm chart, it is not recommended to use git-sync and persistence at the same time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add note about Helm Chart [airflow]
Posted by "shalberd (via GitHub)" <gi...@apache.org>.
shalberd commented on code in PR #41617:
URL: https://github.com/apache/airflow/pull/41617#discussion_r2075172885
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -144,6 +144,11 @@ hence Webserver does not need access to DAG files, so ``git-sync`` sidecar is no
Notes for combining git-sync and persistence
............................................
+.. note::
+
+ When using the helm chart, it is not possible to use git-sync and persistence at the same time
Review Comment:
@aairey changed it accordingly, yet the PR was never merged ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org