You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Dick King (JIRA)" <ji...@apache.org> on 2009/09/15 22:33:57 UTC

[jira] Created: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

rumen makes a task with a null type when one of the task lines is truncated
---------------------------------------------------------------------------

                 Key: MAPREDUCE-986
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
             Project: Hadoop Map/Reduce
          Issue Type: Bug
            Reporter: Dick King
            Assignee: Dick King


Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.

We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755755#action_12755755 ] 

Hong Tang commented on MAPREDUCE-986:
-------------------------------------

{noformat}
-      task.setTaskType(typ);
+      if (!taskAlreadyLogged || typ != null) {
+        task.setTaskType(typ);
+      }
{noformat}
Shouldn't it be just:
{noformat}
-      task.setTaskType(typ);
+      if (typ != null) {
+        task.setTaskType(typ);
+      }
{noformat}
Otherwise, you would still the task type if taskAlreadyLogged==true but typ is null, and then later be ignored.

Also -1 on modifying existing tests to test bug fixes. It'd be better to have a standalone negative test case to test this logic instead of piggybacking the testing with another test.

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-15--1518.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Attachment: MAPREDUCE-986--2009-09-15--1518.patch

This patch caluses a task to not appear in a job trace if we don't know what its type is.

Also, under the old code, if the task creation line is present but the finish line is truncated, the taskType becomes null.  This will cause the task to be marked with its type if that happens.

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-15--1518.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765477#action_12765477 ] 

Hudson commented on MAPREDUCE-986:
----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #74 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/74/])
    . Fix Rumen to work with truncated task lines. Contributed by Dick King


> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>             Fix For: 0.21.0
>
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Attachment: MAPREDUCE-986--2009-09-16--1015.patch

This is a revised version of my previous patch.  I made the following changes:

1: I looked at the code change suggested in the previous comment and the code context, and made a _different_ change.

2: I did revise the unit test to make a separate test for proper functioning with a job tracker log that has truncated task lines.

-dk


> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated MAPREDUCE-986:
--------------------------------

    Affects Version/s: 0.21.0
               Status: Open  (was: Patch Available)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765633#action_12765633 ] 

Hudson commented on MAPREDUCE-986:
----------------------------------

Integrated in Hadoop-Mapreduce-trunk #112 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/112/])
    . Fix Rumen to work with truncated task lines. Contributed by Dick King


> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>             Fix For: 0.21.0
>
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Status: Patch Available  (was: Open)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-15--1518.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated MAPREDUCE-986:
---------------------------------

    Component/s: tools/rumen

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>             Fix For: 0.21.0
>
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756234#action_12756234 ] 

Hadoop QA commented on MAPREDUCE-986:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12419797/mapredoce-986-removed-white-space.patch
  against trunk revision 815628.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    -1 release audit.  The applied patch generated 223 release audit warnings (more than the trunk's current 220 warnings).

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/91/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/91/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/91/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/91/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/91/console

This message is automatically generated.

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756195#action_12756195 ] 

Hadoop QA commented on MAPREDUCE-986:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12419792/MAPREDUCE-986--2009-09-16--1015.patch
  against trunk revision 815628.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    -1 release audit.  The applied patch generated 223 release audit warnings (more than the trunk's current 220 warnings).

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/38/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/38/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/38/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/38/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/38/console

This message is automatically generated.

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Attachment:     (was: MAPREDUCE-986--2009-09-15--1518.patch)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Status: Patch Available  (was: Open)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756143#action_12756143 ] 

Dick King commented on MAPREDUCE-986:
-------------------------------------

The patch appears to make lots of changes to *HadoopLogsAnalyzer* but it doesn't.  The only hunk that represents a code change is at line 1046.

The patch will fail the audit because there are three new files that don't have an apache license banner.  These three files cannot contain a license banner because they are an input and two reference outputs for a unit case.

-dk


> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-986:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I committed this. Thanks, Dick!

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>             Fix For: 0.21.0
>
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated MAPREDUCE-986:
--------------------------------

    Status: Patch Available  (was: Open)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hong Tang updated MAPREDUCE-986:
--------------------------------

    Attachment: mapredoce-986-removed-white-space.patch

Patch includes quite a few unnecessary white space or format changes. I removed them and uploaded the new patch.

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: mapredoce-986-removed-white-space.patch, MAPREDUCE-986--2009-09-16--1015.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-986) rumen makes a task with a null type when one of the task lines is truncated

Posted by "Dick King (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dick King updated MAPREDUCE-986:
--------------------------------

    Status: Open  (was: Patch Available)

> rumen makes a task with a null type when one of the task lines is truncated
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-986
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-986
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Dick King
>            Assignee: Dick King
>         Attachments: MAPREDUCE-986--2009-09-15--1518.patch
>
>
> Rumen was used to produce a job trace, but the job trace contained a LoggedTask that had a null taskType.  This appears to happen when a Task line is truncated.
> We should not put the LoggedTask in the trace at all when this happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.