You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2023/08/03 15:55:37 UTC
Change in asterixdb[master]: [ASTERIXDB-3233][TYPE] Fix hashCode for ARecordType
From Wail Alkowaileet <wa...@gmail.com>:
Wail Alkowaileet has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17691 )
Change subject: [ASTERIXDB-3233][TYPE] Fix hashCode for ARecordType
......................................................................
[ASTERIXDB-3233][TYPE] Fix hashCode for ARecordType
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Fix hashCode for ARecordType.
Change-Id: If2062dc8b00e59fb8a43c99828c26b75eed69746
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/91/17691/1
diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
index fd51433..30ec2a7 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
@@ -347,12 +347,12 @@
@Override
public int hash() {
- int h = 0;
+ int h = Boolean.hashCode(isOpen);
for (int i = 0; i < fieldNames.length; i++) {
h += (31 * h) + fieldNames[i].hashCode();
}
for (int i = 0; i < fieldTypes.length; i++) {
- h += (31 * h) + fieldTypes[i].hashCode();
+ h += (31 * h) + fieldTypes[i].hash();
}
return h;
}
diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java
index 16f83f5..f47cd59 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractComplexType.java
@@ -50,6 +50,11 @@
return object instanceof IAObject && deepEqual((IAObject) object);
}
+ @Override
+ public int hashCode() {
+ return hash();
+ }
+
protected void addToJson(final ObjectNode json) {
json.put(TYPE_NAME_FIELD, typeName);
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17691
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: If2062dc8b00e59fb8a43c99828c26b75eed69746
Gerrit-Change-Number: 17691
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: newchange