You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/09/20 21:27:37 UTC

[GitHub] [helix] Lincong opened a new issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Lincong opened a new issue #1876:
URL: https://github.com/apache/helix/issues/1876


   ### Describe the bug
   A clear and concise description of what the bug is.
   The rebalance method on the `HelixAdmin` is:
   ```
     /**
      * Rebalance a resource in cluster
      * @param clusterName
      * @param resourceName
      * @param replica
      */
     void rebalance(String clusterName, String resourceName, int replica);
   ```
   The last param is `int replica`. It'd be more precise to name it `replicaNum` or `replicaCount` since `int replica` is ambiguous since it could mean `replica ID` etc.
   In addition, please consider adding accurate description of params to its Java doc. 
   
   ### To Reproduce
   Steps to reproduce the behavior.
   
   ### Expected behavior
   A clear and concise description of what you expected to happen.
   
   ### Additional context
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] junkaixue commented on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
junkaixue commented on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930594093


   @Lincong Master branch should be fine. But remember follow the OR template and steps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] junkaixue commented on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
junkaixue commented on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930594093


   @Lincong Master branch should be fine. But remember follow the OR template and steps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] Lincong commented on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
Lincong commented on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930422721


   Thanks, @narendly, which branch should I create a PR against?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] Lincong edited a comment on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
Lincong edited a comment on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930422721


   Thanks @narendly, which branch should I create a PR against?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] Lincong commented on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
Lincong commented on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930422721


   Thanks, @narendly, which branch should I create a PR against?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] narendly commented on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
narendly commented on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-924985555


   Thanks @Lincong - this is good feedback. Feel free to make a Pull Request yourself. Otherwise, we could also pick this up sometime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] Lincong edited a comment on issue #1876: Imprecise param name on the rebalance API in HelixAdmin

Posted by GitBox <gi...@apache.org>.
Lincong edited a comment on issue #1876:
URL: https://github.com/apache/helix/issues/1876#issuecomment-930422721


   Thanks @narendly, which branch should I create a PR against?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org