You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 21:11:04 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #8072: ARROW-9879: [Python] Add support for numpy scalars to ChunkedArray.__getitem__

kszucs commented on a change in pull request #8072:
URL: https://github.com/apache/arrow/pull/8072#discussion_r501312248



##########
File path: python/pyarrow/table.pxi
##########
@@ -160,6 +160,8 @@ cdef class ChunkedArray(_PandasConvertible):
             return _normalize_slice(self, key)
         elif isinstance(key, int):

Review comment:
       I think we could use the python conversion helper  [CIntFromPython](https://github.com/apache/arrow/blob/master/cpp/src/arrow/python/helpers.h#L92) which should handle numpy scalars as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org