[GitHub] [airflow] eumiro commented on a diff in pull request #33846: Refactor unneeded 'continue' jumps in jobs

["eumiro (via GitHub)" <gi...@apache.org>]

eumiro commented on code in PR #33846:
URL: https://github.com/apache/airflow/pull/33846#discussion_r1314290974


##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):
                             _per_task_process(key, ti, session)
                             try:
                                 session.commit()
-                                # break the retry loop
-                                break

Review Comment:
   `try` block should contain only code that is expected to throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org