[GitHub] willholley commented on a change in pull request #951: Do not always return partial_filter_selector

[GitBox <gi...@apache.org>]

willholley commented on a change in pull request #951: Do not always return partial_filter_selector
URL: https://github.com/apache/couchdb/pull/951#discussion_r148256783
 
 

 ##########
 File path: src/mango/test/16-index-selectors-test.py
 ##########
 @@ -161,6 +161,12 @@ def test_saves_partial_filter_selector_in_index(self):
         indexes = self.db.list_indexes()
         self.assertEqual(indexes[1]["def"]["partial_filter_selector"], selector)
 
+    def test_partial_filter_only_in_return_if_not_default(self):
 
 Review comment:
   do we have a test for the negative as well (i.e. partial_filter_selector is not present in the json when it has the default value / was not specified)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services