[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18276: [improve][txn] Client add exception for transaction not fully init in broker

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #18276:
URL: https://github.com/apache/pulsar/pull/18276#discussion_r1010286657


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionCoordinatorClientImpl.java:
##########
@@ -97,14 +98,9 @@ public CompletableFuture<Void> startAsync() {
                             handler.start();
                         }
                     } else {
-                        handlers = new TransactionMetaStoreHandler[1];
-                        CompletableFuture<Void> connectFuture = new CompletableFuture<>();
-                        connectFutureList.add(connectFuture);
-                        TransactionMetaStoreHandler handler = new TransactionMetaStoreHandler(0, pulsarClient,
-                                getTCAssignTopicName(-1), connectFuture);
-                        handlers[0] = handler;
-                        handlerMap.put(0, handler);
-                        handler.start();
+                        return FutureUtil.failedFuture(new TransactionCoordinatorClientException("The broker "
+                                + "doesn't enable transaction or transaction "
+                                + "has not completed initialization in broker"));

Review Comment:
   The broker doesn't enable the transaction coordinator, or the transaction coordinator has not initialized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org