[GitHub] [incubator-superset] craig-rueda commented on issue #8148: Adding explicit include for version_info.json

[GitBox <gi...@apache.org>]

craig-rueda commented on issue #8148: Adding explicit include for version_info.json
URL: https://github.com/apache/incubator-superset/pull/8148#issuecomment-526766812
 
 
   Yep, so it actually depends on the tests that are being run -
   
   **JS tests** will require `package.json`, however they are run directly from the `assets` folder (pre pip install) 
   **Py tests** will run after installing (pip) and don't require package.json to run (hence the green Travis build).
   
   In the end, the goal of this pr is actually to restore `version_info.json` to the resulting installed package. It's also advisable to NOT include `package.json` in deployed software where it can be accessed publicly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org