You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/10 11:42:02 UTC

[GitHub] [flink] wangyang0918 commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

wangyang0918 commented on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-1008794107


   Really thanks @alpreu for working on this PR and @XComp helping with review.
   
   I believe it is the right direction to use the `KubernetesLabel` for generating and validating labels and names. I have one more concern about this PR. IIRC, only the labels, pod names, service names have the limitation of 63 characters. The ConfigMap name is not one of them.
   
   Another thing is about the pod name. The names of JobManager pod(e.g. `<clusterId>-fd5c8ffc4-c6dfw`) and TaskManager pod(e.g. `<clusterId>-taskmanager-<attemptId>-<index>`) are generated dynamically. Do we also need to add the limitation check for them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org