[jira] [Commented] (TINKERPOP-1573) Bindings don't work in coalesce

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711882#comment-15711882 ] 

ASF GitHub Bot commented on TINKERPOP-1573:
-------------------------------------------

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/507
  
    So the most frequently called method will be `Bindings.getBoundVariable()`. It is called on every `Bytecode.convertArguments()` which is called on every instruction addition. Next, one of primary benefits of the static nature of `Bindings` (now) is that there is no longer a `transient` reference to them in `Bytecode` as we can statically access the data.
    
    In terms of the cost of `ThreadLocal.get()`. Dunno..... perhaps a `clock()`? I can't imagine it being too crazy given that you will never really have that many entries. ?


> Bindings don't work in coalesce
> -------------------------------
>
>                 Key: TINKERPOP-1573
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1573
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: structure
>    Affects Versions: 3.2.3
>            Reporter: Robert Dale
>            Assignee: Marko A. Rodriguez
>
> {noformat}
> gremlin> graph = EmptyGraph.instance()
> ==>emptygraph[empty]
> gremlin> g = graph.traversal().withRemote('conf/remote-graph.properties')
> ==>graphtraversalsource[emptygraph[empty], standard]
> gremlin> g.addV('fof').property('key',234)
> ==>v[0]
> gremlin> b = new Bindings()
> ==>{}
> gremlin> g.withBindings(b).V().has('fof','key',234).coalesce(__.V().has(b.of('l','fof'), b.of('k', 'key'), b.of('v',234)), __.addV(b.of('nl','fof')).property(b.of('sk','key'), b.of('sv',234))).property(b.of('nk','newkey'), b.of('nv','newvalue')).asAdmin().getBytecode()
> ==>[[], [V(), has(fof, key, 234), coalesce([[], [V(), has(fof, key, 234)]], [[], [addV(fof), property(key, 234)]]), property(binding[nk=newkey], binding[nv=newvalue])]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)