[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3265: Remove deprecated scan interpreter and formatter

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3265:
URL: https://github.com/apache/accumulo/pull/3265#discussion_r1155023096


##########
shell/src/main/java/org/apache/accumulo/shell/commands/FormatterCommand.java:
##########


Review Comment:
   I believe the `formatter` command can still set a formatter in the shell state for scans that don't specify the removed formatter flag on the `scan` command. Similarly, I think the per-table configuration that allows you to set a default formatter for a table, still works (the same command for the interpreter was removed). The formatter and interpreter commands (and flags) were very closely related, although we had the formatter stuff in place before the interpreter stuff. Still, I believe the intent was to deprecate and remove both at the same time, since they are related. However, we didn't properly mark all the formatter props and commands as deprecated, so I believe that they still work, but they revert back to how they worked when the formatter stuff was on its own, prior to the introduction of the interpreter stuff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org