You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/06/04 10:34:18 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #965: SUBMARINE-1281. Limit tensorflow protocol package version to <=3.20.1
cdmikechen opened a new pull request, #965:
URL: https://github.com/apache/submarine/pull/965
### What is this PR for?
The latest submarine-sdk dependent installation will cause workflow CI test failure.
After checked, it is found that the latest version of protocol has changed:
https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
https://pypi.org/project/protobuf/#history
We need to limit the protocol package version to <=3.20.1
### What type of PR is it?
Hot Fix
### Todos
* [x] - add extras_require `protobuf<=3.20.1`
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1281
### How should this be tested?
Submarine Github workflow CI test
### Screenshots (if appropriate)
No
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #965: SUBMARINE-1281. Limit tensorflow protocol package version to <=3.20.1
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #965:
URL: https://github.com/apache/submarine/pull/965#issuecomment-1146613651
# [Codecov](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#965](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f1a3d3) into [master](https://codecov.io/gh/apache/submarine/commit/1f6eb4d6b581eb64fa827b0ff02902a10fab3884?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f6eb4d) will **increase** coverage by `2.61%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #965 +/- ##
============================================
+ Coverage 8.74% 11.35% +2.61%
- Complexity 661 798 +137
============================================
Files 243 243
Lines 24711 24711
Branches 3550 3550
============================================
+ Hits 2160 2807 +647
+ Misses 22419 21729 -690
- Partials 132 175 +43
```
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/submarine/server/submitter/k8s/K8sSubmitter.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9LOHNTdWJtaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...erver/submitter/k8s/parser/NotebookSpecParser.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9wYXJzZXIvTm90ZWJvb2tTcGVjUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...submarine/commons/cluster/ClusterStateMachine.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL0NsdXN0ZXJTdGF0ZU1hY2hpbmUuamF2YQ==) | `28.57% <0.00%> (+28.57%)` | :arrow_up: |
| [...pache/submarine/commons/cluster/ClusterClient.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL0NsdXN0ZXJDbGllbnQuamF2YQ==) | `52.00% <0.00%> (+52.00%)` | :arrow_up: |
| [...pache/submarine/commons/cluster/ClusterServer.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL0NsdXN0ZXJTZXJ2ZXIuamF2YQ==) | `57.82% <0.00%> (+57.82%)` | :arrow_up: |
| [.../cluster/protocol/RaftClientMessagingProtocol.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL3Byb3RvY29sL1JhZnRDbGllbnRNZXNzYWdpbmdQcm90b2NvbC5qYXZh) | `59.09% <0.00%> (+59.09%)` | :arrow_up: |
| [...he/submarine/commons/cluster/meta/ClusterMeta.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL21ldGEvQ2x1c3Rlck1ldGEuamF2YQ==) | `64.51% <0.00%> (+64.51%)` | :arrow_up: |
| [...ubmarine/commons/cluster/ClusterPrimitiveType.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL0NsdXN0ZXJQcmltaXRpdmVUeXBlLmphdmE=) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
| [...ommons/cluster/protocol/RaftMessagingProtocol.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL3Byb3RvY29sL1JhZnRNZXNzYWdpbmdQcm90b2NvbC5qYXZh) | `69.23% <0.00%> (+69.23%)` | :arrow_up: |
| [...ons/cluster/protocol/LocalRaftProtocolFactory.java](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvY29tbW9ucy9jbHVzdGVyL3Byb3RvY29sL0xvY2FsUmFmdFByb3RvY29sRmFjdG9yeS5qYXZh) | `71.42% <0.00%> (+71.42%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/submarine/pull/965/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9f5a317...3f1a3d3](https://codecov.io/gh/apache/submarine/pull/965?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #965: SUBMARINE-1281. Limit tensorflow protocol package version to <=3.20.1
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #965: SUBMARINE-1281. Limit tensorflow protocol package version to <=3.20.1
URL: https://github.com/apache/submarine/pull/965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org