You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/11/15 23:49:04 UTC
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8559
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
[java] Add ReplicaSelection in KuduScanToken
This patch adds ReplicaSelection in KuduScanToken for java client,
so that deserializing a ScanToken results in propagting the replica
selection policy of the serializer into the deserializer.
Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M src/kudu/client/client.proto
M src/kudu/common/common.proto
5 files changed, 59 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8559/1
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG@10
PS1, Line 10: propagatin
> propagating
Done
http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java:
http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java@47
PS1, Line 47:
> Is this used anywhere? I'm nervous about adding this field, since it may b
Done
http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto
File src/kudu/common/common.proto:
http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto@235
PS1, Line 235: enum ReplicaSelection {
> Add an 'UNKNOWN = 0;' variant. That's a protobuf best-practice.
Done
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Nov 2017 00:04:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8559
to look at the new patch set (#2).
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
[java] Add ReplicaSelection in KuduScanToken
This patch adds ReplicaSelection in KuduScanToken for java client,
so that deserializing a ScanToken results in propagating the replica
selection policy of the serializer into the deserializer.
Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M src/kudu/client/client.proto
M src/kudu/common/common.proto
4 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8559/2
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
Patch Set 2: Code-Review+2
Looks good. Are you going to add support to the C++ client as well?
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Nov 2017 21:31:27 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
[java] Add ReplicaSelection in KuduScanToken
This patch adds ReplicaSelection in KuduScanToken for java client,
so that deserializing a ScanToken results in propagating the replica
selection policy of the serializer into the deserializer.
Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Reviewed-on: http://gerrit.cloudera.org:8080/8559
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M src/kudu/client/client.proto
M src/kudu/common/common.proto
4 files changed, 50 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Add ReplicaSelection in KuduScanToken
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG@10
PS1, Line 10: propagting
propagating
http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java:
http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java@47
PS1, Line 47: Common.ReplicaSelection pbVersion() {
Is this used anywhere? I'm nervous about adding this field, since it may be an ABI breaking change (https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html#jls-13.4.26 isn't very specific).
http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto
File src/kudu/common/common.proto:
http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto@235
PS1, Line 235: enum ReplicaSelection {
Add an 'UNKNOWN = 0;' variant. That's a protobuf best-practice.
--
To view, visit http://gerrit.cloudera.org:8080/8559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914
Gerrit-Change-Number: 8559
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 16 Nov 2017 19:37:45 +0000
Gerrit-HasComments: Yes