You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/01/26 09:33:58 UTC

[GitHub] [submarine] aeioulisa opened a new pull request #499: SUBMARINE-708. Add mailing list subscription link

aeioulisa opened a new pull request #499:
URL: https://github.com/apache/submarine/pull/499


   ### What is this PR for?
   Add mailing list subscription link in Readme
   
   
   ### What type of PR is it?
   [Documentation]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-708
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   ![image](https://user-images.githubusercontent.com/30621230/105827140-961fdd00-5ffc-11eb-978a-550878fa9d15.png)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] cxorm commented on a change in pull request #499: SUBMARINE-708. Add mailing list subscription link

Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #499:
URL: https://github.com/apache/submarine/pull/499#discussion_r564430389



##########
File path: docs/community/README.md
##########
@@ -57,7 +57,7 @@ Based on your track-record as a contributor, Per Apache code, PMCs vote on commi
 Note that becoming a committer is not just about submitting some patches; it‘s also about helping out on the development and user [Slack User](https://the-asf.slack.com/submarine-user/), helping with documentation and the issues.
 
 See [Become a Committer.md](become-a-committer.md) for steps of becoming a committer and more details.
-
+Mailing list

Review comment:
       IMHO it is a  redundant line, 
   feel free to let me know why we need this line if I miss something.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lowc1012 commented on a change in pull request #499: SUBMARINE-708. Add mailing list subscription link

Posted by GitBox <gi...@apache.org>.
lowc1012 commented on a change in pull request #499:
URL: https://github.com/apache/submarine/pull/499#discussion_r564526833



##########
File path: docs/community/README.md
##########
@@ -66,6 +66,17 @@ See [How to commit](HowToCommit.md) for helper doc for Submarine committers.
 
 Communication within the Submarine community abides by [Apache’s Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
 
+## Mailing lists
+
+Get help using Apache Submarine or contribute to the project on our mailing lists:
+
++ [Users](https://lists.apache.org/list.html?users@submarine.apache.org) : [subscribe](users-subscribe@submarine.apache.org), [unsubscribe](users-unsubscribe@submarine.apache.org), [archives](https://lists.apache.org/list.html?users@submarine.apache.org)
+for usage questions, help, and announcements.
++ [Dev](https://lists.apache.org/list.html?dev@submarine.apache.org) : [subscribe](dev-subscribe@submarine.apache.org), [unsubscribe](dev-unsubscribe@submarine.apache.org), [archives](https://lists.apache.org/list.html?dev@submarine.apache.org)
+for people wanting to contribute to the project.
++ [Commits](https://lists.apache.org/list.html?commits@submarine.apache.org) : [subscribe](commits-subscribe@submarine.apache.org), [unsubscribe](commits-unsubscribe@submarine.apache.org), [archives](https://lists.apache.org/list.html?commits@submarine.apache.org)

Review comment:
       The links for subscribing and unsubscribing should be "mailto:xxxxx@submarine.apache.org"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #499: SUBMARINE-708. Add mailing list subscription link

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #499:
URL: https://github.com/apache/submarine/pull/499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] cxorm commented on pull request #499: SUBMARINE-708. Add mailing list subscription link

Posted by GitBox <gi...@apache.org>.
cxorm commented on pull request #499:
URL: https://github.com/apache/submarine/pull/499#issuecomment-767493655


   Hi @pingsutw,
   Could you be so kind as to take a look on this PR, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lowc1012 commented on a change in pull request #499: SUBMARINE-708. Add mailing list subscription link

Posted by GitBox <gi...@apache.org>.
lowc1012 commented on a change in pull request #499:
URL: https://github.com/apache/submarine/pull/499#discussion_r564497159



##########
File path: docs/community/README.md
##########
@@ -66,6 +66,17 @@ See [How to commit](HowToCommit.md) for helper doc for Submarine committers.
 
 Communication within the Submarine community abides by [Apache’s Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
 
+## Mailing list

Review comment:
       Mailing lists




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org