You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/23 04:15:57 UTC
Review Request 12834: Iterate frameworks successively to save concat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12834/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Iterate frameworks successively to save concat
`concat` concatenates two Arrays and returns a new Array. `frameworks`
and `completed_frameworks` can be iterated successively to save
allocation of a new Array that is thrown away after finding the current
framework.
Diffs
-----
src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b
Diff: https://reviews.apache.org/r/12834/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 12834: Iterate frameworks successively to save concat
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 25, 2013, 9:18 p.m., Ben Mahler wrote:
> > Note that this would be removed once we make a change in the backend to remove from completedFrameworks when a framework re-registered. Feel free to file a ticket against me.
> >
> > The original bug is https://issues.apache.org/jira/browse/MESOS-417, but is that one now fixed? If so, do you know the review / commit where it was fixed?
I believe MESOS-417 is still an issue. I will submit this change and comment in the Jira issue about the fix that is needed.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12834/#review23872
-----------------------------------------------------------
On July 23, 2013, 2:15 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12834/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 2:15 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Iterate frameworks successively to save concat
>
> `concat` concatenates two Arrays and returns a new Array. `frameworks`
> and `completed_frameworks` can be iterated successively to save
> allocation of a new Array that is thrown away after finding the current
> framework.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b
>
> Diff: https://reviews.apache.org/r/12834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12834: Iterate frameworks successively to save concat
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12834/#review23872
-----------------------------------------------------------
Ship it!
Note that this would be removed once we make a change in the backend to remove from completedFrameworks when a framework re-registered. Feel free to file a ticket against me.
The original bug is https://issues.apache.org/jira/browse/MESOS-417, but is that one now fixed? If so, do you know the review / commit where it was fixed?
- Ben Mahler
On July 23, 2013, 2:15 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12834/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 2:15 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Iterate frameworks successively to save concat
>
> `concat` concatenates two Arrays and returns a new Array. `frameworks`
> and `completed_frameworks` can be iterated successively to save
> allocation of a new Array that is thrown away after finding the current
> framework.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b
>
> Diff: https://reviews.apache.org/r/12834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>