[GitHub] [spark] cloud-fan commented on a change in pull request #25328: [SPARK-28595][SQL] explain should not trigger partition listing

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #25328: [SPARK-28595][SQL] explain should not trigger partition listing
URL: https://github.com/apache/spark/pull/25328#discussion_r311104278
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala
 ##########
 @@ -49,6 +49,16 @@ class BucketedReadWithoutHiveSupportSuite extends BucketedReadSuite with SharedS
 abstract class BucketedReadSuite extends QueryTest with SQLTestUtils {
   import testImplicits._
 
+  protected override def beforeAll(): Unit = {
+    super.beforeAll()
+    spark.sessionState.conf.setConf(SQLConf.LEGACY_BUCKETED_TABLE_SCAN_OUTPUT_ORDERING, true)
+  }
+
+  protected override def afterAll(): Unit = {
+    spark.sessionState.conf.unsetConf(SQLConf.LEGACY_BUCKETED_TABLE_SCAN_OUTPUT_ORDERING)
 
 Review comment:
   In the test, we assume that every test suite will keep the shared `SparkSession` clean after tests are run. So the old conf should be the default conf here, and we only need to call `unsetConf` to restore the default config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org