You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2015/10/12 15:49:09 UTC

[3/3] qpid-jms git commit: QPIDJMS-124: include details of any throwable the peer caught in the message reported when handlers dont complete in given time

QPIDJMS-124: include details of any throwable the peer caught in the message reported when handlers dont complete in given time


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/56cc60f4
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/56cc60f4
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/56cc60f4

Branch: refs/heads/master
Commit: 56cc60f4ecf7c80d7c0e33c4a80983df24681e8d
Parents: a7a317d
Author: Robert Gemmell <ro...@apache.org>
Authored: Mon Oct 12 14:09:33 2015 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Mon Oct 12 14:48:03 2015 +0100

----------------------------------------------------------------------
 .../java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/56cc60f4/qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java
index 34d7c34..e1aac4b 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java
@@ -305,7 +305,13 @@ public class TestAmqpPeer implements AutoCloseable
     {
         boolean countedDownOk =  waitForAllHandlersToCompleteNoAssert(timeoutMillis);
 
-        Assert.assertTrue("All handlers should have completed within the " + timeoutMillis + "ms timeout", countedDownOk);
+        String message = "All handlers did not complete within the " + timeoutMillis + "ms timeout.";
+        Throwable t = getThrowable();
+        if(t != null){
+            message += System.lineSeparator() + "A *potential* reason, peer caught throwable: " + t;
+        }
+
+        Assert.assertTrue(message, countedDownOk);
     }
 
     public boolean waitForAllHandlersToCompleteNoAssert(int timeoutMillis) throws InterruptedException


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org