[GitHub] leventov commented on a change in pull request #5980: Various changes about a few coding specifications

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #5980: Various changes about a few coding specifications
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202515329
 
 

 ##########
 File path: server/src/test/java/io/druid/initialization/InitializationTest.java
 ##########
 @@ -454,8 +454,8 @@ public void testExtensionsWithSameDirName() throws Exception
     final ClassLoader classLoader1 = Initialization.getClassLoaderForExtension(extension1, false);
     final ClassLoader classLoader2 = Initialization.getClassLoaderForExtension(extension2, false);
 
-    Assert.assertArrayEquals(new URL[]{jar1.toURL()}, ((URLClassLoader) classLoader1).getURLs());
-    Assert.assertArrayEquals(new URL[]{jar2.toURL()}, ((URLClassLoader) classLoader2).getURLs());
+    Assert.assertArrayEquals(new URL[]{jar1.toURI().toURL()}, ((URLClassLoader) classLoader1).getURLs());
 
 Review comment:
   Please add this method to our forbidden-apis file: https://github.com/apache/incubator-druid/blob/master/codestyle/druid-forbidden-apis.txt. When adding, please check that it works by intentionally leaving one call to this method in the code, and see if `mvn clean install -DskipTests` fails locally. For syntax, see https://github.com/policeman-tools/forbidden-apis/wiki/SignaturesSyntax.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org