[GitHub] [tvm] mehrdadh commented on a diff in pull request #11067: [microTVM] Bump versions in reference vm

[GitBox <gi...@apache.org>]

mehrdadh commented on code in PR #11067:
URL: https://github.com/apache/tvm/pull/11067#discussion_r856411646


##########
docker/install/ubuntu_install_arduino.sh:
##########
@@ -23,7 +23,7 @@ set -o pipefail
 export DEBIAN_FRONTEND=noninteractive
 apt-get install -y ca-certificates
 
-ARDUINO_CLI_VERSION="0.18.3"
+ARDUINO_CLI_VERSION="0.21.1"

Review Comment:
   can you consolidate arduino CLI installation into one script and reuse for both docker and RVM?



##########
apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh:
##########
@@ -47,9 +47,8 @@ sudo usermod -a -G dialout $USER
 # 3rd party board URLs
 ADAFRUIT_BOARDS_URL="https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
 ESP32_BOARDS_URL="https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json"
-SPARKFUN_BOARDS_URL="https://raw.githubusercontent.com/sparkfun/Arduino_Boards/master/IDE_Board_Manager/package_sparkfun_index.json"
 SEEED_BOARDS_URL="https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json"
-SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/v2.2.1/package_spresense_index.json"
+SPRESENSE_BOARDS_URL="https://github.com/sonydevworld/spresense-arduino-compatible/releases/download/generic/package_spresense_index.json"

Review Comment:
   can you explain what is generic here?
   I think the idea of RVM is to use fixed versions so we can reproduce them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org