You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Brett Porter <br...@gmail.com> on 2006/09/13 10:24:34 UTC
Re: notice about recent assembly plugin snapshot
John?
On 31/08/06, Brett Porter <br...@gmail.com> wrote:
> was this behaviour only in previous snapshots of the current release,
> or was it that way in the previous release?
>
> On 31/08/06, John Casey <ca...@gmail.com> wrote:
> > Hi everyone,
> >
> > I just wanted to send a quick note to let you know that I've made some
> > modifications to the way the assembly plugin functions. These changes are
> > likely to break your assemblies if you're using the
> > moduleSets/moduleSet/sources element.
> >
> > The sources element used to be derived from fileSet, in that you could
> > provide directory, outputDirectory, includes, excludes, etc. directly on
> > that element. This sources element would determine how source-files from
> > module children and grandchildren of your project were included. In some
> > recent work, I've noticed that it's sometimes useful to be more flexible
> > with module source inclusion. So, I've made the sources element a
> > free-standing class, no longer derived from the fileSet.
> >
> > So, to replicate this:
> >
> > <moduleSets>
> > <moduleSet>
> > <sources>
> > <directory>src</directory>
> > <excludes>
> > <exclude>**/*.bak</exclude>
> > <exclude>**/*~</exclude>
> > </excludes>
> > </sources>
> > </moduleSet>
> > </moduleSets>
> >
> > you'd need to change it to the following:
> >
> >
> > <moduleSets>
> > <moduleSet>
> > <sources>
> > <fileSets>
> > <fileSet>
> > <directory>src</directory>
> > <excludes>
> > <exclude>**/*.bak</exclude>
> > <exclude>**/*~</exclude>
> > </excludes>
> > </fileSet>
> > </fileSets>
> > </sources>
> > </moduleSet>
> > </moduleSets>
> >
> > I've deployed this new snapshot for people to try out, but changes like this
> > and other new features of the moduleSet section are not documented yet. I'm
> > planning to flesh out the documentation for these new parts soon, and call a
> > release, as I think we're nearing a good cut-off point, before beginning a
> > new round of features. I just wanted to make sure I didn't leave people
> > saying, "WTF? This used to work!" tonight.
> >
> > -john
> >
> >
>
>
> --
> Apache Maven - http://maven.apache.org
> "Better Builds with Maven" book - http://library.mergere.com/
>
--
Apache Maven - http://maven.apache.org
"Better Builds with Maven" book - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: notice about recent assembly plugin snapshot
Posted by Brett Porter <br...@gmail.com>.
The standard pattern there is to have a <useDefaultExcludes /> tag
that is by default true. If you turn it off, you have to exclude all
the ones you don't want.
I think it needs to do that, especially if it did in 2.1. Backwards
compat is key.
- Brett
On 14/09/06, John Casey <ca...@gmail.com> wrote:
> I *think* the <sources/> tag was in the 2.1 release. I'm guessing I'll have
> to put support back in for backward compat...but I need to check out when
> this element was added to the model first.
>
> As for the .svn files, I believe this is a shortcoming of the underlying
> scanner implementation's default excludes. I'm a little hesitant to put that
> exclusion in by default, because there's no way to take it back. In other
> words, it may help most people to exclude **/.svn/** by default, but for
> those who *need* that pattern to be included, I don't think it would be
> possible.
>
> -john
>
> On 9/13/06, Brett Porter <br...@gmail.com> wrote:
> >
> > John?
> >
> > On 31/08/06, Brett Porter <br...@gmail.com> wrote:
> > > was this behaviour only in previous snapshots of the current release,
> > > or was it that way in the previous release?
> > >
> > > On 31/08/06, John Casey <ca...@gmail.com> wrote:
> > > > Hi everyone,
> > > >
> > > > I just wanted to send a quick note to let you know that I've made some
> > > > modifications to the way the assembly plugin functions. These changes
> > are
> > > > likely to break your assemblies if you're using the
> > > > moduleSets/moduleSet/sources element.
> > > >
> > > > The sources element used to be derived from fileSet, in that you could
> > > > provide directory, outputDirectory, includes, excludes, etc. directly
> > on
> > > > that element. This sources element would determine how source-files
> > from
> > > > module children and grandchildren of your project were included. In
> > some
> > > > recent work, I've noticed that it's sometimes useful to be more
> > flexible
> > > > with module source inclusion. So, I've made the sources element a
> > > > free-standing class, no longer derived from the fileSet.
> > > >
> > > > So, to replicate this:
> > > >
> > > > <moduleSets>
> > > > <moduleSet>
> > > > <sources>
> > > > <directory>src</directory>
> > > > <excludes>
> > > > <exclude>**/*.bak</exclude>
> > > > <exclude>**/*~</exclude>
> > > > </excludes>
> > > > </sources>
> > > > </moduleSet>
> > > > </moduleSets>
> > > >
> > > > you'd need to change it to the following:
> > > >
> > > >
> > > > <moduleSets>
> > > > <moduleSet>
> > > > <sources>
> > > > <fileSets>
> > > > <fileSet>
> > > > <directory>src</directory>
> > > > <excludes>
> > > > <exclude>**/*.bak</exclude>
> > > > <exclude>**/*~</exclude>
> > > > </excludes>
> > > > </fileSet>
> > > > </fileSets>
> > > > </sources>
> > > > </moduleSet>
> > > > </moduleSets>
> > > >
> > > > I've deployed this new snapshot for people to try out, but changes
> > like this
> > > > and other new features of the moduleSet section are not documented
> > yet. I'm
> > > > planning to flesh out the documentation for these new parts soon, and
> > call a
> > > > release, as I think we're nearing a good cut-off point, before
> > beginning a
> > > > new round of features. I just wanted to make sure I didn't leave
> > people
> > > > saying, "WTF? This used to work!" tonight.
> > > >
> > > > -john
> > > >
> > > >
> > >
> > >
> > > --
> > > Apache Maven - http://maven.apache.org
> > > "Better Builds with Maven" book - http://library.mergere.com/
> > >
> >
> >
> > --
> > Apache Maven - http://maven.apache.org
> > "Better Builds with Maven" book - http://library.mergere.com/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
>
>
--
Apache Maven - http://maven.apache.org
"Better Builds with Maven" book - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: notice about recent assembly plugin snapshot
Posted by John Casey <ca...@gmail.com>.
I *think* the <sources/> tag was in the 2.1 release. I'm guessing I'll have
to put support back in for backward compat...but I need to check out when
this element was added to the model first.
As for the .svn files, I believe this is a shortcoming of the underlying
scanner implementation's default excludes. I'm a little hesitant to put that
exclusion in by default, because there's no way to take it back. In other
words, it may help most people to exclude **/.svn/** by default, but for
those who *need* that pattern to be included, I don't think it would be
possible.
-john
On 9/13/06, Brett Porter <br...@gmail.com> wrote:
>
> John?
>
> On 31/08/06, Brett Porter <br...@gmail.com> wrote:
> > was this behaviour only in previous snapshots of the current release,
> > or was it that way in the previous release?
> >
> > On 31/08/06, John Casey <ca...@gmail.com> wrote:
> > > Hi everyone,
> > >
> > > I just wanted to send a quick note to let you know that I've made some
> > > modifications to the way the assembly plugin functions. These changes
> are
> > > likely to break your assemblies if you're using the
> > > moduleSets/moduleSet/sources element.
> > >
> > > The sources element used to be derived from fileSet, in that you could
> > > provide directory, outputDirectory, includes, excludes, etc. directly
> on
> > > that element. This sources element would determine how source-files
> from
> > > module children and grandchildren of your project were included. In
> some
> > > recent work, I've noticed that it's sometimes useful to be more
> flexible
> > > with module source inclusion. So, I've made the sources element a
> > > free-standing class, no longer derived from the fileSet.
> > >
> > > So, to replicate this:
> > >
> > > <moduleSets>
> > > <moduleSet>
> > > <sources>
> > > <directory>src</directory>
> > > <excludes>
> > > <exclude>**/*.bak</exclude>
> > > <exclude>**/*~</exclude>
> > > </excludes>
> > > </sources>
> > > </moduleSet>
> > > </moduleSets>
> > >
> > > you'd need to change it to the following:
> > >
> > >
> > > <moduleSets>
> > > <moduleSet>
> > > <sources>
> > > <fileSets>
> > > <fileSet>
> > > <directory>src</directory>
> > > <excludes>
> > > <exclude>**/*.bak</exclude>
> > > <exclude>**/*~</exclude>
> > > </excludes>
> > > </fileSet>
> > > </fileSets>
> > > </sources>
> > > </moduleSet>
> > > </moduleSets>
> > >
> > > I've deployed this new snapshot for people to try out, but changes
> like this
> > > and other new features of the moduleSet section are not documented
> yet. I'm
> > > planning to flesh out the documentation for these new parts soon, and
> call a
> > > release, as I think we're nearing a good cut-off point, before
> beginning a
> > > new round of features. I just wanted to make sure I didn't leave
> people
> > > saying, "WTF? This used to work!" tonight.
> > >
> > > -john
> > >
> > >
> >
> >
> > --
> > Apache Maven - http://maven.apache.org
> > "Better Builds with Maven" book - http://library.mergere.com/
> >
>
>
> --
> Apache Maven - http://maven.apache.org
> "Better Builds with Maven" book - http://library.mergere.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>