You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/11/27 13:11:48 UTC
[PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
pitrou opened a new pull request, #44870:
URL: https://github.com/apache/arrow/pull/44870
Add EditorConfig files for automatic text editor configuration. Only the most basic properties such as indent width are set.
Also remove `.dir-locals.el` files.
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #44870:
URL: https://github.com/apache/arrow/pull/44870#issuecomment-2512048681
+1
Thanks for making these changes, @pitrou!
My sincere apologies for the delayed follow up. I was away on holiday the last few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861799663
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
Makes sense, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861191822
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
Well, of course we can, but this doesn't match the current state of Matlab files, does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861376765
##########
.editorconfig:
##########
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# Top-most config for this project
+root = true
+
+[*]
+insert_final_newline = true
+trim_trailing_whitespace = true
+charset = utf-8
+spelling_language = en
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 2
+indent_style = space
+
+[*.cmake]
+indent_size = 2
+indent_style = space
+
+[{CMakeLists.txt}]
Review Comment:
```suggestion
[CMakeLists.txt]
```
##########
.editorconfig:
##########
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# Top-most config for this project
+root = true
+
+[*]
+insert_final_newline = true
+trim_trailing_whitespace = true
+charset = utf-8
+spelling_language = en
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 2
+indent_style = space
+
+[*.cmake]
+indent_size = 2
+indent_style = space
+
+[{CMakeLists.txt}]
+indent_size = 2
+indent_style = space
+
+[*.cs]
+indent_size = 4
+indent_style = space
+
+[*.{fbs,proto,thrift}]
+indent_size = 2
+indent_style = space
+
+[*.go]
+indent_size = 8
+indent_style = tab
+tab_width = 8
+
+[*.{js,ts}]
+indent_size = 4
+indent_style = space
+
+[*.{py,pyx,pxd,pxi}]
+indent_size = 4
+indent_style = space
+
+[*.r]
+indent_size = 2
+indent_style = space
+
+[*.rb]
+indent_size = 2
+indent_style = space
+
+[*.rst]
+indent_size = 3
+indent_style = space
+
+[*.sh]
+indent_size = 2
+indent_style = space
+
+[*.{yml,yaml}]
+indent_size = 2
+indent_style = space
Review Comment:
```suggestion
indent_style = space
[*.vala]
indent_size = 4
indent_style = space
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861060172
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
Review Comment:
Could we use the inherited `indent_size` of **2** for C++ files for consistency with the rest of the language bindings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861273073
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
To your point, I don't think we have a consistent indentation level which is programmatically enforced across the entire MATLAB code base at this time. I'm not personally aware of an officially supported linting tool available to enforce this via CI currently, but I am fully supportive of a solution like this if anyone has suggestions.
Independent of the fact that it is not programatically enforced at this time, it definitely seems like a good thing to strive for consistency in indentation level. The MATLAB editor uses a 4 space indent by default , so I thought it would make sense to use that as the default in the `.editorconfig` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861273073
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
To your point, I don't think we have a consistent indentation level which is programmatically enforced across the entire MATLAB code base at this time. I'm not personally aware of an officially supported linting tool available to enforce this via CI currently, but I am fully supportive of a solution like this if anyone has suggestions.
Regardless, the MATLAB editor uses a 4 space indent by default , so I thought it would make sense to use that in the `.editorconfig` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44870:
URL: https://github.com/apache/arrow/pull/44870#issuecomment-2512795795
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1838d0ad08d056d01cb7c78b3a2e08138f8b1c8e.
There were 132 benchmark results with an error:
- Commit Run on `arm64-t4g-2xlarge-linux` at [2024-12-02 16:34:04Z](https://conbench.ursa.dev/compare/runs/9b0ed61547ce424698cb12f54c2067f2...a3eb5a9bc98e4a10834c747362067b55/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0674defecdf77c4a8000cbf5f4885dde)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0674df015c297cfd80003a157b937a66)
- and 130 more (see the report linked below)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/33812575848) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #44870:
URL: https://github.com/apache/arrow/pull/44870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861046610
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
Could we set the `indent_size` to **4** for M files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861273073
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
To your point, I don't think we have a consistent indentation level which is programmatically enforced across the entire MATLAB code base at this time. I don't know that there is an officially supported linting tool available to enforce this via CI currently, but I am fully supportive of a solution like this if anyone has suggestions.
Regardless, the MATLAB editor uses a 4 space indent by default , so I thought it would make sense to use that in the `.editorconfig` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861277414
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
Review Comment:
Along the same lines as my other comment - I don't believe the indentation level is fully consistent across the C++ code base for MATLAB currently. However, it's probably a good idea for us to strive for this moving forward.
I would have expected this to be enforced via https://github.com/apache/arrow/pull/40588, but it's likely I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861192027
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
Review Comment:
I agree, but here as well, it doesn't seem to match existing files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44870:
URL: https://github.com/apache/arrow/pull/44870#issuecomment-2503846227
:warning: GitHub issue #44805 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861046610
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
+indent_style = space
+
+[*.m]
+indent_size = 1
Review Comment:
1. Could we use the inherited `indent_size` of **2** for C++ files for consistency with the rest of the language bindings?
2. Could we set the `indent_size` to **4** for M files?
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
Review Comment:
a -> an
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44870:
URL: https://github.com/apache/arrow/pull/44870#discussion_r1861803604
##########
matlab/.editorconfig:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This is a EditorConfig file: https://editorconfig.org/
+
+# See ../.editorconfig for inherited values
+
+[*.{c,cc,cpp,h,hh,hpp}]
+indent_size = 1
Review Comment:
Will do as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44805: [Dev] Add `.editorconfig` file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44870:
URL: https://github.com/apache/arrow/pull/44870#issuecomment-2505637045
@kou @kevingurney I believe I have addressed your comments, can you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org