You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/01/21 20:38:13 UTC
Re: Review Request 17013: Containerizer - updated tests (part 5)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Jan. 21, 2014, 7:38 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Summary (updated)
-----------------
Containerizer - updated tests (part 5)
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs
-----
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/#review32657
-----------------------------------------------------------
Is this patch final/reviewable? Or do you plan to follow up with a new diff and get this the tests reenabled?
In that case it might make sense to rename isolator_tests too.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment61560>
XXX as a work in progress RR? Or else, should this be a TODO?
src/tests/cluster.hpp
<https://reviews.apache.org/r/17013/#comment61561>
Wrap and indent. There seem to be a space before slave.containerizer too.
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment61562>
Wrap please.
src/tests/containerizer.cpp
<https://reviews.apache.org/r/17013/#comment61563>
Wrap please.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment61564>
src/tests/mesos.cpp
<https://reviews.apache.org/r/17013/#comment61565>
Wrap please.
- Niklas Nielsen
On Jan. 21, 2014, 12:05 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17013/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 12:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated tests to use Containerizer.
>
> A few isolator specific tests haven't been updated.
>
> The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
> src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
> src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
> src/tests/containerizer.hpp PRE-CREATION
> src/tests/containerizer.cpp PRE-CREATION
> src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
> src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
> src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
> src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
> src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
> src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027
> src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
> src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
> src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
> src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
> src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
> src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
>
> Diff: https://reviews.apache.org/r/17013/diff/
>
>
> Testing
> -------
>
> make check # OSX and Linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Feb. 12, 2014, 12:21 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Changes
-------
Adressed Ben's comments.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs (updated)
-----
src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
src/examples/balloon_framework.cpp d7abf1fd5500ec143edaae17422d5872ea7a9e7b
src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/balloon_framework_test.sh e7bf4e652e91b720f94342c69647146a49ad7f51
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 13348009dbdbde75447146c03c224b315d8a7e0f
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/environment.cpp 41b8a71f63b959abdaafca09bb3e0a5eeeae691b
src/tests/fault_tolerance_tests.cpp 130272cf4e4b4942a02792a648a3e7726cdb3da6
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp b42574be146c0e5a06dc25ba7b073b358721c648
src/tests/master_tests.cpp 70dab6fd9a4b5ea29067146b82c1ca584cde811a
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/#review33963
-----------------------------------------------------------
Ship it!
Looks good Ian. Let's get all this stuff committed please!
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment64000>
ASSERT_SOME(mounted);
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment64001>
.
src/tests/cluster.hpp
<https://reviews.apache.org/r/17013/#comment64002>
Please change wrapping to match style guide.
src/tests/cluster.hpp
<https://reviews.apache.org/r/17013/#comment64003>
Please fix wrapping.
src/tests/cluster.hpp
<https://reviews.apache.org/r/17013/#comment64004>
Wrapping.
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment64005>
Formatting.
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment64008>
Why a map here but hashmap below? A comment would be great for posterity.
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment63815>
Functions first, variables second please.
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment64006>
Don't forget to kill newlines across all these files please!
src/tests/containerizer.cpp
<https://reviews.apache.org/r/17013/#comment64007>
Wrapping.
src/tests/containerizer.cpp
<https://reviews.apache.org/r/17013/#comment64009>
Use 'contains' if you can use a hashmap.
src/tests/containerizer.cpp
<https://reviews.apache.org/r/17013/#comment64010>
Wrapping.
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/17013/#comment64011>
Consider wrapping.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64012>
Reorganize the includes.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64024>
Same comment about calling initialize on a process as in the previous reviews.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64025>
Please wrap after 'CopyFrom('.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64014>
I'd prefer not to require 'openssl' ... can you think of an alternative?
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64026>
Newline before comment please.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64027>
Please wrap.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64028>
Use the expected value first, actual value second (i.e., swapping _GE for _LT). That's what gtest expects (and prints out "expected XXX actual YYY" too).
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64029>
Wrap.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64030>
Newline before comment please.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64031>
Wrap.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64033>
Ah, I see now that this wasn't your bug, but please swap if you don't mind.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64034>
const & for Bytes?
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64039>
This is likely doing more than async-signal safe functions. Maybe worth mentioning above this function? Also, could you not invoke the balloon program?
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64035>
Wrap.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64036>
Newline.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64037>
Wrap. ;)
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment64038>
Suggestion: feel free to just do 'AWAIT_READY(isolator.method(...))' if you don't care about the future for anything else (i.e., for isolator.cleanup, isolator.destroy, etc for all of these tests).
src/tests/master_tests.cpp
<https://reviews.apache.org/r/17013/#comment64017>
Put a newline in between lines and comments please.
src/tests/mesos.cpp
<https://reviews.apache.org/r/17013/#comment64018>
ASSERT_SOME(mounted);
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment64019>
Reorganize.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment64020>
You only have to tell the compiler you're using it once, it's a pretty good listener. ;)
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment64022>
I think it's worthwhile to note that while you're explicit about the MesosContainerizer type you're not using 'TypeParam' to create the Containerizer but instead using Containerizer::create which ultimately determines the Containerizer type that gets created. That way in the future if someone wants to add another Containerizer type they won't have to do as much code spelunking to determine what they need to change.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment64023>
ASSERT_SOME(containerizer);
- Benjamin Hindman
On Feb. 7, 2014, 3:38 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17013/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 3:38 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated tests to use Containerizer.
>
> A few isolator specific tests haven't been updated.
>
> The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
>
>
> Diffs
> -----
>
> src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION
> src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION
> src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
> src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
> src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
> src/tests/containerizer.hpp PRE-CREATION
> src/tests/containerizer.cpp PRE-CREATION
> src/tests/environment.cpp 41b8a71f63b959abdaafca09bb3e0a5eeeae691b
> src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
> src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
> src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
> src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
> src/tests/master_contender_detector_tests.cpp 5223200ee59b9ce0e1d228320e8ad9e84a567288
> src/tests/master_tests.cpp 815149a6f6794e534c57b5767fdd18c776878dc0
> src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
> src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
> src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
> src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
> src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084
> src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
>
> Diff: https://reviews.apache.org/r/17013/diff/
>
>
> Testing
> -------
>
> make check # OSX and Linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Feb. 7, 2014, 3:38 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Changes
-------
Addressed Vinod's comments.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs (updated)
-----
src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION
src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/environment.cpp 41b8a71f63b959abdaafca09bb3e0a5eeeae691b
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 5223200ee59b9ce0e1d228320e8ad9e84a567288
src/tests/master_tests.cpp 815149a6f6794e534c57b5767fdd18c776878dc0
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/#review33878
-----------------------------------------------------------
Ship it!
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment63561>
kill this.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment63563>
kill this.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/17013/#comment63564>
s/base_hierarchy/baseHierarchy/
src/tests/containerizer.hpp
<https://reviews.apache.org/r/17013/#comment63565>
s/_//
src/tests/containerizer.cpp
<https://reviews.apache.org/r/17013/#comment63566>
indentation.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment63567>
new line?
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment63568>
new line.
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/17013/#comment63569>
new line.
src/tests/mesos.cpp
<https://reviews.apache.org/r/17013/#comment63570>
s/base_hierarchy/baseHierarchy/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment63571>
get rid of the comment. here and everywhere else.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/17013/#comment63572>
kill this.
- Vinod Kone
On Feb. 6, 2014, 5:31 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17013/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 5:31 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated tests to use Containerizer.
>
> A few isolator specific tests haven't been updated.
>
> The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
>
>
> Diffs
> -----
>
> src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION
> src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION
> src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
> src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
> src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
> src/tests/containerizer.hpp PRE-CREATION
> src/tests/containerizer.cpp PRE-CREATION
> src/tests/environment.cpp 41b8a71f63b959abdaafca09bb3e0a5eeeae691b
> src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
> src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
> src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
> src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
> src/tests/master_contender_detector_tests.cpp 5223200ee59b9ce0e1d228320e8ad9e84a567288
> src/tests/master_tests.cpp 815149a6f6794e534c57b5767fdd18c776878dc0
> src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
> src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
> src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
> src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
> src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084
> src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
>
> Diff: https://reviews.apache.org/r/17013/diff/
>
>
> Testing
> -------
>
> make check # OSX and Linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 5:31 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Changes
-------
Fixed cgroup tests. Reworked isolator tests to test cpu and memory.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs (updated)
-----
src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION
src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/environment.cpp 41b8a71f63b959abdaafca09bb3e0a5eeeae691b
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 5223200ee59b9ce0e1d228320e8ad9e84a567288
src/tests/master_tests.cpp 815149a6f6794e534c57b5767fdd18c776878dc0
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Feb. 1, 2014, 4:05 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Changes
-------
Rebased. New tests and enabling cgroups tests still pending.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs (updated)
-----
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 5223200ee59b9ce0e1d228320e8ad9e84a567288
src/tests/master_tests.cpp 815149a6f6794e534c57b5767fdd18c776878dc0
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp 7988c90b4b383bd822d1294a7f0318fbd9160dc6
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp b8c5123fb91373eb4582b88bf54c4119f6a0212b
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 3:04 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Changes
-------
Updated to use Containerizer interface. Remainder of changes not yet done, please defer review.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs (updated)
-----
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Jan. 21, 2014, 8:05 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs
-----
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes
Re: Review Request 17013: Containerizer - updated tests (part 5)
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17013/
-----------------------------------------------------------
(Updated Jan. 21, 2014, 7:38 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason Dusek, and Vinod Kone.
Repository: mesos-git
Description
-------
Updated tests to use Containerizer.
A few isolator specific tests haven't been updated.
The tests require a different cgroup mount configuration; please see https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation.
Diffs
-----
src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129
src/tests/cgroups_isolator_tests.cpp 1f5ce764a895fefb24126e39a283a8efc290d580
src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
src/tests/containerizer.hpp PRE-CREATION
src/tests/containerizer.cpp PRE-CREATION
src/tests/fault_tolerance_tests.cpp 60e06cc52d102ade687b095db474c0278ad508cc
src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c
src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458
src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1
src/tests/master_contender_detector_tests.cpp 9cd576f21561a86588ee0ea8a8458a9371284d47
src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027
src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18
src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874
src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf
src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a
Diff: https://reviews.apache.org/r/17013/diff/
Testing
-------
make check # OSX and Linux
Thanks,
Ian Downes