You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/29 10:23:50 UTC
[GitHub] [flink] KarmaGYZ commented on a change in pull request #9801:
[FLINK-13983][runtime] Launch task executor with new memory calculation
logics
KarmaGYZ commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r329347040
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java
##########
@@ -48,13 +48,17 @@
/** Environment variables to add to the Java process. */
private final HashMap<String, String> taskManagerEnv;
+ private final TaskExecutorResourceSpec taskExecutorResourceSpec;
+
public ContaineredTaskManagerParameters(
+ TaskExecutorResourceSpec taskExecutorResourceSpec,
Review comment:
I think we can add a new constructor just for the FLIP-49 code path, taking TaskExecutorResourceSpec, numSlots and taskManagerEnv to parameter list. It will simplify our work in cleaning the legacy code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services