You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/12 13:07:46 UTC
[GitHub] [flink] fapaul opened a new pull request #17459: Flink 24397 wh
fapaul opened a new pull request #17459:
URL: https://github.com/apache/flink/pull/17459
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The TableSchema has been deprecated for a while now unfortunately many of our connectors still use. This PR tries to address it and migrates the connectors to the new stack. (Schema/ResolvedSchema)
I'll create a follow-up ticket to do the same for the hive connector because it has some additional complexity. The only other connector which is missing is elasticsearch where we will address the TableSchema usage as part of https://issues.apache.org/jira/browse/FLINK-24323
## Brief change log
- Migrate TableSchema usages and remove outdated table connector code (Hbase, Kafka, Jdbc)
## Verifying this change
- All existing tests still pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727143646
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -80,14 +80,15 @@ public DynamicTableSink createDynamicTableSink(Context context) {
helper.validate();
validateConfigOptions(config);
JdbcConnectorOptions jdbcOptions = getJdbcOptions(config);
- TableSchema physicalSchema =
- TableSchemaUtils.getPhysicalSchema(context.getCatalogTable().getSchema());
return new JdbcDynamicTableSink(
jdbcOptions,
getJdbcExecutionOptions(config),
- getJdbcDmlOptions(jdbcOptions, physicalSchema),
- physicalSchema);
+ getJdbcDmlOptions(
+ jdbcOptions,
+ context.getCatalogTable().getUnresolvedSchema(),
Review comment:
Similar problem to the comment before I did not find a good way to represent the column type information and the primary key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987)
* a307c3581f04c323b897fa12699ff421e48bb88d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-941991770
@twalthr thanks for your review, I addressed all comments, can you have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940999978
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb (Tue Oct 12 13:12:07 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727156469
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcDataTypeTest.java
##########
@@ -101,50 +101,46 @@
createTestItem("postgresql", "ARRAY<INTEGER>"),
// Unsupported types throws errors.
- createTestItem(
- "derby", "BINARY", "The Derby dialect doesn't support type: BINARY(1)."),
createTestItem(
"derby",
- "VARBINARY(10)",
- "The Derby dialect doesn't support type: VARBINARY(10)."),
+ "BINARY",
+ "Unsupported conversion from data type 'BINARY(1)' (conversion class: [B) to type information. Only data types that originated from type information fully support a reverse conversion."),
Review comment:
Unfortunately, I am not really sure what the correct behavior here is. The problem is that this complete test never used the new JDBC connector and always tested with the old one which is now removed. It appears that with the new connector the exception signatures have changed.
Are you proposing to drop the test class completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
}, {
"hash" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25228",
"triggerID" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a7a93b33cebac710002818515ba9cec493c6dc2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77238fc01c44ecbd5addf1f0dada9baa9366ffc4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167)
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
}, {
"hash" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
* 0a7a93b33cebac710002818515ba9cec493c6dc2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a307c3581f04c323b897fa12699ff421e48bb88d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001)
* 77238fc01c44ecbd5addf1f0dada9baa9366ffc4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727142712
##########
File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptionsUtil.java
##########
@@ -57,8 +58,8 @@
* type columns in the schema. The PRIMARY KEY constraint is optional, if exist, the primary key
* constraint must be defined on the single row key field.
*/
- public static void validatePrimaryKey(TableSchema schema) {
- HBaseTableSchema hbaseSchema = HBaseTableSchema.fromTableSchema(schema);
+ public static void validatePrimaryKey(DataType dataType, Schema schema) {
Review comment:
The method requires knowledge about the primary key. AFAIK `DataType` does not offer such information. The only other option here would be to pass a `ResolvedSchema` (not sure that works for all the callers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77238fc01c44ecbd5addf1f0dada9baa9366ffc4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167)
* a10953a96419fc2a7ae7215b9d9c68172ed98bce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987)
* a307c3581f04c323b897fa12699ff421e48bb88d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-941991770
@twalthr thanks for your review, I addressed all comments, can you have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727142712
##########
File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptionsUtil.java
##########
@@ -57,8 +58,8 @@
* type columns in the schema. The PRIMARY KEY constraint is optional, if exist, the primary key
* constraint must be defined on the single row key field.
*/
- public static void validatePrimaryKey(TableSchema schema) {
- HBaseTableSchema hbaseSchema = HBaseTableSchema.fromTableSchema(schema);
+ public static void validatePrimaryKey(DataType dataType, Schema schema) {
Review comment:
The method requires knowledge about the primary key. AFAIK `DataType` does not offer such information. The only other option here would be to pass a `ResolvedSchema` (not sure that works for all the callers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a307c3581f04c323b897fa12699ff421e48bb88d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727125318
##########
File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptionsUtil.java
##########
@@ -57,8 +58,8 @@
* type columns in the schema. The PRIMARY KEY constraint is optional, if exist, the primary key
* constraint must be defined on the single row key field.
*/
- public static void validatePrimaryKey(TableSchema schema) {
- HBaseTableSchema hbaseSchema = HBaseTableSchema.fromTableSchema(schema);
+ public static void validatePrimaryKey(DataType dataType, Schema schema) {
Review comment:
Why is `Schema` necessary here?
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -80,14 +80,15 @@ public DynamicTableSink createDynamicTableSink(Context context) {
helper.validate();
validateConfigOptions(config);
JdbcConnectorOptions jdbcOptions = getJdbcOptions(config);
- TableSchema physicalSchema =
- TableSchemaUtils.getPhysicalSchema(context.getCatalogTable().getSchema());
return new JdbcDynamicTableSink(
jdbcOptions,
getJdbcExecutionOptions(config),
- getJdbcDmlOptions(jdbcOptions, physicalSchema),
- physicalSchema);
+ getJdbcDmlOptions(
+ jdbcOptions,
+ context.getCatalogTable().getUnresolvedSchema(),
Review comment:
can we remove passing this as well?
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactory.java
##########
@@ -225,7 +225,7 @@ public DynamicTableSink createDynamicTableSink(Context context) {
context.getObjectIdentifier(), context.getCatalogTable(), valueEncodingFormat);
final DataType physicalDataType =
- context.getCatalogTable().getSchema().toPhysicalRowDataType();
+ context.getCatalogTable().getResolvedSchema().toPhysicalRowDataType();
Review comment:
use the context method and don't go over `getCatalogTable()` anymore, as a reference implementation
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactory.java
##########
@@ -311,7 +311,7 @@ public DynamicTableSink createDynamicTableSink(Context context) {
private static void validatePKConstraints(
ObjectIdentifier tableName, CatalogTable catalogTable, Format format) {
- if (catalogTable.getSchema().getPrimaryKey().isPresent()
+ if (catalogTable.getUnresolvedSchema().getPrimaryKey().isPresent()
Review comment:
validate the context index array instead
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSink.java
##########
@@ -77,21 +77,22 @@ private void validatePrimaryKey(ChangelogMode requestedMode) {
@Override
public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
final TypeInformation<RowData> rowDataTypeInformation =
- context.createTypeInformation(tableSchema.toRowDataType());
+ context.createTypeInformation(physicalRowDataType);
final JdbcOutputFormatBuilder builder = new JdbcOutputFormatBuilder();
builder.setJdbcOptions(jdbcOptions);
builder.setJdbcDmlOptions(dmlOptions);
builder.setJdbcExecutionOptions(executionOptions);
builder.setRowDataTypeInfo(rowDataTypeInformation);
- builder.setFieldDataTypes(tableSchema.getFieldDataTypes());
+ builder.setFieldDataTypes(physicalRowDataType.getChildren().toArray(new DataType[0]));
Review comment:
nit: use `DataTypes.getFieldDataTypes` instead, just to be sure. `getChildren` would return something if the type is array or map.
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcDataTypeTest.java
##########
@@ -101,50 +101,46 @@
createTestItem("postgresql", "ARRAY<INTEGER>"),
// Unsupported types throws errors.
- createTestItem(
- "derby", "BINARY", "The Derby dialect doesn't support type: BINARY(1)."),
createTestItem(
"derby",
- "VARBINARY(10)",
- "The Derby dialect doesn't support type: VARBINARY(10)."),
+ "BINARY",
+ "Unsupported conversion from data type 'BINARY(1)' (conversion class: [B) to type information. Only data types that originated from type information fully support a reverse conversion."),
Review comment:
this exception seems wrong. we should not use a conversion from data type to legacy type information anymore
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -154,16 +153,17 @@ private JdbcExecutionOptions getJdbcExecutionOptions(ReadableConfig config) {
return builder.build();
}
- private JdbcDmlOptions getJdbcDmlOptions(JdbcConnectorOptions jdbcOptions, TableSchema schema) {
+ private JdbcDmlOptions getJdbcDmlOptions(
+ JdbcConnectorOptions jdbcOptions, Schema schema, DataType dataType) {
Review comment:
we can use the primary key indexes instead `Schema`
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcLookupFunction.java
##########
@@ -1,313 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.connector.jdbc.table;
-
-import org.apache.flink.annotation.VisibleForTesting;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
-import org.apache.flink.api.java.typeutils.RowTypeInfo;
-import org.apache.flink.connector.jdbc.internal.connection.JdbcConnectionProvider;
-import org.apache.flink.connector.jdbc.internal.connection.SimpleJdbcConnectionProvider;
-import org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions;
-import org.apache.flink.connector.jdbc.internal.options.JdbcLookupOptions;
-import org.apache.flink.connector.jdbc.statement.FieldNamedPreparedStatementImpl;
-import org.apache.flink.connector.jdbc.utils.JdbcTypeUtil;
-import org.apache.flink.connector.jdbc.utils.JdbcUtils;
-import org.apache.flink.table.functions.FunctionContext;
-import org.apache.flink.table.functions.TableFunction;
-import org.apache.flink.types.Row;
-
-import org.apache.flink.shaded.guava30.com.google.common.cache.Cache;
-import org.apache.flink.shaded.guava30.com.google.common.cache.CacheBuilder;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.concurrent.TimeUnit;
-
-import static org.apache.flink.connector.jdbc.utils.JdbcUtils.getFieldFromResultSet;
-import static org.apache.flink.util.Preconditions.checkArgument;
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A {@link TableFunction} to query fields from JDBC by keys. The query template like:
- *
- * <PRE>
- * SELECT c, d, e, f from T where a = ? and b = ?
- * </PRE>
- *
- * <p>Support cache the result to avoid frequent accessing to remote databases. 1.The cacheMaxSize
- * is -1 means not use cache. 2.For real-time data, you need to set the TTL of cache.
- */
-public class JdbcLookupFunction extends TableFunction<Row> {
Review comment:
can we drop this? is there a similar `RowData` one?
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java
##########
@@ -74,16 +73,16 @@ public LookupRuntimeProvider getLookupRuntimeProvider(LookupContext context) {
int[] innerKeyArr = context.getKeys()[i];
Preconditions.checkArgument(
innerKeyArr.length == 1, "JDBC only support non-nested look up keys");
- keyNames[i] = physicalSchema.getFieldNames()[innerKeyArr[0]];
+ keyNames[i] = DataType.getFieldNames(physicalRowDataType).get(innerKeyArr[0]);
}
- final RowType rowType = (RowType) physicalSchema.toRowDataType().getLogicalType();
+ final RowType rowType = (RowType) physicalRowDataType.getLogicalType();
return TableFunctionProvider.of(
new JdbcRowDataLookupFunction(
options,
lookupOptions,
- physicalSchema.getFieldNames(),
- physicalSchema.getFieldDataTypes(),
+ DataType.getFieldNames(physicalRowDataType).toArray(new String[0]),
+ physicalRowDataType.getChildren().toArray(new DataType[0]),
Review comment:
same comment as above: use `getFieldDataTypes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-946682837
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r730752796
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/JdbcDataTypeTest.java
##########
@@ -101,50 +101,46 @@
createTestItem("postgresql", "ARRAY<INTEGER>"),
// Unsupported types throws errors.
- createTestItem(
- "derby", "BINARY", "The Derby dialect doesn't support type: BINARY(1)."),
createTestItem(
"derby",
- "VARBINARY(10)",
- "The Derby dialect doesn't support type: VARBINARY(10)."),
+ "BINARY",
+ "Unsupported conversion from data type 'BINARY(1)' (conversion class: [B) to type information. Only data types that originated from type information fully support a reverse conversion."),
Review comment:
The exception indicates that are using a deprecated utility. We should analyze the stack trace where this exception is coming from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77238fc01c44ecbd5addf1f0dada9baa9366ffc4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17459:
URL: https://github.com/apache/flink/pull/17459#discussion_r727157348
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcLookupFunction.java
##########
@@ -1,313 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.connector.jdbc.table;
-
-import org.apache.flink.annotation.VisibleForTesting;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
-import org.apache.flink.api.java.typeutils.RowTypeInfo;
-import org.apache.flink.connector.jdbc.internal.connection.JdbcConnectionProvider;
-import org.apache.flink.connector.jdbc.internal.connection.SimpleJdbcConnectionProvider;
-import org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions;
-import org.apache.flink.connector.jdbc.internal.options.JdbcLookupOptions;
-import org.apache.flink.connector.jdbc.statement.FieldNamedPreparedStatementImpl;
-import org.apache.flink.connector.jdbc.utils.JdbcTypeUtil;
-import org.apache.flink.connector.jdbc.utils.JdbcUtils;
-import org.apache.flink.table.functions.FunctionContext;
-import org.apache.flink.table.functions.TableFunction;
-import org.apache.flink.types.Row;
-
-import org.apache.flink.shaded.guava30.com.google.common.cache.Cache;
-import org.apache.flink.shaded.guava30.com.google.common.cache.CacheBuilder;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.concurrent.TimeUnit;
-
-import static org.apache.flink.connector.jdbc.utils.JdbcUtils.getFieldFromResultSet;
-import static org.apache.flink.util.Preconditions.checkArgument;
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A {@link TableFunction} to query fields from JDBC by keys. The query template like:
- *
- * <PRE>
- * SELECT c, d, e, f from T where a = ? and b = ?
- * </PRE>
- *
- * <p>Support cache the result to avoid frequent accessing to remote databases. 1.The cacheMaxSize
- * is -1 means not use cache. 2.For real-time data, you need to set the TTL of cache.
- */
-public class JdbcLookupFunction extends TableFunction<Row> {
Review comment:
Yes there is a `RowData` one https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a307c3581f04c323b897fa12699ff421e48bb88d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001)
* 77238fc01c44ecbd5addf1f0dada9baa9366ffc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17459:
URL: https://github.com/apache/flink/pull/17459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24987",
"triggerID" : "69e676d0e426e4a9eb437b3bd4628f9c3cd3b7eb",
"triggerType" : "PUSH"
}, {
"hash" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25001",
"triggerID" : "a307c3581f04c323b897fa12699ff421e48bb88d",
"triggerType" : "PUSH"
}, {
"hash" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25167",
"triggerID" : "77238fc01c44ecbd5addf1f0dada9baa9366ffc4",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"triggerType" : "PUSH"
}, {
"hash" : "a10953a96419fc2a7ae7215b9d9c68172ed98bce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206",
"triggerID" : "946682837",
"triggerType" : "MANUAL"
}, {
"hash" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25228",
"triggerID" : "0a7a93b33cebac710002818515ba9cec493c6dc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10953a96419fc2a7ae7215b9d9c68172ed98bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25206)
* 0a7a93b33cebac710002818515ba9cec493c6dc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25228)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17459: [FLINK-24397] Remove TableSchema usages from Flink connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17459:
URL: https://github.com/apache/flink/pull/17459#issuecomment-940996979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org