You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/13 10:26:41 UTC

[GitHub] [incubator-devlake] likyh opened a new issue, #2489: [Refactor][apiClient] It needs document or refactor in `AfterResponse`

likyh opened a new issue, #2489:
URL: https://github.com/apache/incubator-devlake/issues/2489

   ## What and why to refactor
   It's confuse.
   
   https://github.com/apache/incubator-devlake/blob/bcc3267268a60d8e403fbda9006926b7c8ca93f9/plugins/github/tasks/api_client.go#L48
    
   `apiClient.SetAfterFunction` is called here but actually, it's no use, because it be reassign in `https://github.com/apache/incubator-devlake/blob/main/plugins/helper/api_collector.go#L118`.
   
   ## Describe the solution you'd like
   delete default value in api_collector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2489: [Refactor][apiClient] It needs document or refactor in `AfterResponse`

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on issue #2489:
URL: https://github.com/apache/incubator-devlake/issues/2489#issuecomment-1213609605

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mindlesscloud closed issue #2489: [Refactor][apiClient] It needs document or refactor in `AfterResponse`

Posted by GitBox <gi...@apache.org>.

mindlesscloud closed issue #2489: [Refactor][apiClient] It needs document or refactor in `AfterResponse`
URL: https://github.com/apache/incubator-devlake/issues/2489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org