You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2011/06/21 08:13:45 UTC

svn commit: r1137866 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Author: rjung
Date: Tue Jun 21 06:13:44 2011
New Revision: 1137866

URL: http://svn.apache.org/viewvc?rev=1137866&view=rev
Log:
Clarify difference between CATALINA_OPTS and
JAVA_OPTS in the scripts.

Feel free to improve wording and examples.

Modified:
    tomcat/trunk/bin/catalina.bat
    tomcat/trunk/bin/catalina.sh

Modified: tomcat/trunk/bin/catalina.bat
URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=1137866&r1=1137865&r2=1137866&view=diff
==============================================================================
--- tomcat/trunk/bin/catalina.bat (original)
+++ tomcat/trunk/bin/catalina.bat Tue Jun 21 06:13:44 2011
@@ -28,6 +28,10 @@ rem                   the same directory
 rem
 rem   CATALINA_OPTS   (Optional) Java runtime options used when the "start",
 rem                   or "run" command is executed.
+rem                   Include here and not in JAVA_OPTS all options, that should
+rem                   only be used by Tomcat itself, not by the stop process,
+rem                   the version command etc.
+rem                   Examples are heap size, GC logging, JMX ports etc.
 rem
 rem   CATALINA_TMPDIR (Optional) Directory path location of temporary directory
 rem                   the JVM should use (java.io.tmpdir).  Defaults to
@@ -42,6 +46,10 @@ rem                   are both set, JRE_
 rem
 rem   JAVA_OPTS       (Optional) Java runtime options used when the "start",
 rem                   "stop", or "run" command is executed.
+rem                   Include here and not in CATALINA_OPTS all options, thatr
+rem                   should be used by Tomcat and also by the stop process,
+rem                   the version command etc.
+rem                   Most options should go into CATALINA_OPTS.
 rem
 rem   JAVA_ENDORSED_DIRS (Optional) Lists of of semi-colon separated directories
 rem                   containing some jars in order to allow replacement of APIs 

Modified: tomcat/trunk/bin/catalina.sh
URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=1137866&r1=1137865&r2=1137866&view=diff
==============================================================================
--- tomcat/trunk/bin/catalina.sh (original)
+++ tomcat/trunk/bin/catalina.sh Tue Jun 21 06:13:44 2011
@@ -32,6 +32,10 @@
 #
 #   CATALINA_OPTS   (Optional) Java runtime options used when the "start",
 #                   or "run" command is executed.
+#                   Include here and not in JAVA_OPTS all options, that should
+#                   only be used by Tomcat itself, not by the stop process,
+#                   the version command etc.
+#                   Examples are heap size, GC logging, JMX ports etc.
 #
 #   CATALINA_TMPDIR (Optional) Directory path location of temporary directory
 #                   the JVM should use (java.io.tmpdir).  Defaults to
@@ -46,6 +50,10 @@
 #
 #   JAVA_OPTS       (Optional) Java runtime options used when the "start",
 #                   "stop", or "run" command is executed.
+#                   Include here and not in CATALINA_OPTS all options, thatr
+#                   should be used by Tomcat and also by the stop process,
+#                   the version command etc.
+#                   Most options should go into CATALINA_OPTS.
 #
 #   JAVA_ENDORSED_DIRS (Optional) Lists of of colon separated directories
 #                   containing some jars in order to allow replacement of APIs



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1137866 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Posted by Rainer Frey <ra...@inxmail.de>.
On 21.06.2011, at 08:13, rjung@apache.org wrote:

> rem   JAVA_OPTS       (Optional) Java runtime options used when the "start",
> rem                   "stop", or "run" command is executed.

This still sounds like JAVA_OPTS is not applied for version or configtest ...
Maybe just remove the list of commands and e.g. say:

rem   JAVA_OPTS       (Optional) Java runtime options used when any command is executed.

> +rem                   Include here and not in CATALINA_OPTS all options, thatr
                                                                               ^^
Typo.

> +rem                   should be used by Tomcat and also by the stop process,
> +rem                   the version command etc.
> +rem                   Most options should go into CATALINA_OPTS.

Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org