You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 12:49:59 UTC
[GitHub] [flink] TisonKun opened a new pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
TisonKun opened a new pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174
## What is the purpose of the change
Support IS JSON predicate for blink planner
IS_JSON_VALUE
IS_JSON_OBJECT
IS_JSON_ARRAY
IS_JSON_SCALAR
IS_NOT_JSON_VALUE
IS_NOT_JSON_OBJECT
IS_NOT_JSON_ARRAY
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152095453",
"triggerID" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f9edd40377c412486126a329eb8ea2c5885326f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151406057) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837)
* 7cb121128a3f3d89e32942df2850c76b38e076ae Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152095453)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-590071970
One small question not related to the code.
Do we have any consensus about the review process in the community. I'm asking because I see you have squashed your commits and force pushed to your current branch.
In my practice, usually I prefer keeping the commits during whole review process and not forcing push. So the reviewers can check only incremental changes next time which will save a lot of time. And Github itself can do the squash for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r383002789
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
Review comment:
Add a blank line between `package` and `import`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r385528122
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
+import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression}
+import org.apache.flink.table.types.logical.{BooleanType, LogicalType}
+
+/**
+ * Inverts the boolean value of a [[CallGenerator]] result.
+ */
+class NegativeCallGen(callGenerator: CallGenerator) extends CallGenerator {
+
+ override def generate(
+ ctx: CodeGeneratorContext,
+ operands: Seq[GeneratedExpression],
+ returnType: LogicalType
+ ): GeneratedExpression = {
+ assert(returnType.isInstanceOf[BooleanType])
+
+ val expr = callGenerator.generate(ctx, operands, returnType)
+ generateCallIfArgsNotNull(ctx, returnType, Seq(expr), returnType.isNullable) {
+ originalTerms =>
+ assert(originalTerms.size == 1)
+
+ s"!${originalTerms.head}"
+ }
Review comment:
Can simplify to
```scala
ScalarOperatorGens.generateNot(ctx, callGenerator.generate(ctx, operands, returnType))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150012026 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386220447
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f9edd40377c412486126a329eb8ea2c5885326f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151406057) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386215084
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
+import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression}
+import org.apache.flink.table.types.logical.{BooleanType, LogicalType}
+
+/**
+ * Inverts the boolean value of a [[CallGenerator]] result.
+ */
+class NegativeCallGen(callGenerator: CallGenerator) extends CallGenerator {
Review comment:
Renamed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-590075519
@TisonKun Thanks for your explanation, that makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150012026 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150199116) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486)
* c80a4b33ca4fede8ccfb000deb81005bb8d83710 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151333798) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r388752841
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/JsonFunctionsTest.scala
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions
+
+import org.apache.flink.table.api.ValidationException
+import org.apache.flink.table.planner.expressions.utils.ScalarTypesTestBase
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+class JsonFunctionsTest extends ScalarTypesTestBase {
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150199116) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r383004865
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150199116) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r385527809
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
+import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression}
+import org.apache.flink.table.types.logical.{BooleanType, LogicalType}
+
+/**
+ * Inverts the boolean value of a [[CallGenerator]] result.
+ */
+class NegativeCallGen(callGenerator: CallGenerator) extends CallGenerator {
Review comment:
In SQL, it is called `NOT`. We can call it `NotCallGen`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-590075145
@libenchao you're right the fixup commit helps on review. The community doesn't have a literal guide on this part but I think it depends on developers. For the very change, it is a minor change that doesn't cause review burden in my mind. For more complex contribution, we will use fixup commits and finally re-organize the commit for a clean commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c80a4b33ca4fede8ccfb000deb81005bb8d83710 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151333798) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813)
* 1f9edd40377c412486126a329eb8ea2c5885326f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151406057) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150012026 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
Hash:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419 TriggerType:PUSH TriggerID:e7a2eaa529eca12790f7a4ddb28b6acf7bef88be
-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589641033
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dace802f82ba2eb5f49a47032c4fa91eec9fd741 (Fri Feb 28 21:49:37 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150199116) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r388736245
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/JsonFunctionsTest.scala
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions
+
+import org.apache.flink.table.api.ValidationException
+import org.apache.flink.table.planner.expressions.utils.ScalarTypesTestBase
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+class JsonFunctionsTest extends ScalarTypesTestBase {
Review comment:
Do not extend `ScalarTypesTestBase`, let's define testing data for `JsonFunctionsTest` itself. I guess most of data in `ScalarTypesTestBase` is not suitable in `JsonFunctionsTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r388750794
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/JsonFunctionsTest.scala
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.expressions
+
+import org.apache.flink.table.api.ValidationException
+import org.apache.flink.table.planner.expressions.utils.ScalarTypesTestBase
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+class JsonFunctionsTest extends ScalarTypesTestBase {
Review comment:
OK. Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386300563
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4195,4 +4195,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"f55=f57",
"true")
}
+
+ @Test
+ def testIsJSONPredicates(): Unit = {
+ testSqlApi("'{}' is json value", "true")
+ testSqlApi("'{]' is json value", "false")
+ testSqlApi("'{}' is json object", "true")
+ testSqlApi("'[]' is json object", "false")
+ testSqlApi("'{}' is json array", "false")
+ testSqlApi("'[]' is json array", "true")
+ testSqlApi("'100' is json scalar", "true")
+ testSqlApi("'[]' is json scalar", "false")
+ testSqlApi("'{}' is not json value", "false")
+ testSqlApi("'{]' is not json value", "true")
+ testSqlApi("'{}' is not json object", "false")
+ testSqlApi("'[]' is not json object", "true")
+ testSqlApi("'{}' is not json array", "true")
+ testSqlApi("'[]' is not json array", "false")
+ testSqlApi("'100' is not json scalar", "false")
+ testSqlApi("'[]' is not json scalar", "true")
Review comment:
Added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589641231
Hi @wuchong please give it a review when you have spare time.
Besides, I'll appreciate it if anyone can guide me to the proper place document these new supported functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150199116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-596415232
@wuchong Thanks for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386215651
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4195,4 +4195,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"f55=f57",
"true")
}
+
+ @Test
+ def testIsJSONPredicates(): Unit = {
Review comment:
Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386220827
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
`FunctionGenerator` is not perfect now, we may need to declare different combinations of types. We will improve that in the future. But I think `VARCHAR` can suite both for CHAR and VARCHAR here. So let's reduce the combinations here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dace802f82ba2eb5f49a47032c4fa91eec9fd741 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150199116) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486)
* c80a4b33ca4fede8ccfb000deb81005bb8d83710 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f9edd40377c412486126a329eb8ea2c5885326f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151406057) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837)
* 7cb121128a3f3d89e32942df2850c76b38e076ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386215020
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
Thanks for your suggestion. Is it ditto for the rest of `CHAR` in these declarations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152095453",
"triggerID" : "7cb121128a3f3d89e32942df2850c76b38e076ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7cb121128a3f3d89e32942df2850c76b38e076ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152095453)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c80a4b33ca4fede8ccfb000deb81005bb8d83710 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151333798) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813)
* 1f9edd40377c412486126a329eb8ea2c5885326f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r385529970
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4195,4 +4195,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"f55=f57",
"true")
}
+
+ @Test
+ def testIsJSONPredicates(): Unit = {
+ testSqlApi("'{}' is json value", "true")
+ testSqlApi("'{]' is json value", "false")
+ testSqlApi("'{}' is json object", "true")
+ testSqlApi("'[]' is json object", "false")
+ testSqlApi("'{}' is json array", "false")
+ testSqlApi("'[]' is json array", "true")
+ testSqlApi("'100' is json scalar", "true")
+ testSqlApi("'[]' is json scalar", "false")
+ testSqlApi("'{}' is not json value", "false")
+ testSqlApi("'{]' is not json value", "true")
+ testSqlApi("'{}' is not json object", "false")
+ testSqlApi("'[]' is not json object", "true")
+ testSqlApi("'{}' is not json array", "true")
+ testSqlApi("'[]' is not json array", "false")
+ testSqlApi("'100' is not json scalar", "false")
+ testSqlApi("'[]' is not json scalar", "true")
Review comment:
Could you add some tests on a column reference? Currently, all the testing data is char.
Please also test on non-string columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-593325287
@wuchong thanks for your review! I've addressed comments. Please take another took :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong closed pull request #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r385529676
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
I think `VARCHAR` will be safer than `CHAR` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386215574
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/NegativeCallGen.scala
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+
+import org.apache.flink.table.planner.codegen.GenerateUtils.generateCallIfArgsNotNull
+import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression}
+import org.apache.flink.table.types.logical.{BooleanType, LogicalType}
+
+/**
+ * Inverts the boolean value of a [[CallGenerator]] result.
+ */
+class NegativeCallGen(callGenerator: CallGenerator) extends CallGenerator {
+
+ override def generate(
+ ctx: CodeGeneratorContext,
+ operands: Seq[GeneratedExpression],
+ returnType: LogicalType
+ ): GeneratedExpression = {
+ assert(returnType.isInstanceOf[BooleanType])
+
+ val expr = callGenerator.generate(ctx, operands, returnType)
+ generateCallIfArgsNotNull(ctx, returnType, Seq(expr), returnType.isNullable) {
+ originalTerms =>
+ assert(originalTerms.size == 1)
+
+ s"!${originalTerms.head}"
+ }
Review comment:
Thanks for your pointing out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11174: [FLINK-16199][sql]
Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589641033
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e7a2eaa529eca12790f7a4ddb28b6acf7bef88be (Fri Feb 21 12:53:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7a2eaa529eca12790f7a4ddb28b6acf7bef88be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150012026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151406057",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
}, {
"hash" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837",
"triggerID" : "1f9edd40377c412486126a329eb8ea2c5885326f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f9edd40377c412486126a329eb8ea2c5885326f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151406057) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r385526426
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4195,4 +4195,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"f55=f57",
"true")
}
+
+ @Test
+ def testIsJSONPredicates(): Unit = {
Review comment:
Let's move json tests to a new test class, e.g. `JsonFunctionsTest`. `ScalarFunctionsTest` is too large now.
Btw, let's use the lower case, `testIsJsonPredicates`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#issuecomment-589653271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150012026",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5419",
"triggerID" : "e7a2eaa529eca12790f7a4ddb28b6acf7bef88be",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150199116",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5486",
"triggerID" : "dace802f82ba2eb5f49a47032c4fa91eec9fd741",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151333798",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
}, {
"hash" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813",
"triggerID" : "c80a4b33ca4fede8ccfb000deb81005bb8d83710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c80a4b33ca4fede8ccfb000deb81005bb8d83710 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151333798) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5813)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11174:
[FLINK-16199][sql] Support IS JSON predicate for blink planner
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11174: [FLINK-16199][sql] Support IS JSON predicate for blink planner
URL: https://github.com/apache/flink/pull/11174#discussion_r386301412
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -753,6 +753,54 @@ object FunctionGenerator {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(
+ IS_JSON_VALUE,
+ Seq(CHAR),
Review comment:
Unfortunately after I change `CHAR` to `VARCHAR` the test cases `'[]'` and so on failed with mismatch. Thus I manually add `CHAR` *and* `VARCHAR` in `FunctionGenerator`. I agree that we can do follow-ups to ease the overhead of combinations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services