[jira] [Commented] (GROOVY-9237) GContracts and Groovy3

["Paul King (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918452#comment-16918452 ] 

Paul King commented on GROOVY-9237:
-----------------------------------

Just quickly looking at our code, it looks like we are trying to make it a singleton and deprecate the constructor. That was a binary breaking change. I wonder whether we can think of an alternative evolution path that doesn't break binary compatibility.

> GContracts and Groovy3
> ----------------------
>
>                 Key: GROOVY-9237
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9237
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Paul King
>            Priority: Minor
>
> The following runs fine in 2.5.8 (needs gcontracts and asm jars on classpath):
> {code}
> import org.gcontracts.annotations.Invariant
> import groovy.transform.*
> @Invariant({ month >= 1 && month <= 12 && day >= 1 && day <= lastDay[month-1] })
> @MapConstructor
> @ToString(includeNames=true)
> class Calendar {
>     private static final int[] lastDay = [31,29,31,30,31,30,31,31,30,31,30,31]
>     int month
>     int day
>     
>     def mutateByOneMonth() {
>         month++
>     }
> }
> new Calendar(month: 2, day: 2).mutateByOneMonth() // Okay
> new Calendar(month: 12, day: 2).mutateByOneMonth() // ClassInvariantViolation
> new Calendar(month: 1, day: 31).mutateByOneMonth() // ClassInvariantViolation
> {code}
> but with 3.0.0-beta-3 I get:
> {noformat}
> java.lang.IllegalAccessError: tried to access method org.codehaus.groovy.ast.stmt.EmptyStatement.<init>()V from class org.gcontracts.generation.TryCatchBlockGenerator
> {noformat}
> We should check whether we have made an unneeded breaking change or whether a gcontracts upgrade might be needed.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)