[jira] [Commented] (DRILL-5405) Add missing operator types without dependency on protobuf enum

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261932#comment-17261932 ] 

ASF GitHub Bot commented on DRILL-5405:
---------------------------------------

vvysotskyi opened a new pull request #2142:
URL: https://github.com/apache/drill/pull/2142


   # [DRILL-5405](https://issues.apache.org/jira/browse/DRILL-5405): Add missing operator types without dependency on protobuf enum
   
   ## Description
   Changed all operators to use string literals to provide operator type instead of int values that correspond to entries in protobuf enum. To preserve backward compatibility, `CoreOperatorType` was moved outside of probufs and used to deserialize older query profiles, so there is no need to update it every time when new operator or plugin is introduced. Newer query profiles will write both int value if the corresponding entry is present in `CoreOperatorType` and a new string value. So with these changes, older versions of Drill will be able to read profiles created by newer versions and newer versions of Drill will be able to read profiles created by older Drill.
   Storage plugins that use `EasyFormatConfig` may not specify `operatorType` value, in this case, it will be constructed using the default plugin name. For example, if the default name is `text`, `operatorType` will be `TEXT_SUB_SCAN`.
   
   ## Documentation
   NA
   
   ## Testing
   Checked manually different cases for backward compatibility.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add missing operator types without dependency on protobuf enum
> --------------------------------------------------------------
>
>                 Key: DRILL-5405
>                 URL: https://issues.apache.org/jira/browse/DRILL-5405
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: maprdb_sub_scan.JPG, unknown_operator.JPG
>
>
> Source - https://github.com/apache/drill/pull/214#discussion_r42687575
> When operators are not added into CoreOperatorType enum, they are displayed on Web UI as UNKNOWN_OPERATOR.
> Screenshots:
> now -> unknown_operator.JPG
> should be -> maprdb_sub_scan.JPG
> Though plugins work fine without this changes, it's still would be nice to display operator type on Web UI.
> But dependency on protobuf enum removes the ability for format plugins to truly be drop-in pluggable.
> In this case as option we may need to refactor this interface to just return a String and not use the protobuf enum, or have a separate "notes" field if we want to have a generic filescan operator ID in this enum with extra data to say what kind of scan we used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)