[GitHub] [iceberg] wypoon commented on pull request #4947: API: Add expression equivalence testing

[GitBox <gi...@apache.org>]

wypoon commented on PR #4947:
URL: https://github.com/apache/iceberg/pull/4947#issuecomment-1148015646

   @rdblue after I picked up this commit in master, my local build fails with
   ```
   Execution failed for task ':iceberg-api:revapi'.
   > There were Java public API/ABI breaks reported by revapi:
     
     java.method.addedToInterface: Method was added to an interface.
     
     old: <none>
     new: method boolean org.apache.iceberg.expressions.BoundTerm<T>::isEquivalentTo(org.apache.iceberg.expressions.BoundTerm<?>)
     
     SOURCE: BREAKING, BINARY: NON_BREAKING, SEMANTIC: POTENTIALLY_BREAKING
     
     From old archive: <none>
     From new archive: iceberg-api-0.14.0-SNAPSHOT.jar
     
     If this is an acceptable break that will not harm your users, you can ignore it in future runs like so for:
     
       * Just this break:
           ./gradlew :iceberg-api:revapiAcceptBreak --justification "{why this break is ok}" \
             --code "java.method.addedToInterface" \
             --new "method boolean org.apache.iceberg.expressions.BoundTerm<T>::isEquivalentTo(org.apache.iceberg.expressions.BoundTerm<?>)"
       * All breaks in this project:
           ./gradlew :iceberg-api:revapiAcceptAllBreaks --justification "{why this break is ok}"
       * All breaks in all projects:
           ./gradlew revapiAcceptAllBreaks --justification "{why this break is ok}"
     ----------------------------------------------------------------------------------------------------
   ```
   Do you need to add something to .palantir/revapi.yml?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org