[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #253: [WIP] Register existing tables in Iceberg HiveCatalog

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #253: [WIP] Register existing tables in Iceberg HiveCatalog
URL: https://github.com/apache/incubator-iceberg/pull/253#discussion_r300879821
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
 ##########
 @@ -79,4 +79,8 @@ public Table loadTable(TableIdentifier identifier) {
   protected abstract TableOperations newTableOps(Configuration newConf, TableIdentifier tableIdentifier);
 
   protected abstract String defaultWarehouseLocation(Configuration hadoopConf, TableIdentifier tableIdentifier);
+
+  protected Configuration conf() {
+    return conf;
 
 Review comment:
   I should have caught this before, but this API should not use a Hadoop `Configuration`. This should just be part of the `HiveCatalog`, not the abstract class because all the abstract class does is pass it back to the implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org