You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/06 02:49:00 UTC

[GitHub] [superset] graceguo-supercat opened a new issue #12299: [explore] datapanel search should not case sensitive

graceguo-supercat opened a new issue #12299:
URL: https://github.com/apache/superset/issues/12299


   #### Screenshots
   
   ![fnLVBHBoVP](https://user-images.githubusercontent.com/27990562/103723210-65610080-4f86-11eb-88e1-80e33b21a0bb.gif)
   
   #### How to reproduce the bug
   
   1. Go to explore view, search "SUM" in datapanel
   2. found no match
   3. search "sum", you will find some results
   
   
   ### Environment
   
   latest master
   
   cc @junlincc @zuzana-vej 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755051975


   > I'd recommend utilize [match-sorter](https://www.npmjs.com/package/match-sorter) for things like this.
   > 
   > E.g.
   > 
   > https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123
   
   Thanks ^
   we have the metric section search not case sensitive actually...
   agree they should be same, will change it real quick~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755051975


   > I'd recommend utilize [match-sorter](https://www.npmjs.com/package/match-sorter) for things like this.
   > 
   > E.g.
   > 
   > https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123
   
   Thanks ^
   we have the metric section search not case sensitive actually...
   agree they should be the same, will change it real quick~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-756391491


   resolved, closing. thanks @pkdotson 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755044200


   I'd recommend utilize [match-sorter](https://www.npmjs.com/package/match-sorter) for things like this.
   
   E.g.
   
   https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755844247


   > we have the metric section search not case sensitive actually...
   > agree they should be the same, will change it real quick~
   
   in my screenshot you will see i am searching metrics name, and it is case sensitive right now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755051975


   > I'd recommend utilize [match-sorter](https://www.npmjs.com/package/match-sorter) for things like this.
   > 
   > E.g.
   > 
   > https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123
   
   we have the metric section search not case sensitive actually...
   agree they should be same, will change it real quick~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] issue-label-bot[bot] commented on issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #12299:
URL: https://github.com/apache/superset/issues/12299#issuecomment-755041692


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.96. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc closed issue #12299: [explore] datapanel search should not case sensitive

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12299:
URL: https://github.com/apache/superset/issues/12299


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org